From: Tim Harvey <tharvey@gateworks.com> To: Tudor Ambarus <Tudor.Ambarus@microchip.com> Cc: Michael Walle <michael@walle.cc>, Richard Weinberger <richard@nod.at>, p.yadav@ti.com, vigneshr@ti.com, Device Tree Mailing List <devicetree@vger.kernel.org>, NXP Linux Team <linux-imx@nxp.com>, Fabio Estevam <festevam@gmail.com>, Sascha Hauer <kernel@pengutronix.de>, Sascha Hauer <s.hauer@pengutronix.de>, Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Miquel Raynal <miquel.raynal@bootlin.com>, linux-mtd@lists.infradead.org, open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 1/4] dt-bindings: at25: add Fujitsu MB85RS4MT Date: Thu, 11 Mar 2021 14:39:07 -0800 [thread overview] Message-ID: <CAJ+vNU1urqqDKrH5HNsUz=Wb-Rtr+dMzEnJ3=gMJv6+qz29n2g@mail.gmail.com> (raw) In-Reply-To: <3d497991-1470-e188-8be2-e5992dfa914c@microchip.com> 'On Tue, Mar 9, 2021 at 9:34 PM <Tudor.Ambarus@microchip.com> wrote: > > On 3/10/21 12:59 AM, Michael Walle wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > Hi Tim, > > > > Am 2021-03-09 23:00, schrieb Tim Harvey: > >> Document the compatible value for the Fujitsu MB85RS4MT SPI > >> FRAM EEPROM device so that it can be used in DTS files. > >> > >> This is a 512KiB FRAM EEPROM. > >> > >> Signed-off-by: Tim Harvey <tharvey@gateworks.com> > >> --- > >> Documentation/devicetree/bindings/eeprom/at25.yaml | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Documentation/devicetree/bindings/eeprom/at25.yaml > >> b/Documentation/devicetree/bindings/eeprom/at25.yaml > >> index 6a2dc8b3ed14..f594db72b711 100644 > >> --- a/Documentation/devicetree/bindings/eeprom/at25.yaml > >> +++ b/Documentation/devicetree/bindings/eeprom/at25.yaml > >> @@ -26,6 +26,7 @@ properties: > >> - anvo,anv32e61w > >> - atmel,at25256B > >> - fujitsu,mb85rs1mt > >> + - fujitsu,mb85rs4mt > >> - fujitsu,mb85rs64 > >> - microchip,at25160bn > >> - microchip,25lc040 > > > > Hm, the driver is spi-nor but this is for the at25 driver. Is > > this correct? Doesn't it work if you just add the ID to > > spi-nor/fujitsu.c and use 'compatible = "jedec,spi-nor' ? > > > > Tim, > > Can you try and see if you can work with this flash by setting "atmel,at25" > compatible? It does not work with 'atmel,at25'. I was fooled into adding it to at25.yaml because that is where the mb85rs1mt compatible was. I suppose at some time the drivers were split as mb85rs1mt is clearly in the spi-nor driver now. I will drop the patch to at25.yaml and now that I realize all I need is 'jedec,spi-nor' I won't need any bindings patch. > > There are some SPI NOR-like flashes MRAMs, FRAMs, even EEPROMs, that share > a part of opcodes of SPI NORs, but have slightly different characteristics > (ex. no erase, no wait times for writes on FRAMs). > See the patch series submitted by Richard, that I have stalled: > https://patchwork.ozlabs.org/project/linux-mtd/list/?series=208584&state=* > This series makes sense to me. I tested it and indeed it provides a vast performance improvement. Richards patch would collide with my patch that adds the mb85rs4mt detection. Let me know what you're going to do there and if you need me to rebase 'mtd: spi-nor: fujitsu: add support for MB85RS4MT' on top of it. Best regards, Tim
WARNING: multiple messages have this Message-ID (diff)
From: Tim Harvey <tharvey@gateworks.com> To: Tudor Ambarus <Tudor.Ambarus@microchip.com> Cc: Michael Walle <michael@walle.cc>, Richard Weinberger <richard@nod.at>, p.yadav@ti.com, vigneshr@ti.com, Device Tree Mailing List <devicetree@vger.kernel.org>, NXP Linux Team <linux-imx@nxp.com>, Fabio Estevam <festevam@gmail.com>, Sascha Hauer <kernel@pengutronix.de>, Sascha Hauer <s.hauer@pengutronix.de>, Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Miquel Raynal <miquel.raynal@bootlin.com>, linux-mtd@lists.infradead.org, open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 1/4] dt-bindings: at25: add Fujitsu MB85RS4MT Date: Thu, 11 Mar 2021 14:39:07 -0800 [thread overview] Message-ID: <CAJ+vNU1urqqDKrH5HNsUz=Wb-Rtr+dMzEnJ3=gMJv6+qz29n2g@mail.gmail.com> (raw) In-Reply-To: <3d497991-1470-e188-8be2-e5992dfa914c@microchip.com> 'On Tue, Mar 9, 2021 at 9:34 PM <Tudor.Ambarus@microchip.com> wrote: > > On 3/10/21 12:59 AM, Michael Walle wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > Hi Tim, > > > > Am 2021-03-09 23:00, schrieb Tim Harvey: > >> Document the compatible value for the Fujitsu MB85RS4MT SPI > >> FRAM EEPROM device so that it can be used in DTS files. > >> > >> This is a 512KiB FRAM EEPROM. > >> > >> Signed-off-by: Tim Harvey <tharvey@gateworks.com> > >> --- > >> Documentation/devicetree/bindings/eeprom/at25.yaml | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Documentation/devicetree/bindings/eeprom/at25.yaml > >> b/Documentation/devicetree/bindings/eeprom/at25.yaml > >> index 6a2dc8b3ed14..f594db72b711 100644 > >> --- a/Documentation/devicetree/bindings/eeprom/at25.yaml > >> +++ b/Documentation/devicetree/bindings/eeprom/at25.yaml > >> @@ -26,6 +26,7 @@ properties: > >> - anvo,anv32e61w > >> - atmel,at25256B > >> - fujitsu,mb85rs1mt > >> + - fujitsu,mb85rs4mt > >> - fujitsu,mb85rs64 > >> - microchip,at25160bn > >> - microchip,25lc040 > > > > Hm, the driver is spi-nor but this is for the at25 driver. Is > > this correct? Doesn't it work if you just add the ID to > > spi-nor/fujitsu.c and use 'compatible = "jedec,spi-nor' ? > > > > Tim, > > Can you try and see if you can work with this flash by setting "atmel,at25" > compatible? It does not work with 'atmel,at25'. I was fooled into adding it to at25.yaml because that is where the mb85rs1mt compatible was. I suppose at some time the drivers were split as mb85rs1mt is clearly in the spi-nor driver now. I will drop the patch to at25.yaml and now that I realize all I need is 'jedec,spi-nor' I won't need any bindings patch. > > There are some SPI NOR-like flashes MRAMs, FRAMs, even EEPROMs, that share > a part of opcodes of SPI NORs, but have slightly different characteristics > (ex. no erase, no wait times for writes on FRAMs). > See the patch series submitted by Richard, that I have stalled: > https://patchwork.ozlabs.org/project/linux-mtd/list/?series=208584&state=* > This series makes sense to me. I tested it and indeed it provides a vast performance improvement. Richards patch would collide with my patch that adds the mb85rs4mt detection. Let me know what you're going to do there and if you need me to rebase 'mtd: spi-nor: fujitsu: add support for MB85RS4MT' on top of it. Best regards, Tim ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-03-11 22:39 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-09 22:00 [PATCH 1/4] dt-bindings: at25: add Fujitsu MB85RS4MT Tim Harvey 2021-03-09 22:00 ` Tim Harvey 2021-03-09 22:00 ` [PATCH 2/4] mtd: spi-nor: fujitsu: add support for MB85RS4MT Tim Harvey 2021-03-09 22:00 ` Tim Harvey 2021-03-09 22:00 ` [PATCH 3/4] dt-bindings: arm: imx: add imx8mm gw7901 support Tim Harvey 2021-03-09 22:00 ` Tim Harvey 2021-03-16 22:23 ` Rob Herring 2021-03-16 22:23 ` Rob Herring 2021-03-09 22:00 ` [PATCH 4/4] arm64: dts: imx: Add i.mx8mm Gateworks gw7901 dts support Tim Harvey 2021-03-09 22:00 ` Tim Harvey 2021-03-09 22:59 ` [PATCH 1/4] dt-bindings: at25: add Fujitsu MB85RS4MT Michael Walle 2021-03-09 22:59 ` Michael Walle 2021-03-10 5:33 ` Tudor.Ambarus 2021-03-10 5:33 ` Tudor.Ambarus 2021-03-11 22:39 ` Tim Harvey [this message] 2021-03-11 22:39 ` Tim Harvey 2021-03-11 1:52 ` Tim Harvey 2021-03-11 1:52 ` Tim Harvey
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJ+vNU1urqqDKrH5HNsUz=Wb-Rtr+dMzEnJ3=gMJv6+qz29n2g@mail.gmail.com' \ --to=tharvey@gateworks.com \ --cc=Tudor.Ambarus@microchip.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=michael@walle.cc \ --cc=miquel.raynal@bootlin.com \ --cc=p.yadav@ti.com \ --cc=richard@nod.at \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.