From: Sibi Sankar <sibis@codeaurora.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org, joro@8bytes.org,
ohad@wizery.com, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
agross@kernel.org, linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH 0/3] Request direct mapping for modem firmware subdevice
Date: Mon, 16 Mar 2020 22:07:04 +0530 [thread overview]
Message-ID: <8cfddb6cbc424b131c9ab823c0c0f3f1@codeaurora.org> (raw)
In-Reply-To: <20200316155028.GB18704@infradead.org>
Hey Christoph,
Thanks for taking time to review
the series.
On 2020-03-16 21:20, Christoph Hellwig wrote:
> On Mon, Mar 09, 2020 at 11:52:52PM +0530, Sibi Sankar wrote:
>> The Q6 modem sub-system has direct access to DDR through memnoc and
>> an indirect access routed through a SMMU which MSS CE (crypto engine
>> sub-component of MSS) uses during out of reset sequence. Request
>> direct
>> mapping for the modem-firmware subdevice since smmu is not expected
>> to provide access control/translation for these SIDs (sandboxing of
>> the
>> modem is achieved through XPUs engaged using SMC calls).
>
> Please fix your device tree so that the device isn't bound to an
> IOMMU.
the bindings proposed in the series
would add a sub-device with an iommu
property.
modem_pil: remoteproc@xxxxx {
...
modem-firmware {
iommus = <&apps_smmu 0x460 0x1>;
};
...
};
Remoteproc device will not have a iommu
property but modem-firmware sub-device
will.
With ARM_SMMU_DISABLE_BYPASS_BY_DEFAULT y,
we would want to configure the SID either
in direct mapping or bypass (either will
do since protection is achieved through
other means)
https://lore.kernel.org/lkml/497e40b8-300f-1b83-4312-93a58c459d1d@arm.com/
Currently the restructuring is trending
towards whats discussed in the ^^ thread.
i.e either direct mapping/bypass will be
done in the SoC specific corner of the
SMMU driver.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
WARNING: multiple messages have this Message-ID (diff)
From: Sibi Sankar <sibis@codeaurora.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: ohad@wizery.com, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org,
iommu@lists.linux-foundation.org, robh+dt@kernel.org,
agross@kernel.org, linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH 0/3] Request direct mapping for modem firmware subdevice
Date: Mon, 16 Mar 2020 22:07:04 +0530 [thread overview]
Message-ID: <8cfddb6cbc424b131c9ab823c0c0f3f1@codeaurora.org> (raw)
In-Reply-To: <20200316155028.GB18704@infradead.org>
Hey Christoph,
Thanks for taking time to review
the series.
On 2020-03-16 21:20, Christoph Hellwig wrote:
> On Mon, Mar 09, 2020 at 11:52:52PM +0530, Sibi Sankar wrote:
>> The Q6 modem sub-system has direct access to DDR through memnoc and
>> an indirect access routed through a SMMU which MSS CE (crypto engine
>> sub-component of MSS) uses during out of reset sequence. Request
>> direct
>> mapping for the modem-firmware subdevice since smmu is not expected
>> to provide access control/translation for these SIDs (sandboxing of
>> the
>> modem is achieved through XPUs engaged using SMC calls).
>
> Please fix your device tree so that the device isn't bound to an
> IOMMU.
the bindings proposed in the series
would add a sub-device with an iommu
property.
modem_pil: remoteproc@xxxxx {
...
modem-firmware {
iommus = <&apps_smmu 0x460 0x1>;
};
...
};
Remoteproc device will not have a iommu
property but modem-firmware sub-device
will.
With ARM_SMMU_DISABLE_BYPASS_BY_DEFAULT y,
we would want to configure the SID either
in direct mapping or bypass (either will
do since protection is achieved through
other means)
https://lore.kernel.org/lkml/497e40b8-300f-1b83-4312-93a58c459d1d@arm.com/
Currently the restructuring is trending
towards whats discussed in the ^^ thread.
i.e either direct mapping/bypass will be
done in the SoC specific corner of the
SMMU driver.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-03-16 16:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 18:22 [PATCH 0/3] Request direct mapping for modem firmware subdevice Sibi Sankar
2020-03-09 18:22 ` Sibi Sankar
2020-03-09 18:22 ` [PATCH 1/3] iommu: Export "iommu_request_dm_for_dev" Sibi Sankar
2020-03-09 18:22 ` Sibi Sankar
2020-03-09 18:22 ` [PATCH 2/3] dt-bindings: remoteproc: qcom: Add modem-firmware bindings Sibi Sankar
2020-03-09 18:22 ` Sibi Sankar
2020-03-09 18:22 ` [PATCH 3/3] remoteproc: qcom_q6v5_mss: Request direct mapping for firmware subdevice Sibi Sankar
2020-03-09 18:22 ` Sibi Sankar
2020-03-10 11:23 ` [PATCH 0/3] Request direct mapping for modem " Joerg Roedel
2020-03-10 11:23 ` Joerg Roedel
2020-03-10 14:00 ` Sibi Sankar
2020-03-10 14:00 ` Sibi Sankar
2020-03-10 16:23 ` Joerg Roedel
2020-03-10 16:23 ` Joerg Roedel
2020-03-10 16:44 ` Robin Murphy
2020-03-10 16:44 ` Robin Murphy
2020-03-12 6:28 ` Sai Prakash Ranjan
2020-03-12 6:28 ` Sai Prakash Ranjan
2020-03-12 12:05 ` Robin Murphy
2020-03-12 12:05 ` Robin Murphy
2020-03-23 9:43 ` Sai Prakash Ranjan
2020-03-23 9:43 ` Sai Prakash Ranjan
2020-03-16 15:50 ` Christoph Hellwig
2020-03-16 15:50 ` Christoph Hellwig
2020-03-16 16:37 ` Sibi Sankar [this message]
2020-03-16 16:37 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cfddb6cbc424b131c9ab823c0c0f3f1@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.