* [PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working USB port
@ 2022-03-22 16:17 Marek Behún
2022-03-23 5:55 ` Stefan Roese
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Marek Behún @ 2022-03-22 16:17 UTC (permalink / raw)
To: Stefan Roese; +Cc: u-boot, pali, Marek Behún
From: Marek Behún <marek.behun@nic.cz>
Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from
upstream Linux kernel") ported Linux's device-tree files for Armada 3720
SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus
voltage supply is described as a `phy-supply` property of connector
node, a mechanism that is not supported in U-Boot yet.
For now, fix this by adding `vbus-supply` to usb3 node.
Fixes: 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel")
Signed-off-by: Marek Behún <marek.behun@nic.cz>
---
Dear Stefan, as with the network issue, could we get this to master ASAP?
---
arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
index 2e05b973d2..28a36a6103 100644
--- a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
+++ b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
@@ -21,3 +21,7 @@
};
/delete-node/ &mdio;
+
+&usb3 {
+ vbus-supply = <&exp_usb3_vbus>;
+};
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working USB port
2022-03-22 16:17 [PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working USB port Marek Behún
@ 2022-03-23 5:55 ` Stefan Roese
2022-03-23 6:46 ` Stefan Roese
2022-03-23 13:00 ` Pali Rohár
2022-03-23 13:05 ` Tom Rini
2 siblings, 1 reply; 6+ messages in thread
From: Stefan Roese @ 2022-03-23 5:55 UTC (permalink / raw)
To: Marek Behún; +Cc: u-boot, pali, Marek Behún
On 3/22/22 17:17, Marek Behún wrote:
> From: Marek Behún <marek.behun@nic.cz>
>
> Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from
> upstream Linux kernel") ported Linux's device-tree files for Armada 3720
> SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus
> voltage supply is described as a `phy-supply` property of connector
> node, a mechanism that is not supported in U-Boot yet.
>
> For now, fix this by adding `vbus-supply` to usb3 node.
>
> Fixes: 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel")
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Stefan Roese <sr@denx.de>
> ---
> Dear Stefan, as with the network issue, could we get this to master ASAP?
Sure. Let me try...
Thanks,
Stefan
> ---
> arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
> index 2e05b973d2..28a36a6103 100644
> --- a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
> +++ b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
> @@ -21,3 +21,7 @@
> };
>
> /delete-node/ &mdio;
> +
> +&usb3 {
> + vbus-supply = <&exp_usb3_vbus>;
> +};
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working USB port
2022-03-23 5:55 ` Stefan Roese
@ 2022-03-23 6:46 ` Stefan Roese
2022-03-23 11:46 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Roese @ 2022-03-23 6:46 UTC (permalink / raw)
To: Marek Behún, Tom Rini; +Cc: u-boot, pali, Marek Behún
Added Tom to Cc.
On 3/23/22 06:55, Stefan Roese wrote:
> On 3/22/22 17:17, Marek Behún wrote:
>> From: Marek Behún <marek.behun@nic.cz>
>>
>> Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from
>> upstream Linux kernel") ported Linux's device-tree files for Armada 3720
>> SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus
>> voltage supply is described as a `phy-supply` property of connector
>> node, a mechanism that is not supported in U-Boot yet.
>>
>> For now, fix this by adding `vbus-supply` to usb3 node.
>>
>> Fixes: 0934dddc6436 ("arm: a37xx: Update DTS files to version from
>> upstream Linux kernel")
>> Signed-off-by: Marek Behún <marek.behun@nic.cz>
>
> Reviewed-by: Stefan Roese <sr@denx.de>
>
>> ---
>> Dear Stefan, as with the network issue, could we get this to master ASAP?
>
> Sure. Let me try...
Tom, I'm having trouble with CI, Azure and Gitlab both report problems
with "test.py coreboot":
https://dev.azure.com/sr0718/u-boot/_build/results?buildId=167&view=results
This should not result from this patch though.
Could you please pull this patch/fix directly?
Thanks,
Stefan
> Thanks,
> Stefan
>
>> ---
>> arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
>> b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
>> index 2e05b973d2..28a36a6103 100644
>> --- a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
>> +++ b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
>> @@ -21,3 +21,7 @@
>> };
>> /delete-node/ &mdio;
>> +
>> +&usb3 {
>> + vbus-supply = <&exp_usb3_vbus>;
>> +};
>
> Viele Grüße,
> Stefan Roese
>
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working USB port
2022-03-23 6:46 ` Stefan Roese
@ 2022-03-23 11:46 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2022-03-23 11:46 UTC (permalink / raw)
To: Stefan Roese; +Cc: Marek Behún, u-boot, pali, Marek Behún
[-- Attachment #1: Type: text/plain, Size: 1416 bytes --]
On Wed, Mar 23, 2022 at 07:46:40AM +0100, Stefan Roese wrote:
> Added Tom to Cc.
>
> On 3/23/22 06:55, Stefan Roese wrote:
> > On 3/22/22 17:17, Marek Behún wrote:
> > > From: Marek Behún <marek.behun@nic.cz>
> > >
> > > Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from
> > > upstream Linux kernel") ported Linux's device-tree files for Armada 3720
> > > SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus
> > > voltage supply is described as a `phy-supply` property of connector
> > > node, a mechanism that is not supported in U-Boot yet.
> > >
> > > For now, fix this by adding `vbus-supply` to usb3 node.
> > >
> > > Fixes: 0934dddc6436 ("arm: a37xx: Update DTS files to version from
> > > upstream Linux kernel")
> > > Signed-off-by: Marek Behún <marek.behun@nic.cz>
> >
> > Reviewed-by: Stefan Roese <sr@denx.de>
> >
> > > ---
> > > Dear Stefan, as with the network issue, could we get this to master ASAP?
> >
> > Sure. Let me try...
>
> Tom, I'm having trouble with CI, Azure and Gitlab both report problems
> with "test.py coreboot":
>
> https://dev.azure.com/sr0718/u-boot/_build/results?buildId=167&view=results
>
> This should not result from this patch though.
Yes, Google is being funny for some reason, I just keep hitting retry
until it passes.
> Could you please pull this patch/fix directly?
OK.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working USB port
2022-03-22 16:17 [PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working USB port Marek Behún
2022-03-23 5:55 ` Stefan Roese
@ 2022-03-23 13:00 ` Pali Rohár
2022-03-23 13:05 ` Tom Rini
2 siblings, 0 replies; 6+ messages in thread
From: Pali Rohár @ 2022-03-23 13:00 UTC (permalink / raw)
To: Marek Behún; +Cc: Stefan Roese, u-boot, Marek Behún
On Tuesday 22 March 2022 17:17:59 Marek Behún wrote:
> From: Marek Behún <marek.behun@nic.cz>
>
> Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from
> upstream Linux kernel") ported Linux's device-tree files for Armada 3720
> SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus
> voltage supply is described as a `phy-supply` property of connector
> node, a mechanism that is not supported in U-Boot yet.
>
> For now, fix this by adding `vbus-supply` to usb3 node.
>
> Fixes: 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel")
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Pali Rohár <pali@kernel.org>
Btw, now I tested USB2.0 and USB3.0 ports on Espressobin v5 (another
Armada 3720 board) and both are working fine in U-Boot. Therefore no USB
fix is needed for Espressobin DTS file.
> ---
> Dear Stefan, as with the network issue, could we get this to master ASAP?
> ---
> arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
> index 2e05b973d2..28a36a6103 100644
> --- a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
> +++ b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
> @@ -21,3 +21,7 @@
> };
>
> /delete-node/ &mdio;
> +
> +&usb3 {
> + vbus-supply = <&exp_usb3_vbus>;
> +};
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working USB port
2022-03-22 16:17 [PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working USB port Marek Behún
2022-03-23 5:55 ` Stefan Roese
2022-03-23 13:00 ` Pali Rohár
@ 2022-03-23 13:05 ` Tom Rini
2 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2022-03-23 13:05 UTC (permalink / raw)
To: Marek Behún; +Cc: Stefan Roese, u-boot, pali, Marek Behún
[-- Attachment #1: Type: text/plain, Size: 762 bytes --]
On Tue, Mar 22, 2022 at 05:17:59PM +0100, Marek Behún wrote:
> From: Marek Behún <marek.behun@nic.cz>
>
> Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from
> upstream Linux kernel") ported Linux's device-tree files for Armada 3720
> SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus
> voltage supply is described as a `phy-supply` property of connector
> node, a mechanism that is not supported in U-Boot yet.
>
> For now, fix this by adding `vbus-supply` to usb3 node.
>
> Fixes: 0934dddc6436 ("arm: a37xx: Update DTS files to version from upstream Linux kernel")
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> Reviewed-by: Stefan Roese <sr@denx.de>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-23 13:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-22 16:17 [PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working USB port Marek Behún
2022-03-23 5:55 ` Stefan Roese
2022-03-23 6:46 ` Stefan Roese
2022-03-23 11:46 ` Tom Rini
2022-03-23 13:00 ` Pali Rohár
2022-03-23 13:05 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.