From: Florian Weimer <fweimer@redhat.com>
To: Jeff Layton <jlayton@redhat.com>, Mike Frysinger <vapier@gentoo.org>
Cc: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
libc-alpha@sourceware.org, linux-fsdevel@vger.kernel.org,
"Carlos O'Donell" <carlos@redhat.com>,
Yuriy Kolerov <Yuriy.Kolerov@synopsys.com>
Subject: Re: [glibc PATCH] fcntl: put F_OFD_* constants under #ifdef __USE_FILE_OFFSET64
Date: Thu, 18 Aug 2016 11:00:05 +0200 [thread overview]
Message-ID: <8e1a972a-7966-139b-9d75-6d3a847a1be8@redhat.com> (raw)
In-Reply-To: <1471470526.3196.153.camel@redhat.com>
On 08/17/2016 11:48 PM, Jeff Layton wrote:
> So yeah, I think what I proposed before would probably be fine. But now
> that Michael pushed the issue, it's dawned on me that we may be able to
> get away with supporting it better if we turn the compatability
> mechanism on its head and use F_OFD_*32 constants in the non-LFS case.
That's rather confusing to programmers, though.
We then have:
F_OFD_SETLK always 64-bit
F_SETLK 32-bit or 64-bit
F_SETLK64 always 64-bit (not recommended)
F_OFD_SETLK32 always 32-bit
Until we make fcntl type-safe, this doesn't really fly, I'm afraid.
Florian
next prev parent reply other threads:[~2016-08-18 9:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 14:47 [glibc PATCH] fcntl: put F_OFD_* constants under #ifdef __USE_FILE_OFFSET64 Jeff Layton
2016-08-17 15:44 ` Joseph Myers
2016-08-17 17:49 ` Jeff Layton
2016-08-17 17:56 ` Joseph Myers
2016-08-17 18:23 ` Jeff Layton
2016-08-17 16:13 ` Mike Frysinger
2016-08-17 17:34 ` Florian Weimer
2016-08-17 17:39 ` Jeff Layton
2016-08-17 18:02 ` Florian Weimer
2016-08-17 18:21 ` Jeff Layton
2016-08-17 18:51 ` Florian Weimer
2016-08-17 19:20 ` Jeff Layton
2016-08-18 8:44 ` Florian Weimer
2016-08-18 8:58 ` Andreas Schwab
2016-08-17 20:52 ` Andreas Schwab
2016-08-18 8:45 ` Florian Weimer
2016-08-17 18:43 ` Mike Frysinger
2016-08-17 19:15 ` Jeff Layton
2016-08-17 19:59 ` Michael Kerrisk (man-pages)
2016-08-17 20:05 ` Jeff Layton
2016-08-17 20:37 ` Mike Frysinger
2016-08-17 20:57 ` Jeff Layton
2016-08-17 21:35 ` Mike Frysinger
2016-08-17 21:48 ` Jeff Layton
2016-08-18 9:00 ` Florian Weimer [this message]
2016-08-23 11:03 ` Cyril Hrubis
2016-08-23 11:36 ` Jeff Layton
2016-08-23 11:38 ` Cyril Hrubis
2016-08-23 21:10 ` Michael Kerrisk (man-pages)
2016-11-14 13:45 ` Cyril Hrubis
2016-11-22 18:41 ` Florian Weimer
2016-08-18 8:57 ` Florian Weimer
2016-08-17 20:03 ` Mike Frysinger
2016-08-17 21:30 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e1a972a-7966-139b-9d75-6d3a847a1be8@redhat.com \
--to=fweimer@redhat.com \
--cc=Yuriy.Kolerov@synopsys.com \
--cc=carlos@redhat.com \
--cc=jlayton@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.