From: Joseph Myers <joseph@codesourcery.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: <libc-alpha@sourceware.org>, <linux-fsdevel@vger.kernel.org>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Carlos O'Donell <carlos@redhat.com>,
Yuriy Kolerov <Yuriy.Kolerov@synopsys.com>
Subject: Re: [glibc PATCH] fcntl: put F_OFD_* constants under #ifdef __USE_FILE_OFFSET64
Date: Wed, 17 Aug 2016 15:44:08 +0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1608171540190.7156@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1471445251-2450-1-git-send-email-jlayton@redhat.com>
On Wed, 17 Aug 2016, Jeff Layton wrote:
> +# if __WORDSIZE != 32 || defined __USE_FILE_OFFSET64
Are you sure __WORDSIZE is always defined here? I don't see an include of
<bits/wordsize.h> in this header.
Are you sure __WORDSIZE != 32 is the right condition on all architectures
for the flock and flock64 structures being the same? Wordsize is not a
particularly well-defined concept all cases. More specific tests tend to
be preferred, e.g. __OFF_T_MATCHES_OFF64_T in bits/typesizes.h (so this
would indicate having a new macro __FLOCK_MATCHES_FLOCK64 and arranging
for it to be defined to 1 or 0 correctly in all cases - or at least a
careful analysis of all architectures using this file to show that some
other conditional is always correct).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2016-08-17 15:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 14:47 [glibc PATCH] fcntl: put F_OFD_* constants under #ifdef __USE_FILE_OFFSET64 Jeff Layton
2016-08-17 15:44 ` Joseph Myers [this message]
2016-08-17 17:49 ` Jeff Layton
2016-08-17 17:56 ` Joseph Myers
2016-08-17 18:23 ` Jeff Layton
2016-08-17 16:13 ` Mike Frysinger
2016-08-17 17:34 ` Florian Weimer
2016-08-17 17:39 ` Jeff Layton
2016-08-17 18:02 ` Florian Weimer
2016-08-17 18:21 ` Jeff Layton
2016-08-17 18:51 ` Florian Weimer
2016-08-17 19:20 ` Jeff Layton
2016-08-18 8:44 ` Florian Weimer
2016-08-18 8:58 ` Andreas Schwab
2016-08-17 20:52 ` Andreas Schwab
2016-08-18 8:45 ` Florian Weimer
2016-08-17 18:43 ` Mike Frysinger
2016-08-17 19:15 ` Jeff Layton
2016-08-17 19:59 ` Michael Kerrisk (man-pages)
2016-08-17 20:05 ` Jeff Layton
2016-08-17 20:37 ` Mike Frysinger
2016-08-17 20:57 ` Jeff Layton
2016-08-17 21:35 ` Mike Frysinger
2016-08-17 21:48 ` Jeff Layton
2016-08-18 9:00 ` Florian Weimer
2016-08-23 11:03 ` Cyril Hrubis
2016-08-23 11:36 ` Jeff Layton
2016-08-23 11:38 ` Cyril Hrubis
2016-08-23 21:10 ` Michael Kerrisk (man-pages)
2016-11-14 13:45 ` Cyril Hrubis
2016-11-22 18:41 ` Florian Weimer
2016-08-18 8:57 ` Florian Weimer
2016-08-17 20:03 ` Mike Frysinger
2016-08-17 21:30 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1608171540190.7156@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=Yuriy.Kolerov@synopsys.com \
--cc=carlos@redhat.com \
--cc=jlayton@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.