From: Jaroslav Kysela <perex@perex.cz> To: Dmitry Osipenko <digetx@gmail.com>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>, Ion Agorria <ion@agorria.com>, Svyatoslav Ryhel <clamor95@gmail.com>, Liam Girdwood <lgirdwood@gmail.com> Cc: alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] ASoC: tegra: Unify ASoC machine drivers Date: Thu, 20 May 2021 21:02:49 +0200 [thread overview] Message-ID: <8e5d4442-00a4-460b-d37a-8962960dd7ff@perex.cz> (raw) In-Reply-To: <20210520175054.28308-3-digetx@gmail.com> Dne 20. 05. 21 v 19:50 Dmitry Osipenko napsal(a): > Squash all machine drivers into a single-universal one. This reduces > code duplication, eases addition of a new drivers and upgrades older > code to a modern Linux kernel APIs. > > +static struct snd_soc_card snd_soc_tegra_wm9712 = { > + .dai_link = &tegra_wm9712_dai, > + .num_links = 1, > + .fully_routed = true, > +}; Please, could you also initialize snd_soc_card->components? It may be useful to pass the codec identification to the user space like: .components = "codec:wm9712" The passed information should be consistent. You may look into the Intel ASoC drivers for the examples (card->components initialization). There are also hints about the number of connected microphones ("cfg-mic:2" - configuration with 2 microphones) or the codec purpose ("hs:rt711" - headset codec is RT711) etc. Jaroslav Jaroslav Kysela <perex@perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
WARNING: multiple messages have this Message-ID (diff)
From: Jaroslav Kysela <perex@perex.cz> To: Dmitry Osipenko <digetx@gmail.com>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>, Ion Agorria <ion@agorria.com>, Svyatoslav Ryhel <clamor95@gmail.com>, Liam Girdwood <lgirdwood@gmail.com> Cc: linux-tegra@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] ASoC: tegra: Unify ASoC machine drivers Date: Thu, 20 May 2021 21:02:49 +0200 [thread overview] Message-ID: <8e5d4442-00a4-460b-d37a-8962960dd7ff@perex.cz> (raw) In-Reply-To: <20210520175054.28308-3-digetx@gmail.com> Dne 20. 05. 21 v 19:50 Dmitry Osipenko napsal(a): > Squash all machine drivers into a single-universal one. This reduces > code duplication, eases addition of a new drivers and upgrades older > code to a modern Linux kernel APIs. > > +static struct snd_soc_card snd_soc_tegra_wm9712 = { > + .dai_link = &tegra_wm9712_dai, > + .num_links = 1, > + .fully_routed = true, > +}; Please, could you also initialize snd_soc_card->components? It may be useful to pass the codec identification to the user space like: .components = "codec:wm9712" The passed information should be consistent. You may look into the Intel ASoC drivers for the examples (card->components initialization). There are also hints about the number of connected microphones ("cfg-mic:2" - configuration with 2 microphones) or the codec purpose ("hs:rt711" - headset codec is RT711) etc. Jaroslav Jaroslav Kysela <perex@perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
next prev parent reply other threads:[~2021-05-20 19:03 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-20 17:50 [PATCH v2 0/2] Unify NVIDIA Tegra ASoC machine drivers Dmitry Osipenko 2021-05-20 17:50 ` Dmitry Osipenko 2021-05-20 17:50 ` [PATCH v2 1/2] ASoC: tegra: Set driver_name=tegra for all " Dmitry Osipenko 2021-05-20 17:50 ` Dmitry Osipenko 2021-05-20 18:12 ` Dmitry Osipenko 2021-05-20 18:12 ` Dmitry Osipenko 2021-05-20 17:50 ` [PATCH v2 2/2] ASoC: tegra: Unify ASoC " Dmitry Osipenko 2021-05-20 17:50 ` Dmitry Osipenko 2021-05-20 19:02 ` Jaroslav Kysela [this message] 2021-05-20 19:02 ` Jaroslav Kysela 2021-05-20 19:08 ` Mark Brown 2021-05-20 19:08 ` Mark Brown 2021-05-21 8:54 ` Jaroslav Kysela 2021-05-21 8:54 ` Jaroslav Kysela 2021-05-21 18:43 ` Dmitry Osipenko 2021-05-21 18:43 ` Dmitry Osipenko 2021-05-21 13:12 ` Jon Hunter 2021-05-21 13:12 ` Jon Hunter 2021-05-21 19:05 ` Dmitry Osipenko 2021-05-21 19:05 ` Dmitry Osipenko 2021-05-24 12:22 ` Jon Hunter 2021-05-24 12:22 ` Jon Hunter 2021-05-24 13:40 ` Dmitry Osipenko 2021-05-24 13:40 ` Dmitry Osipenko 2021-05-24 18:50 ` Jon Hunter 2021-05-24 18:50 ` Jon Hunter 2021-05-24 21:02 ` Dmitry Osipenko 2021-05-24 21:02 ` Dmitry Osipenko 2021-05-25 6:51 ` Jon Hunter 2021-05-25 6:51 ` Jon Hunter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8e5d4442-00a4-460b-d37a-8962960dd7ff@perex.cz \ --to=perex@perex.cz \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=clamor95@gmail.com \ --cc=digetx@gmail.com \ --cc=ion@agorria.com \ --cc=jonathanh@nvidia.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=thierry.reding@gmail.com \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.