All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Hyunchul Lee <hyc.lee@gmail.com>
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
	adrian.hunter@intel.com, linux-kernel@vger.kernel.org,
	kernel-team@lge.com, linux-mtd@lists.infradead.org,
	linux-fsdevel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] ubifs: Add freeze support
Date: Mon, 29 May 2017 10:42:37 +0200	[thread overview]
Message-ID: <8e61baf3-a78e-d17f-ebe2-cd56d6c52259@nod.at> (raw)
In-Reply-To: <20170529022444.GA11814@sebu>

Hyunchul,

Am 29.05.2017 um 04:24 schrieb Hyunchul Lee:
>>> This is just broken.  First ubifs should still properly propagate
>>> the errors, and second freezing/unfreezing read only file systems is
>>> perfectly valid, 
>>
>> it is right.
> 
> if updating TNC is failed, ubifs might become inconsistant and be switched to 
> read-only mode. for example, when ubifs_jnl_update is called to create a file, 
> if inserting a znode for new inode is failed, TNC has only a znode for 
> new dentry. and this can be only recoverd by replay.
> 
> is it required to fix this?

UBIFS is designed to be power-cut tolerant.
So, UBIFS must not corrupt in any case.

Which failure are you facing?

I have the feeling that you try to paper over some other issue. :-)

Thanks,
//richard

  reply	other threads:[~2017-05-29  8:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25 23:30 [PATCH] ubifs: Add freeze support Hyunchul Lee
2017-05-26  9:52 ` Richard Weinberger
2017-05-27  8:18   ` Christoph Hellwig
2017-05-29  1:18   ` Hyunchul Lee
2017-05-29  4:40     ` Hyunchul Lee
2017-05-29  5:40       ` Amir Goldstein
2017-05-29  9:00         ` Richard Weinberger
2017-05-29 10:04           ` Amir Goldstein
2017-05-29 10:17             ` Richard Weinberger
2017-05-29 11:44               ` Amir Goldstein
2017-05-27  8:23 ` Christoph Hellwig
2017-05-29  0:43   ` Hyunchul Lee
2017-05-29  2:24     ` Hyunchul Lee
2017-05-29  8:42       ` Richard Weinberger [this message]
2017-05-30  2:37         ` Hyunchul Lee
2017-05-30  7:51           ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e61baf3-a78e-d17f-ebe2-cd56d6c52259@nod.at \
    --to=richard@nod.at \
    --cc=adrian.hunter@intel.com \
    --cc=dedekind1@gmail.com \
    --cc=hch@infradead.org \
    --cc=hyc.lee@gmail.com \
    --cc=kernel-team@lge.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.