All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Hyunchul Lee <hyc.lee@gmail.com>
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
	adrian.hunter@intel.com, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
	kernel-team@lge.com
Subject: Re: [PATCH] ubifs: Add freeze support
Date: Fri, 26 May 2017 11:52:42 +0200	[thread overview]
Message-ID: <2f3210d7-b0c3-f006-754e-ec4bae26454c@nod.at> (raw)
In-Reply-To: <1495755004-17036-1-git-send-email-hyc.lee@gmail.com>

Hyunchul,

Am 26.05.2017 um 01:30 schrieb Hyunchul Lee:
> From: Hyunchul Lee <cheol.lee@lge.com>
> 
> for un/freeze support, implement freeze_super and un/freeze_fs
> of super_operations.
> ubifs_freeze_super just calls freeze_super. because freeze_super always
> succeeds if file system is read-only,  UBIFS errors should be checked.
> if there are errors, UBIFS is switched to read-only mode.
> ubifs_freeze_fs runs commit if TNC/LPT isn't clean. though all writes
> are blocked and sync_fs is called before, if commit alreay was started
> before writes are blocked, TNC/LPT might have dirty COW nodes.

you explain how you implement that feature, but not why.
What is the use-case?
I always thought this interface is only being used by LVM.

Thanks,
//richard

  reply	other threads:[~2017-05-26  9:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25 23:30 [PATCH] ubifs: Add freeze support Hyunchul Lee
2017-05-26  9:52 ` Richard Weinberger [this message]
2017-05-27  8:18   ` Christoph Hellwig
2017-05-29  1:18   ` Hyunchul Lee
2017-05-29  4:40     ` Hyunchul Lee
2017-05-29  5:40       ` Amir Goldstein
2017-05-29  9:00         ` Richard Weinberger
2017-05-29 10:04           ` Amir Goldstein
2017-05-29 10:17             ` Richard Weinberger
2017-05-29 11:44               ` Amir Goldstein
2017-05-27  8:23 ` Christoph Hellwig
2017-05-29  0:43   ` Hyunchul Lee
2017-05-29  2:24     ` Hyunchul Lee
2017-05-29  8:42       ` Richard Weinberger
2017-05-30  2:37         ` Hyunchul Lee
2017-05-30  7:51           ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f3210d7-b0c3-f006-754e-ec4bae26454c@nod.at \
    --to=richard@nod.at \
    --cc=adrian.hunter@intel.com \
    --cc=dedekind1@gmail.com \
    --cc=hyc.lee@gmail.com \
    --cc=kernel-team@lge.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.