All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Hyunchul Lee <hyc.lee@gmail.com>,
	Artem Bityutskiy <dedekind1@gmail.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	kernel-team@lge.com, linux-mtd@lists.infradead.org,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] ubifs: Add freeze support
Date: Mon, 29 May 2017 12:17:00 +0200	[thread overview]
Message-ID: <b81dcdea-19d8-be73-057d-7059cf5fb3ab@nod.at> (raw)
In-Reply-To: <CAOQ4uxiYxdfTgrPo-ej7mS4ShAm2d4bU4v8y63Ej+c1kKXEMow@mail.gmail.com>

Amir,

Am 29.05.2017 um 12:04 schrieb Amir Goldstein:
>> Well, UBIFS is a bit different.
>> The UBIFS journal is not an add-on feature, you have to replay it in
>> any case. Otherwise you're facing corrupted data.
> 
> Yes, I suppose you are right.
> I guess there is no equivalent of mount -oro,{norecovery,noload} for
> ubifs.

Correct.

> I don't know the ubifs journal implementation details.
> Can ubifs_run_commit() when writers are frozen contribute to
> shorter journal replay time after boot with some workloads?

If the journal is empty then mounting will be faster, yes.
But I'm still interested in Hyunchul's use-case/problem.
Usually you run UBIFS in an embedded environment where you simple
never shutdown or reboot in a clean way. The power supply just
cut off.

On the other hand, if you want an empty journal for a faster mount,
just make sure that you umount upon shutdown.
Or make the size of the journal smaller at mkfs time.
Also see:

commit 27ad27993313312a4ad0047d0a944c425cd511a5
Author: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Date:   Thu Jan 29 16:34:30 2009 +0200

    UBIFS: remove fast unmounting

    This UBIFS feature has never worked properly, and it was a mistake
    to add it because we simply have no use-cases. So, lets still accept
    the fast_unmount mount option, but ignore it. This does not change
    much, because UBIFS commit in sync_fs anyway, and sync_fs is called
    while unmounting.

    Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

Thanks,
//richard

  reply	other threads:[~2017-05-29 10:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25 23:30 [PATCH] ubifs: Add freeze support Hyunchul Lee
2017-05-26  9:52 ` Richard Weinberger
2017-05-27  8:18   ` Christoph Hellwig
2017-05-29  1:18   ` Hyunchul Lee
2017-05-29  4:40     ` Hyunchul Lee
2017-05-29  5:40       ` Amir Goldstein
2017-05-29  9:00         ` Richard Weinberger
2017-05-29 10:04           ` Amir Goldstein
2017-05-29 10:17             ` Richard Weinberger [this message]
2017-05-29 11:44               ` Amir Goldstein
2017-05-27  8:23 ` Christoph Hellwig
2017-05-29  0:43   ` Hyunchul Lee
2017-05-29  2:24     ` Hyunchul Lee
2017-05-29  8:42       ` Richard Weinberger
2017-05-30  2:37         ` Hyunchul Lee
2017-05-30  7:51           ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b81dcdea-19d8-be73-057d-7059cf5fb3ab@nod.at \
    --to=richard@nod.at \
    --cc=adrian.hunter@intel.com \
    --cc=amir73il@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=hyc.lee@gmail.com \
    --cc=kernel-team@lge.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.