All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Wei Wang <wei.w.wang@intel.com>,
	virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	linux-mm@kvack.org, mhocko@kernel.org, akpm@linux-foundation.org,
	torvalds@linux-foundation.org, pbonzini@redhat.com,
	liliang.opensource@gmail.com, yang.zhang.wz@gmail.com,
	quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com,
	peterx@redhat.com
Subject: Re: [PATCH v34 0/4] Virtio-balloon: support free page reporting
Date: Fri, 29 Jun 2018 17:28:56 +0200	[thread overview]
Message-ID: <909d0983-bb54-25bb-03f5-7a28ded76500@redhat.com> (raw)
In-Reply-To: <20180629172216-mutt-send-email-mst@kernel.org>

>> And looking at all the discussions and problems that already happened
>> during the development of this series, I think we should rather look
>> into how clean free page hinting might solve the same problem.
> 
> I'm not sure I follow the logic. We found that neat tricks
> especially re-using the max order free page for reporting.

Let me rephrase: history of this series showed that this is some really
complicated stuff. I am asking if this complexity is actually necessary.

No question that we had a very valuable outcome so far (that especially
is also relevant for other projects like Nitesh's proposal - talking
about virtio requests and locking).

> 
>> If it can't be solved using free page hinting, fair enough.
> 
> I suspect Nitesh will need to find a way not to have mm code
> call out to random drivers or subsystems before that code
> is acceptable.
> 
> 


-- 

Thanks,

David / dhildenb

WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: yang.zhang.wz@gmail.com, virtio-dev@lists.oasis-open.org,
	riel@redhat.com, quan.xu0@gmail.com, kvm@vger.kernel.org,
	nilal@redhat.com, liliang.opensource@gmail.com,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
	pbonzini@redhat.com, akpm@linux-foundation.org,
	mhocko@kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH v34 0/4] Virtio-balloon: support free page reporting
Date: Fri, 29 Jun 2018 17:28:56 +0200	[thread overview]
Message-ID: <909d0983-bb54-25bb-03f5-7a28ded76500@redhat.com> (raw)
In-Reply-To: <20180629172216-mutt-send-email-mst@kernel.org>

>> And looking at all the discussions and problems that already happened
>> during the development of this series, I think we should rather look
>> into how clean free page hinting might solve the same problem.
> 
> I'm not sure I follow the logic. We found that neat tricks
> especially re-using the max order free page for reporting.

Let me rephrase: history of this series showed that this is some really
complicated stuff. I am asking if this complexity is actually necessary.

No question that we had a very valuable outcome so far (that especially
is also relevant for other projects like Nitesh's proposal - talking
about virtio requests and locking).

> 
>> If it can't be solved using free page hinting, fair enough.
> 
> I suspect Nitesh will need to find a way not to have mm code
> call out to random drivers or subsystems before that code
> is acceptable.
> 
> 


-- 

Thanks,

David / dhildenb

WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Wei Wang <wei.w.wang@intel.com>,
	virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	linux-mm@kvack.org, mhocko@kernel.org, akpm@linux-foundation.org,
	torvalds@linux-foundation.org, pbonzini@redhat.com,
	liliang.opensource@gmail.com, yang.zhang.wz@gmail.com,
	quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com,
	peterx@redhat.com
Subject: [virtio-dev] Re: [PATCH v34 0/4] Virtio-balloon: support free page reporting
Date: Fri, 29 Jun 2018 17:28:56 +0200	[thread overview]
Message-ID: <909d0983-bb54-25bb-03f5-7a28ded76500@redhat.com> (raw)
In-Reply-To: <20180629172216-mutt-send-email-mst@kernel.org>

>> And looking at all the discussions and problems that already happened
>> during the development of this series, I think we should rather look
>> into how clean free page hinting might solve the same problem.
> 
> I'm not sure I follow the logic. We found that neat tricks
> especially re-using the max order free page for reporting.

Let me rephrase: history of this series showed that this is some really
complicated stuff. I am asking if this complexity is actually necessary.

No question that we had a very valuable outcome so far (that especially
is also relevant for other projects like Nitesh's proposal - talking
about virtio requests and locking).

> 
>> If it can't be solved using free page hinting, fair enough.
> 
> I suspect Nitesh will need to find a way not to have mm code
> call out to random drivers or subsystems before that code
> is acceptable.
> 
> 


-- 

Thanks,

David / dhildenb

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2018-06-29 15:29 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-25 12:05 [PATCH v34 0/4] Virtio-balloon: support free page reporting Wei Wang
2018-06-25 12:05 ` [virtio-dev] " Wei Wang
2018-06-25 12:05 ` Wei Wang
2018-06-25 12:05 ` [PATCH v34 1/4] mm: support to get hints of free page blocks Wei Wang
2018-06-25 12:05   ` [virtio-dev] " Wei Wang
2018-06-25 12:05 ` Wei Wang
2018-06-25 12:05 ` [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Wei Wang
2018-06-25 12:05   ` [virtio-dev] " Wei Wang
2018-06-26  1:37   ` Michael S. Tsirkin
2018-06-26  1:37     ` [virtio-dev] " Michael S. Tsirkin
2018-06-26  1:37     ` Michael S. Tsirkin
2018-06-26  3:46     ` Wei Wang
2018-06-26  3:46       ` [virtio-dev] " Wei Wang
2018-06-26  3:46       ` Wei Wang
2018-06-26  3:56       ` Michael S. Tsirkin
2018-06-26  3:56         ` [virtio-dev] " Michael S. Tsirkin
2018-06-26  3:56         ` Michael S. Tsirkin
2018-06-26 12:27         ` Wei Wang
2018-06-26 12:27           ` [virtio-dev] " Wei Wang
2018-06-26 12:27           ` Wei Wang
2018-06-26 13:34           ` Michael S. Tsirkin
2018-06-26 13:34             ` [virtio-dev] " Michael S. Tsirkin
2018-06-27  1:24             ` Wei Wang
2018-06-27  1:24               ` [virtio-dev] " Wei Wang
2018-06-27  1:24               ` Wei Wang
2018-06-27  2:41               ` Michael S. Tsirkin
2018-06-27  2:41                 ` [virtio-dev] " Michael S. Tsirkin
2018-06-27  2:41                 ` Michael S. Tsirkin
2018-06-27  3:00                 ` Wei Wang
2018-06-27  3:00                   ` [virtio-dev] " Wei Wang
2018-06-27  3:00                   ` Wei Wang
2018-06-27  3:58                   ` Michael S. Tsirkin
2018-06-27  3:58                     ` [virtio-dev] " Michael S. Tsirkin
2018-06-27  5:27                     ` Wei Wang
2018-06-27  5:27                       ` [virtio-dev] " Wei Wang
2018-06-27  5:27                       ` Wei Wang
2018-06-27 16:53                       ` [virtio-dev] " Michael S. Tsirkin
2018-06-27 16:53                         ` Michael S. Tsirkin
2018-06-27 16:53                         ` Michael S. Tsirkin
2018-06-27  3:58                   ` Michael S. Tsirkin
2018-06-26 13:34           ` Michael S. Tsirkin
2018-06-25 12:05 ` Wei Wang
2018-06-25 12:05 ` [PATCH v34 3/4] mm/page_poison: expose page_poisoning_enabled to kernel modules Wei Wang
2018-06-25 12:05 ` Wei Wang
2018-06-25 12:05   ` [virtio-dev] " Wei Wang
2018-06-25 12:05 ` [PATCH v34 4/4] virtio-balloon: VIRTIO_BALLOON_F_PAGE_POISON Wei Wang
2018-06-25 12:05   ` [virtio-dev] " Wei Wang
2018-06-25 12:05 ` Wei Wang
2018-06-27 11:06 ` [PATCH v34 0/4] Virtio-balloon: support free page reporting David Hildenbrand
2018-06-27 11:06   ` [virtio-dev] " David Hildenbrand
2018-06-27 11:06   ` David Hildenbrand
2018-06-29  3:51   ` Wei Wang
2018-06-29  3:51     ` [virtio-dev] " Wei Wang
2018-06-29  3:51     ` Wei Wang
2018-06-29  7:46     ` David Hildenbrand
2018-06-29  7:46       ` [virtio-dev] " David Hildenbrand
2018-06-29  7:46       ` David Hildenbrand
2018-06-29 11:31       ` Wei Wang
2018-06-29 11:31         ` [virtio-dev] " Wei Wang
2018-06-29 11:31         ` Wei Wang
2018-06-29 11:53         ` David Hildenbrand
2018-06-29 11:53           ` [virtio-dev] " David Hildenbrand
2018-06-29 11:53           ` David Hildenbrand
2018-06-29 15:55           ` Wang, Wei W
2018-06-29 15:55             ` [virtio-dev] " Wang, Wei W
2018-06-29 15:55             ` Wang, Wei W
2018-06-29 15:55             ` Wang, Wei W
2018-06-29 16:03             ` David Hildenbrand
2018-06-29 16:03               ` [virtio-dev] " David Hildenbrand
2018-06-29 16:03               ` David Hildenbrand
2018-06-29 16:03               ` David Hildenbrand
2018-06-29 14:45   ` Michael S. Tsirkin
2018-06-29 14:45   ` Michael S. Tsirkin
2018-06-29 14:45     ` [virtio-dev] " Michael S. Tsirkin
2018-06-29 15:28     ` David Hildenbrand [this message]
2018-06-29 15:28       ` David Hildenbrand
2018-06-29 15:28       ` David Hildenbrand
2018-06-29 15:52     ` Wang, Wei W
2018-06-29 15:52       ` [virtio-dev] " Wang, Wei W
2018-06-29 15:52       ` Wang, Wei W
2018-06-29 15:52       ` Wang, Wei W
2018-06-29 16:32       ` Michael S. Tsirkin
2018-06-29 16:32         ` [virtio-dev] " Michael S. Tsirkin
2018-06-29 16:32         ` Michael S. Tsirkin
2018-06-29 16:32         ` Michael S. Tsirkin
2018-06-30  4:31 ` Wei Wang
2018-06-30  4:31   ` [virtio-dev] " Wei Wang
2018-06-30  4:31   ` Wei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=909d0983-bb54-25bb-03f5-7a28ded76500@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=kvm@vger.kernel.org \
    --cc=liliang.opensource@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mst@redhat.com \
    --cc=nilal@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=quan.xu0@gmail.com \
    --cc=riel@redhat.com \
    --cc=torvalds@linux-foundation.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wei.w.wang@intel.com \
    --cc=yang.zhang.wz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.