All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: "Wang, Wei W" <wei.w.wang@intel.com>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org" 
	<virtualization@lists.linux-foundation.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"mst@redhat.com" <mst@redhat.com>,
	"mhocko@kernel.org" <mhocko@kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"liliang.opensource@gmail.com" <liliang.opensource@gmail.com>,
	"yang.zhang.wz@gmail.com" <yang.zhang.wz@gmail.com>,
	"quan.xu0@gmail.com" <quan.xu0@gmail.com>,
	"nilal@redhat.com" <nilal@redhat.com>,
	"riel@redhat.com" <riel@redhat.com>,
	"peterx@redhat.com" <peterx@redhat.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [PATCH v34 0/4] Virtio-balloon: support free page reporting
Date: Fri, 29 Jun 2018 18:03:09 +0200	[thread overview]
Message-ID: <745eb950-eb52-e32a-b006-5612a026c2dc@redhat.com> (raw)
In-Reply-To: <286AC319A985734F985F78AFA26841F7396C254C@shsmsx102.ccr.corp.intel.com>


>> Why would your suggestion still be applicable?
>>
>> Your point for now is "I might not want to have page hinting enabled due to
>> the overhead, but still a live migration speedup". If that overhead actually
>> exists (we'll have to see) or there might be another reason to disable page
>> hinting, then we have to decide if that specific setup is worth it merging your
>> changes.
> 
> All the above "if we have", "assume we have" don't sound like a valid argument to me.

Argument? *confused* And that hinders you from answering the question
"Why would your suggestion still be applicable?" ? Well, okay.

So I will answer it by myself: Because somebody would want to disable
page hinting. Maybe there are some people out there.

>  
>> I am not (and don't want to be) in the position to make any decisions here :) I
>> just want to understand if two interfaces for free pages actually make sense.
> 
> I responded to Nitesh about the differences, you may want to check with him about this.
> I would suggest you to send out your patches to LKML to get a discussion with the mm folks.

Indeed, Nitesh is trying to solve the problems we found in the RFC, so
this can take some time.

> 
> Best,
> Wei
> 


-- 

Thanks,

David / dhildenb

WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: "Wang, Wei W" <wei.w.wang@intel.com>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"mst@redhat.com" <mst@redhat.com>,
	"mhocko@kernel.org" <mhocko@kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "yang.zhang.wz@gmail.com" <yang.zhang.wz@gmail.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	"riel@redhat.com" <riel@redhat.com>,
	"quan.xu0@gmail.com" <quan.xu0@gmail.com>,
	"liliang.opensource@gmail.com" <liliang.opensource@gmail.com>,
	Luiz Capitulino <lcapitulino@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"nilal@redhat.com" <nilal@redhat.com>,
	"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>
Subject: Re: [PATCH v34 0/4] Virtio-balloon: support free page reporting
Date: Fri, 29 Jun 2018 18:03:09 +0200	[thread overview]
Message-ID: <745eb950-eb52-e32a-b006-5612a026c2dc@redhat.com> (raw)
In-Reply-To: <286AC319A985734F985F78AFA26841F7396C254C@shsmsx102.ccr.corp.intel.com>


>> Why would your suggestion still be applicable?
>>
>> Your point for now is "I might not want to have page hinting enabled due to
>> the overhead, but still a live migration speedup". If that overhead actually
>> exists (we'll have to see) or there might be another reason to disable page
>> hinting, then we have to decide if that specific setup is worth it merging your
>> changes.
> 
> All the above "if we have", "assume we have" don't sound like a valid argument to me.

Argument? *confused* And that hinders you from answering the question
"Why would your suggestion still be applicable?" ? Well, okay.

So I will answer it by myself: Because somebody would want to disable
page hinting. Maybe there are some people out there.

>  
>> I am not (and don't want to be) in the position to make any decisions here :) I
>> just want to understand if two interfaces for free pages actually make sense.
> 
> I responded to Nitesh about the differences, you may want to check with him about this.
> I would suggest you to send out your patches to LKML to get a discussion with the mm folks.

Indeed, Nitesh is trying to solve the problems we found in the RFC, so
this can take some time.

> 
> Best,
> Wei
> 


-- 

Thanks,

David / dhildenb

WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: "Wang, Wei W" <wei.w.wang@intel.com>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"mst@redhat.com" <mst@redhat.com>,
	"mhocko@kernel.org" <mhocko@kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"liliang.opensource@gmail.com" <liliang.opensource@gmail.com>,
	"yang.zhang.wz@gmail.com" <yang.zhang.wz@gmail.com>,
	"quan.xu0@gmail.com" <quan.xu0@gmail.com>,
	"nilal@redhat.com" <nilal@redhat.com>,
	"riel@redhat.com" <riel@redhat.com>,
	"peterx@redhat.com" <peterx@redhat.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Luiz Capitulino <lcapitulino@redhat.com>
Subject: [virtio-dev] Re: [PATCH v34 0/4] Virtio-balloon: support free page reporting
Date: Fri, 29 Jun 2018 18:03:09 +0200	[thread overview]
Message-ID: <745eb950-eb52-e32a-b006-5612a026c2dc@redhat.com> (raw)
In-Reply-To: <286AC319A985734F985F78AFA26841F7396C254C@shsmsx102.ccr.corp.intel.com>


>> Why would your suggestion still be applicable?
>>
>> Your point for now is "I might not want to have page hinting enabled due to
>> the overhead, but still a live migration speedup". If that overhead actually
>> exists (we'll have to see) or there might be another reason to disable page
>> hinting, then we have to decide if that specific setup is worth it merging your
>> changes.
> 
> All the above "if we have", "assume we have" don't sound like a valid argument to me.

Argument? *confused* And that hinders you from answering the question
"Why would your suggestion still be applicable?" ? Well, okay.

So I will answer it by myself: Because somebody would want to disable
page hinting. Maybe there are some people out there.

>  
>> I am not (and don't want to be) in the position to make any decisions here :) I
>> just want to understand if two interfaces for free pages actually make sense.
> 
> I responded to Nitesh about the differences, you may want to check with him about this.
> I would suggest you to send out your patches to LKML to get a discussion with the mm folks.

Indeed, Nitesh is trying to solve the problems we found in the RFC, so
this can take some time.

> 
> Best,
> Wei
> 


-- 

Thanks,

David / dhildenb

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2018-06-29 16:03 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-25 12:05 [PATCH v34 0/4] Virtio-balloon: support free page reporting Wei Wang
2018-06-25 12:05 ` [virtio-dev] " Wei Wang
2018-06-25 12:05 ` Wei Wang
2018-06-25 12:05 ` [PATCH v34 1/4] mm: support to get hints of free page blocks Wei Wang
2018-06-25 12:05   ` [virtio-dev] " Wei Wang
2018-06-25 12:05 ` Wei Wang
2018-06-25 12:05 ` [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Wei Wang
2018-06-25 12:05   ` [virtio-dev] " Wei Wang
2018-06-26  1:37   ` Michael S. Tsirkin
2018-06-26  1:37     ` [virtio-dev] " Michael S. Tsirkin
2018-06-26  1:37     ` Michael S. Tsirkin
2018-06-26  3:46     ` Wei Wang
2018-06-26  3:46       ` [virtio-dev] " Wei Wang
2018-06-26  3:46       ` Wei Wang
2018-06-26  3:56       ` Michael S. Tsirkin
2018-06-26  3:56         ` [virtio-dev] " Michael S. Tsirkin
2018-06-26  3:56         ` Michael S. Tsirkin
2018-06-26 12:27         ` Wei Wang
2018-06-26 12:27           ` [virtio-dev] " Wei Wang
2018-06-26 12:27           ` Wei Wang
2018-06-26 13:34           ` Michael S. Tsirkin
2018-06-26 13:34             ` [virtio-dev] " Michael S. Tsirkin
2018-06-27  1:24             ` Wei Wang
2018-06-27  1:24               ` [virtio-dev] " Wei Wang
2018-06-27  1:24               ` Wei Wang
2018-06-27  2:41               ` Michael S. Tsirkin
2018-06-27  2:41                 ` [virtio-dev] " Michael S. Tsirkin
2018-06-27  2:41                 ` Michael S. Tsirkin
2018-06-27  3:00                 ` Wei Wang
2018-06-27  3:00                   ` [virtio-dev] " Wei Wang
2018-06-27  3:00                   ` Wei Wang
2018-06-27  3:58                   ` Michael S. Tsirkin
2018-06-27  3:58                     ` [virtio-dev] " Michael S. Tsirkin
2018-06-27  5:27                     ` Wei Wang
2018-06-27  5:27                       ` [virtio-dev] " Wei Wang
2018-06-27  5:27                       ` Wei Wang
2018-06-27 16:53                       ` [virtio-dev] " Michael S. Tsirkin
2018-06-27 16:53                         ` Michael S. Tsirkin
2018-06-27 16:53                         ` Michael S. Tsirkin
2018-06-27  3:58                   ` Michael S. Tsirkin
2018-06-26 13:34           ` Michael S. Tsirkin
2018-06-25 12:05 ` Wei Wang
2018-06-25 12:05 ` [PATCH v34 3/4] mm/page_poison: expose page_poisoning_enabled to kernel modules Wei Wang
2018-06-25 12:05 ` Wei Wang
2018-06-25 12:05   ` [virtio-dev] " Wei Wang
2018-06-25 12:05 ` [PATCH v34 4/4] virtio-balloon: VIRTIO_BALLOON_F_PAGE_POISON Wei Wang
2018-06-25 12:05   ` [virtio-dev] " Wei Wang
2018-06-25 12:05 ` Wei Wang
2018-06-27 11:06 ` [PATCH v34 0/4] Virtio-balloon: support free page reporting David Hildenbrand
2018-06-27 11:06   ` [virtio-dev] " David Hildenbrand
2018-06-27 11:06   ` David Hildenbrand
2018-06-29  3:51   ` Wei Wang
2018-06-29  3:51     ` [virtio-dev] " Wei Wang
2018-06-29  3:51     ` Wei Wang
2018-06-29  7:46     ` David Hildenbrand
2018-06-29  7:46       ` [virtio-dev] " David Hildenbrand
2018-06-29  7:46       ` David Hildenbrand
2018-06-29 11:31       ` Wei Wang
2018-06-29 11:31         ` [virtio-dev] " Wei Wang
2018-06-29 11:31         ` Wei Wang
2018-06-29 11:53         ` David Hildenbrand
2018-06-29 11:53           ` [virtio-dev] " David Hildenbrand
2018-06-29 11:53           ` David Hildenbrand
2018-06-29 15:55           ` Wang, Wei W
2018-06-29 15:55             ` [virtio-dev] " Wang, Wei W
2018-06-29 15:55             ` Wang, Wei W
2018-06-29 15:55             ` Wang, Wei W
2018-06-29 16:03             ` David Hildenbrand [this message]
2018-06-29 16:03               ` [virtio-dev] " David Hildenbrand
2018-06-29 16:03               ` David Hildenbrand
2018-06-29 16:03               ` David Hildenbrand
2018-06-29 14:45   ` Michael S. Tsirkin
2018-06-29 14:45   ` Michael S. Tsirkin
2018-06-29 14:45     ` [virtio-dev] " Michael S. Tsirkin
2018-06-29 15:28     ` David Hildenbrand
2018-06-29 15:28       ` [virtio-dev] " David Hildenbrand
2018-06-29 15:28       ` David Hildenbrand
2018-06-29 15:52     ` Wang, Wei W
2018-06-29 15:52       ` [virtio-dev] " Wang, Wei W
2018-06-29 15:52       ` Wang, Wei W
2018-06-29 15:52       ` Wang, Wei W
2018-06-29 16:32       ` Michael S. Tsirkin
2018-06-29 16:32         ` [virtio-dev] " Michael S. Tsirkin
2018-06-29 16:32         ` Michael S. Tsirkin
2018-06-29 16:32         ` Michael S. Tsirkin
2018-06-30  4:31 ` Wei Wang
2018-06-30  4:31   ` [virtio-dev] " Wei Wang
2018-06-30  4:31   ` Wei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=745eb950-eb52-e32a-b006-5612a026c2dc@redhat.com \
    --to=david@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=kvm@vger.kernel.org \
    --cc=lcapitulino@redhat.com \
    --cc=liliang.opensource@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mst@redhat.com \
    --cc=nilal@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=quan.xu0@gmail.com \
    --cc=riel@redhat.com \
    --cc=torvalds@linux-foundation.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wei.w.wang@intel.com \
    --cc=yang.zhang.wz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.