From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Alexandru Elisei <alexandru.elisei@arm.com>,
Andrew Jones <drjones@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Marc Zyngier <maz@kernel.org>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 09/17] arm: gic: Add test for flipping GICD_CTLR.DS
Date: Thu, 14 Nov 2019 14:50:22 +0000 [thread overview]
Message-ID: <90cdc695-f761-26bd-d2a7-f8655ce04463@arm.com> (raw)
In-Reply-To: <20191114141745.32d3b89c@donnerap.cambridge.arm.com>
On 11/14/19 2:17 PM, Andre Przywara wrote:
> On Thu, 14 Nov 2019 13:39:33 +0000
> Vladimir Murzin <vladimir.murzin@arm.com> wrote:
>
>> Hi,
>>
>> On 11/12/19 4:42 PM, Alexandru Elisei wrote:
>>> Are we not testing KVM? Why are we not treating a behaviour different than what
>>> KVM should emulate as a fail?
>>
>> Can kvm-unit-tests be run with qemu TCG?
>
> Yes, it does that actually by default if you cross compile. I also tested this explicitly on TCG: unlike KVM that actually passes all those tests.
> If you set the environment variable ACCEL to either tcg or kvm, you can select this at runtime:
> $ ACCEL=tcg arm/run arm/gic.flat -smp 3 -append irq
Great! Then, IMO, it is absolutely valid to test this functionality!
Thanks
Vladimir
>
> Cheers,
> Andre
>
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: kvm@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [kvm-unit-tests PATCH 09/17] arm: gic: Add test for flipping GICD_CTLR.DS
Date: Thu, 14 Nov 2019 14:50:22 +0000 [thread overview]
Message-ID: <90cdc695-f761-26bd-d2a7-f8655ce04463@arm.com> (raw)
In-Reply-To: <20191114141745.32d3b89c@donnerap.cambridge.arm.com>
On 11/14/19 2:17 PM, Andre Przywara wrote:
> On Thu, 14 Nov 2019 13:39:33 +0000
> Vladimir Murzin <vladimir.murzin@arm.com> wrote:
>
>> Hi,
>>
>> On 11/12/19 4:42 PM, Alexandru Elisei wrote:
>>> Are we not testing KVM? Why are we not treating a behaviour different than what
>>> KVM should emulate as a fail?
>>
>> Can kvm-unit-tests be run with qemu TCG?
>
> Yes, it does that actually by default if you cross compile. I also tested this explicitly on TCG: unlike KVM that actually passes all those tests.
> If you set the environment variable ACCEL to either tcg or kvm, you can select this at runtime:
> $ ACCEL=tcg arm/run arm/gic.flat -smp 3 -append irq
Great! Then, IMO, it is absolutely valid to test this functionality!
Thanks
Vladimir
>
> Cheers,
> Andre
>
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [kvm-unit-tests PATCH 09/17] arm: gic: Add test for flipping GICD_CTLR.DS
Date: Thu, 14 Nov 2019 14:50:22 +0000 [thread overview]
Message-ID: <90cdc695-f761-26bd-d2a7-f8655ce04463@arm.com> (raw)
In-Reply-To: <20191114141745.32d3b89c@donnerap.cambridge.arm.com>
On 11/14/19 2:17 PM, Andre Przywara wrote:
> On Thu, 14 Nov 2019 13:39:33 +0000
> Vladimir Murzin <vladimir.murzin@arm.com> wrote:
>
>> Hi,
>>
>> On 11/12/19 4:42 PM, Alexandru Elisei wrote:
>>> Are we not testing KVM? Why are we not treating a behaviour different than what
>>> KVM should emulate as a fail?
>>
>> Can kvm-unit-tests be run with qemu TCG?
>
> Yes, it does that actually by default if you cross compile. I also tested this explicitly on TCG: unlike KVM that actually passes all those tests.
> If you set the environment variable ACCEL to either tcg or kvm, you can select this at runtime:
> $ ACCEL=tcg arm/run arm/gic.flat -smp 3 -append irq
Great! Then, IMO, it is absolutely valid to test this functionality!
Thanks
Vladimir
>
> Cheers,
> Andre
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-14 14:50 UTC|newest]
Thread overview: 153+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 14:42 [kvm-unit-tests PATCH 00/17] arm: gic: Test SPIs and interrupt groups Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` [kvm-unit-tests PATCH 01/17] arm: gic: Enable GIC MMIO tests for GICv3 as well Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 17:28 ` Alexandru Elisei
2019-11-08 17:28 ` Alexandru Elisei
2019-11-08 17:28 ` Alexandru Elisei
2019-11-12 12:49 ` Auger Eric
2019-11-12 12:49 ` Auger Eric
2019-11-12 12:49 ` Auger Eric
2019-11-08 14:42 ` [kvm-unit-tests PATCH 02/17] arm: gic: Generalise function names Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-12 11:11 ` Alexandru Elisei
2019-11-12 11:11 ` Alexandru Elisei
2019-11-12 11:11 ` Alexandru Elisei
2019-11-12 12:49 ` Auger Eric
2019-11-12 12:49 ` Auger Eric
2019-11-12 12:49 ` Auger Eric
2019-11-08 14:42 ` [kvm-unit-tests PATCH 03/17] arm: gic: Provide per-IRQ helper functions Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-12 12:51 ` Alexandru Elisei
2019-11-12 12:51 ` Alexandru Elisei
2019-11-12 12:51 ` Alexandru Elisei
2019-11-12 15:53 ` Auger Eric
2019-11-12 15:53 ` Auger Eric
2019-11-12 15:53 ` Auger Eric
2019-11-12 16:53 ` Alexandru Elisei
2019-11-12 16:53 ` Alexandru Elisei
2019-11-12 16:53 ` Alexandru Elisei
2019-11-12 13:49 ` Auger Eric
2019-11-12 13:49 ` Auger Eric
2019-11-12 13:49 ` Auger Eric
2019-11-08 14:42 ` [kvm-unit-tests PATCH 04/17] arm: gic: Support no IRQs test case Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-12 13:26 ` Alexandru Elisei
2019-11-12 13:26 ` Alexandru Elisei
2019-11-12 13:26 ` Alexandru Elisei
2019-11-12 21:14 ` Auger Eric
2019-11-12 21:14 ` Auger Eric
2019-11-12 21:14 ` Auger Eric
2019-11-08 14:42 ` [kvm-unit-tests PATCH 05/17] arm: gic: Prepare IRQ handler for handling SPIs Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-12 13:36 ` Alexandru Elisei
2019-11-12 13:36 ` Alexandru Elisei
2019-11-12 13:36 ` Alexandru Elisei
2019-11-12 20:56 ` Auger Eric
2019-11-12 20:56 ` Auger Eric
2019-11-12 20:56 ` Auger Eric
2019-11-08 14:42 ` [kvm-unit-tests PATCH 06/17] arm: gic: Add simple shared IRQ test Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-12 13:54 ` Alexandru Elisei
2019-11-12 13:54 ` Alexandru Elisei
2019-11-12 13:54 ` Alexandru Elisei
2019-11-08 14:42 ` [kvm-unit-tests PATCH 07/17] arm: gic: Extend check_acked() to allow silent call Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-12 15:23 ` Alexandru Elisei
2019-11-12 15:23 ` Alexandru Elisei
2019-11-12 15:23 ` Alexandru Elisei
2019-11-14 12:32 ` Andrew Jones
2019-11-14 12:32 ` Andrew Jones
2019-11-14 12:32 ` Andrew Jones
2019-11-15 11:32 ` Alexandru Elisei
2019-11-15 11:32 ` Alexandru Elisei
2019-11-15 11:32 ` Alexandru Elisei
2019-11-08 14:42 ` [kvm-unit-tests PATCH 08/17] arm: gic: Add simple SPI MP test Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-12 15:41 ` Alexandru Elisei
2019-11-12 15:41 ` Alexandru Elisei
2019-11-12 15:41 ` Alexandru Elisei
2019-11-08 14:42 ` [kvm-unit-tests PATCH 09/17] arm: gic: Add test for flipping GICD_CTLR.DS Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-12 16:42 ` Alexandru Elisei
2019-11-12 16:42 ` Alexandru Elisei
2019-11-12 16:42 ` Alexandru Elisei
2019-11-14 13:39 ` Vladimir Murzin
2019-11-14 13:39 ` Vladimir Murzin
2019-11-14 13:39 ` Vladimir Murzin
2019-11-14 14:17 ` Andre Przywara
2019-11-14 14:17 ` Andre Przywara
2019-11-14 14:17 ` Andre Przywara
2019-11-14 14:50 ` Vladimir Murzin [this message]
2019-11-14 14:50 ` Vladimir Murzin
2019-11-14 14:50 ` Vladimir Murzin
2019-11-14 15:21 ` Alexandru Elisei
2019-11-14 15:21 ` Alexandru Elisei
2019-11-14 15:21 ` Alexandru Elisei
2019-11-14 15:27 ` Peter Maydell
2019-11-14 15:27 ` Peter Maydell
2019-11-14 15:27 ` Peter Maydell
2019-11-14 15:47 ` Alexandru Elisei
2019-11-14 15:47 ` Alexandru Elisei
2019-11-14 15:47 ` Alexandru Elisei
2019-11-14 15:56 ` Peter Maydell
2019-11-14 15:56 ` Peter Maydell
2019-11-14 15:56 ` Peter Maydell
2019-11-08 14:42 ` [kvm-unit-tests PATCH 10/17] arm: gic: Check for writable IGROUPR registers Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-12 16:51 ` Alexandru Elisei
2019-11-12 16:51 ` Alexandru Elisei
2019-11-12 16:51 ` Alexandru Elisei
2019-11-08 14:42 ` [kvm-unit-tests PATCH 11/17] arm: gic: Check for validity of both group enable bits Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-12 16:58 ` Alexandru Elisei
2019-11-12 16:58 ` Alexandru Elisei
2019-11-12 16:58 ` Alexandru Elisei
2019-11-08 14:42 ` [kvm-unit-tests PATCH 12/17] arm: gic: Change gic_read_iar() to take group parameter Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-12 17:19 ` Alexandru Elisei
2019-11-12 17:19 ` Alexandru Elisei
2019-11-12 17:19 ` Alexandru Elisei
2019-11-14 12:50 ` Andrew Jones
2019-11-14 12:50 ` Andrew Jones
2019-11-14 12:50 ` Andrew Jones
2019-11-08 14:42 ` [kvm-unit-tests PATCH 13/17] arm: gic: Change write_eoir() " Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` [kvm-unit-tests PATCH 14/17] arm: gic: Prepare for receiving GIC group 0 interrupts via FIQs Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-12 17:30 ` Alexandru Elisei
2019-11-12 17:30 ` Alexandru Elisei
2019-11-12 17:30 ` Alexandru Elisei
2019-11-08 14:42 ` [kvm-unit-tests PATCH 15/17] arm: gic: Provide FIQ handler Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-13 10:14 ` Alexandru Elisei
2019-11-13 10:14 ` Alexandru Elisei
2019-11-13 10:14 ` Alexandru Elisei
2019-11-08 14:42 ` [kvm-unit-tests PATCH 16/17] arm: gic: Prepare interrupt statistics for both groups Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-13 10:44 ` Alexandru Elisei
2019-11-13 10:44 ` Alexandru Elisei
2019-11-13 10:44 ` Alexandru Elisei
2019-11-08 14:42 ` [kvm-unit-tests PATCH 17/17] arm: gic: Test Group0 SPIs Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-08 14:42 ` Andre Przywara
2019-11-13 11:26 ` Alexandru Elisei
2019-11-13 11:26 ` Alexandru Elisei
2019-11-13 11:26 ` Alexandru Elisei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90cdc695-f761-26bd-d2a7-f8655ce04463@arm.com \
--to=vladimir.murzin@arm.com \
--cc=alexandru.elisei@arm.com \
--cc=andre.przywara@arm.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.