[PATCH] OSSTEST: Install libtirpc-dev for libvirt builds

[PATCH] OSSTEST: Install libtirpc-dev for libvirt builds

[Jim Fehlig]

The check for XDR support was changed in libvirt commit d7147b3797
to use libtirpc pkg-config instead of complicated AC_CHECK_LIB,
AC_COMPILE_IFELSE, et. al. logic. The libvirt OSSTEST has been
failing since this change hit libvirt.git master. Fix it by adding
libtirpc-dev to the list of 'extra_packages' installed for libvirt
builds.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---

I *think* this change will work for older libvirt branches too.
The old, hand-coded m4 logic should work with libtirpc-dev
installed.

 Osstest/Toolstack/libvirt.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Osstest/Toolstack/libvirt.pm b/Osstest/Toolstack/libvirt.pm
index e817f5b4..11e4d730 100644
--- a/Osstest/Toolstack/libvirt.pm
+++ b/Osstest/Toolstack/libvirt.pm
@@ -26,7 +26,7 @@ use XML::LibXML;
 
 sub new {
     my ($class, $ho, $methname,$asset) = @_;
-    my @extra_packages = qw(libavahi-client3);
+    my @extra_packages = qw(libavahi-client3 libtirpc-dev);
     my $nl_lib = "libnl-3-200";
     my $libgnutls = "libgnutls30";
 
-- 
2.26.2

Re: [PATCH] OSSTEST: Install libtirpc-dev for libvirt builds

[Ian Jackson]

Jim Fehlig writes ("[PATCH] OSSTEST: Install libtirpc-dev for libvirt builds"):
> The check for XDR support was changed in libvirt commit d7147b3797
> to use libtirpc pkg-config instead of complicated AC_CHECK_LIB,
> AC_COMPILE_IFELSE, et. al. logic. The libvirt OSSTEST has been
> failing since this change hit libvirt.git master. Fix it by adding
> libtirpc-dev to the list of 'extra_packages' installed for libvirt
> builds.
> 
> Signed-off-by: Jim Fehlig <jfehlig@suse.com>

Reviewed-by: Ian Jackson <ian.jackson@eu.citrix.com>

Thanks!  I will push this to osstest pretest shortly.

Ian.

Re: [PATCH] OSSTEST: Install libtirpc-dev for libvirt builds

[Jim Fehlig]

On 8/10/20 4:13 AM, Ian Jackson wrote:
> Jim Fehlig writes ("[PATCH] OSSTEST: Install libtirpc-dev for libvirt builds"):
>> The check for XDR support was changed in libvirt commit d7147b3797
>> to use libtirpc pkg-config instead of complicated AC_CHECK_LIB,
>> AC_COMPILE_IFELSE, et. al. logic. The libvirt OSSTEST has been
>> failing since this change hit libvirt.git master. Fix it by adding
>> libtirpc-dev to the list of 'extra_packages' installed for libvirt
>> builds.
>>
>> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
> 
> Reviewed-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
> Thanks!  I will push this to osstest pretest shortly.

Thanks Ian! Perhaps you've noticed libvirt has now moved to the meson build 
system. My weak perl skills have discouraged me from investigating ways to 
accommodate that.

Regards,
Jim