All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ruud Derwig <Ruud.Derwig@synopsys.com>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
	Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-snps-arc@lists.infradead.org" 
	<linux-snps-arc@lists.infradead.org>
Subject: RE: [PATCH 1/3] arc: vdk: Disable halt on reset
Date: Thu, 2 Feb 2017 14:03:40 +0000	[thread overview]
Message-ID: <921F8835C03C574A887849158AC092F957726AA3@de02wembxa.internal.synopsys.com> (raw)
In-Reply-To: <e9df73e0-14e6-cd84-0539-1e79e05ebd08@synopsys.com>

Hi,

VDK config includes GRFC, not sure if it's working/used though.
The nSIM STAR is about that GRFC frequency is fixed in nSIM, but configurable for HW/customers.
But if the frequency is configured correctly (same as cpu frequency), don't think there's an issue.

Ruud.
-----Original Message-----
From: Vineet Gupta 
Sent: Wednesday, February 01, 2017 8:56 PM
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: Ruud Derwig <rderwig@synopsys.com>; linux-kernel@vger.kernel.org; linux-snps-arc@lists.infradead.org
Subject: Re: [PATCH 1/3] arc: vdk: Disable halt on reset

On 02/01/2017 09:52 AM, Alexey Brodkin wrote:
>> The whole point of adding this to defconfig is to override the default from Kconfig ?
> Not anymore :)
> 
> Since commit c4c9a040ecb7 ("clocksource: import ARC timer driver"), 
> see 
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/
> ?id=c4c9a040ecb7297e011e579f5a9cc280e42d725f
> we have this:
> ---------------------->8----------------------
> config ISA_ARCV2
> 	bool "ARC ISA v2"
> 	select ARC_TIMERS_64BIT
> ---------------------->8----------------------
> 
> which really means if one selects ISA_ARCV2 then ARC_TIMERS_64BIT gets 
> selected automatically and there's no way to override it from either menuconfig or defconfig.

Bummer - this means VDK based off 4.9+ kernel might be affected with nsim GFRC issue !

> Probably behavior that you meant was to keep a separate "config ARC_TIMERS_64BIT"
> and have it "default y if ISA_ARCV2".

No, the whole point of moving it out of arch/arc was to increase test coverage etc so it was not tied to ISA_ARCV2 on purpose so that it would atleast build.

Lets see what Rudd has to say abt this. But GFRC can't be used this would need fixing after all by introducing an additional ARC_PLAT_CANT_USE_TIMERS_64BIT which is def_bool set to n, but selected y in VDK Kconfig.

-Vineet

WARNING: multiple messages have this Message-ID (diff)
From: Ruud.Derwig@synopsys.com (Ruud Derwig)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 1/3] arc: vdk: Disable halt on reset
Date: Thu, 2 Feb 2017 14:03:40 +0000	[thread overview]
Message-ID: <921F8835C03C574A887849158AC092F957726AA3@de02wembxa.internal.synopsys.com> (raw)
In-Reply-To: <e9df73e0-14e6-cd84-0539-1e79e05ebd08@synopsys.com>

Hi,

VDK config includes GRFC, not sure if it's working/used though.
The nSIM STAR is about that GRFC frequency is fixed in nSIM, but configurable for HW/customers.
But if the frequency is configured correctly (same as cpu frequency), don't think there's an issue.

Ruud.
-----Original Message-----
From: Vineet Gupta 
Sent: Wednesday, February 01, 2017 8:56 PM
To: Alexey Brodkin <Alexey.Brodkin at synopsys.com>
Cc: Ruud Derwig <rderwig at synopsys.com>; linux-kernel at vger.kernel.org; linux-snps-arc at lists.infradead.org
Subject: Re: [PATCH 1/3] arc: vdk: Disable halt on reset

On 02/01/2017 09:52 AM, Alexey Brodkin wrote:
>> The whole point of adding this to defconfig is to override the default from Kconfig ?
> Not anymore :)
> 
> Since commit c4c9a040ecb7 ("clocksource: import ARC timer driver"), 
> see 
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/
> ?id=c4c9a040ecb7297e011e579f5a9cc280e42d725f
> we have this:
> ---------------------->8----------------------
> config ISA_ARCV2
> 	bool "ARC ISA v2"
> 	select ARC_TIMERS_64BIT
> ---------------------->8----------------------
> 
> which really means if one selects ISA_ARCV2 then ARC_TIMERS_64BIT gets 
> selected automatically and there's no way to override it from either menuconfig or defconfig.

Bummer - this means VDK based off 4.9+ kernel might be affected with nsim GFRC issue !

> Probably behavior that you meant was to keep a separate "config ARC_TIMERS_64BIT"
> and have it "default y if ISA_ARCV2".

No, the whole point of moving it out of arch/arc was to increase test coverage etc so it was not tied to ISA_ARCV2 on purpose so that it would atleast build.

Lets see what Rudd has to say abt this. But GFRC can't be used this would need fixing after all by introducing an additional ARC_PLAT_CANT_USE_TIMERS_64BIT which is def_bool set to n, but selected y in VDK Kconfig.

-Vineet

  parent reply	other threads:[~2017-02-02 14:03 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-01 16:42 [PATCH 0/3] Updates for ARC VDK platform Alexey Brodkin
2017-02-01 16:42 ` Alexey Brodkin
2017-02-01 16:42 ` [PATCH 1/3] arc: vdk: Disable halt on reset Alexey Brodkin
2017-02-01 16:42   ` Alexey Brodkin
2017-02-01 16:52   ` Vineet Gupta
2017-02-01 16:52     ` Vineet Gupta
2017-02-01 17:14     ` Alexey Brodkin
2017-02-01 17:14       ` Alexey Brodkin
2017-02-01 17:37       ` Vineet Gupta
2017-02-01 17:37         ` Vineet Gupta
2017-02-01 17:52         ` Alexey Brodkin
2017-02-01 17:52           ` Alexey Brodkin
2017-02-01 19:56           ` Vineet Gupta
2017-02-01 19:56             ` Vineet Gupta
2017-02-01 20:03             ` Alexey Brodkin
2017-02-01 20:03               ` Alexey Brodkin
2017-02-02 14:03             ` Ruud Derwig [this message]
2017-02-02 14:03               ` Ruud Derwig
2017-02-01 16:42 ` [PATCH 2/3] arc: vdk: Add support of MMC controller Alexey Brodkin
2017-02-01 16:42   ` Alexey Brodkin
2017-02-01 16:42 ` [PATCH 3/3] arc: vdk: Add support of UIO Alexey Brodkin
2017-02-01 16:42   ` Alexey Brodkin
2017-02-01 17:13 ` [PATCH 0/3] Updates for ARC VDK platform Vineet Gupta
2017-02-01 17:13   ` Vineet Gupta
2017-02-01 17:15   ` Alexey Brodkin
2017-02-01 17:15     ` Alexey Brodkin
2017-02-01 17:22     ` Vineet Gupta
2017-02-01 17:22       ` Vineet Gupta
2017-02-01 17:35       ` Alexey Brodkin
2017-02-01 17:35         ` Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=921F8835C03C574A887849158AC092F957726AA3@de02wembxa.internal.synopsys.com \
    --to=ruud.derwig@synopsys.com \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.