All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ruud Derwig <Ruud.Derwig@synopsys.com>,
	"linux-snps-arc@lists.infradead.org" 
	<linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH 1/3] arc: vdk: Disable halt on reset
Date: Wed, 1 Feb 2017 17:14:08 +0000	[thread overview]
Message-ID: <1485969247.5515.27.camel@synopsys.com> (raw)
In-Reply-To: <8b857bc4-71f0-9b3b-0cd5-19b49edb2910@synopsys.com>

Hi Vineet,

On Wed, 2017-02-01 at 08:52 -0800, Vineet Gupta wrote:
> On 02/01/2017 08:42 AM, Alexey Brodkin wrote:
> > 
> > In recent VDKs ARC cores are configured as "run on reset"
> > which made existing kernel configuration outdated to effect that
> > slave cores never start execution of the code keeping only master
> > online.
> > 
> > With that fix we're again in sync with VDK platform.
> > 
> > And while at it we regenerate defconfig via savedefconfig so default
> > options are now excluded.
> > 
> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > ---
> >  arch/arc/configs/vdk_hs38_smp_defconfig | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/arch/arc/configs/vdk_hs38_smp_defconfig b/arch/arc/configs/vdk_hs38_smp_defconfig
> > index 573028f19de7..f6361de41eec 100644
> > --- a/arch/arc/configs/vdk_hs38_smp_defconfig
> > +++ b/arch/arc/configs/vdk_hs38_smp_defconfig
> > @@ -15,7 +15,7 @@ CONFIG_ARC_PLAT_AXS10X=y
> >  CONFIG_AXS103=y
> >  CONFIG_ISA_ARCV2=y
> >  CONFIG_SMP=y
> > -# CONFIG_ARC_TIMERS_64BIT is not set
> 
> Are you sure abut this part. Ater the timers driver rework, this would enable GFRC
> for SMP builds and AFAIKR there were some issues with time with GFRC + nSIM etc..

Not anymore :)

Probably I missed something in discussions.
As a matter of fact I did run-test resulting vmlinux and it worked very nice.
More over ARC_TIMERS_64BIT is selected automatically by ISA_ARCV2, see
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arc/Kconfig#n119

That said even if "# CONFIG_ARC_TIMERS_64BIT is not set" is left in place the option will be
effectively enabled, no?

-Alexey

WARNING: multiple messages have this Message-ID (diff)
From: Alexey.Brodkin@synopsys.com (Alexey Brodkin)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 1/3] arc: vdk: Disable halt on reset
Date: Wed, 1 Feb 2017 17:14:08 +0000	[thread overview]
Message-ID: <1485969247.5515.27.camel@synopsys.com> (raw)
In-Reply-To: <8b857bc4-71f0-9b3b-0cd5-19b49edb2910@synopsys.com>

Hi Vineet,

On Wed, 2017-02-01@08:52 -0800, Vineet Gupta wrote:
> On 02/01/2017 08:42 AM, Alexey Brodkin wrote:
> > 
> > In recent VDKs ARC cores are configured as "run on reset"
> > which made existing kernel configuration outdated to effect that
> > slave cores never start execution of the code keeping only master
> > online.
> > 
> > With that fix we're again in sync with VDK platform.
> > 
> > And while at it we regenerate defconfig via savedefconfig so default
> > options are now excluded.
> > 
> > Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> > ---
> > ?arch/arc/configs/vdk_hs38_smp_defconfig | 4 +---
> > ?1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/arch/arc/configs/vdk_hs38_smp_defconfig b/arch/arc/configs/vdk_hs38_smp_defconfig
> > index 573028f19de7..f6361de41eec 100644
> > --- a/arch/arc/configs/vdk_hs38_smp_defconfig
> > +++ b/arch/arc/configs/vdk_hs38_smp_defconfig
> > @@ -15,7 +15,7 @@ CONFIG_ARC_PLAT_AXS10X=y
> > ?CONFIG_AXS103=y
> > ?CONFIG_ISA_ARCV2=y
> > ?CONFIG_SMP=y
> > -# CONFIG_ARC_TIMERS_64BIT is not set
> 
> Are you sure abut this part. Ater the timers driver rework, this would enable GFRC
> for SMP builds and AFAIKR there were some issues with time with GFRC + nSIM etc..

Not anymore :)

Probably I missed something in discussions.
As a matter of fact I did run-test resulting vmlinux and it worked very nice.
More over?ARC_TIMERS_64BIT is selected automatically by?ISA_ARCV2, see
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arc/Kconfig#n119

That said even if "# CONFIG_ARC_TIMERS_64BIT is not set" is left in place the option will be
effectively enabled, no?

-Alexey

  reply	other threads:[~2017-02-01 17:14 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-01 16:42 [PATCH 0/3] Updates for ARC VDK platform Alexey Brodkin
2017-02-01 16:42 ` Alexey Brodkin
2017-02-01 16:42 ` [PATCH 1/3] arc: vdk: Disable halt on reset Alexey Brodkin
2017-02-01 16:42   ` Alexey Brodkin
2017-02-01 16:52   ` Vineet Gupta
2017-02-01 16:52     ` Vineet Gupta
2017-02-01 17:14     ` Alexey Brodkin [this message]
2017-02-01 17:14       ` Alexey Brodkin
2017-02-01 17:37       ` Vineet Gupta
2017-02-01 17:37         ` Vineet Gupta
2017-02-01 17:52         ` Alexey Brodkin
2017-02-01 17:52           ` Alexey Brodkin
2017-02-01 19:56           ` Vineet Gupta
2017-02-01 19:56             ` Vineet Gupta
2017-02-01 20:03             ` Alexey Brodkin
2017-02-01 20:03               ` Alexey Brodkin
2017-02-02 14:03             ` Ruud Derwig
2017-02-02 14:03               ` Ruud Derwig
2017-02-01 16:42 ` [PATCH 2/3] arc: vdk: Add support of MMC controller Alexey Brodkin
2017-02-01 16:42   ` Alexey Brodkin
2017-02-01 16:42 ` [PATCH 3/3] arc: vdk: Add support of UIO Alexey Brodkin
2017-02-01 16:42   ` Alexey Brodkin
2017-02-01 17:13 ` [PATCH 0/3] Updates for ARC VDK platform Vineet Gupta
2017-02-01 17:13   ` Vineet Gupta
2017-02-01 17:15   ` Alexey Brodkin
2017-02-01 17:15     ` Alexey Brodkin
2017-02-01 17:22     ` Vineet Gupta
2017-02-01 17:22       ` Vineet Gupta
2017-02-01 17:35       ` Alexey Brodkin
2017-02-01 17:35         ` Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485969247.5515.27.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=Ruud.Derwig@synopsys.com \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.