All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tyler Baicar <tbaicar@codeaurora.org>
To: Dongjiu Geng <gengdongjiu@huawei.com>,
	bp@suse.de, james.morse@arm.com, will.deacon@arm.com,
	rjw@rjwysocki.net, lenb@kernel.org, robert.moore@intel.com,
	lv.zheng@intel.com, mark.rutland@arm.com,
	kristina.martsenko@arm.com, mingo@kernel.org,
	punit.agrawal@arm.com, stephen.boyd@linaro.org,
	kamensky@cisco.com, prarit@redhat.com, shiju.jose@huawei.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	devel@acpica.or
Subject: Re: [PATCH v5 1/2] acpi: apei: remove the unused dead-code for SEA/NMI notification type
Date: Tue, 17 Oct 2017 10:06:39 -0400	[thread overview]
Message-ID: <9287b646-7673-bf5d-bcde-933c8c98a0dd@codeaurora.org> (raw)
In-Reply-To: <1508227341-15651-1-git-send-email-gengdongjiu@huawei.com>

On 10/17/2017 4:02 AM, Dongjiu Geng wrote:
> For the SEA notification, the two functions ghes_sea_add() and
> ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA
> is defined. If not, it will return errors in the ghes_probe()
> and not continue. If the probe is failed, the ghes_sea_remove()
> also has no chance to be called. Hence, remove the unnecessary
> handling when CONFIG_ACPI_APEI_SEA is not defined.
>
> For the NMI notification, it has the same issue as SEA notification,
> so also remove the unused dead-code for it.
>
> Cc: Tyler Baicar <tbaicar@codeaurora.org>
> Cc: James Morse <james.morse@arm.com>
> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
Tested-by: Tyler Baicar <tbaicar@codeaurora.org>

I've verified v5 of this series testing the SEA path.

Thanks,
Tyler

WARNING: multiple messages have this Message-ID (diff)
From: tbaicar@codeaurora.org (Tyler Baicar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/2] acpi: apei: remove the unused dead-code for SEA/NMI notification type
Date: Tue, 17 Oct 2017 10:06:39 -0400	[thread overview]
Message-ID: <9287b646-7673-bf5d-bcde-933c8c98a0dd@codeaurora.org> (raw)
In-Reply-To: <1508227341-15651-1-git-send-email-gengdongjiu@huawei.com>

On 10/17/2017 4:02 AM, Dongjiu Geng wrote:
> For the SEA notification, the two functions ghes_sea_add() and
> ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA
> is defined. If not, it will return errors in the ghes_probe()
> and not continue. If the probe is failed, the ghes_sea_remove()
> also has no chance to be called. Hence, remove the unnecessary
> handling when CONFIG_ACPI_APEI_SEA is not defined.
>
> For the NMI notification, it has the same issue as SEA notification,
> so also remove the unused dead-code for it.
>
> Cc: Tyler Baicar <tbaicar@codeaurora.org>
> Cc: James Morse <james.morse@arm.com>
> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
Tested-by: Tyler Baicar <tbaicar@codeaurora.org>

I've verified v5 of this series testing the SEA path.

Thanks,
Tyler

  parent reply	other threads:[~2017-10-17 14:06 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-17  8:02 [PATCH v5 1/2] acpi: apei: remove the unused dead-code for SEA/NMI notification type Dongjiu Geng
2017-10-17  8:02 ` Dongjiu Geng
2017-10-17  8:02 ` Dongjiu Geng
2017-10-17  8:02 ` [PATCH v5 2/2] acpi: apei: Add SEI notification type support for ARMv8 Dongjiu Geng
2017-10-17  8:02   ` Dongjiu Geng
2017-10-17  8:02   ` Dongjiu Geng
2017-10-17 17:06   ` Borislav Petkov
2017-10-17 17:06     ` Borislav Petkov
2017-10-18  5:00     ` gengdongjiu
2017-10-18  5:00       ` [Devel] " gengdongjiu
2017-10-18  5:00       ` gengdongjiu
2017-10-18  5:00       ` gengdongjiu
2017-10-18  9:06       ` Borislav Petkov
2017-10-18  9:06         ` Borislav Petkov
2017-10-18  9:17         ` gengdongjiu
2017-10-18  9:17           ` [Devel] " gengdongjiu
2017-10-18  9:17           ` gengdongjiu
2017-10-18  9:17           ` gengdongjiu
2017-10-18  9:25           ` Borislav Petkov
2017-10-18  9:25             ` Borislav Petkov
2017-10-18  9:44             ` James Morse
2017-10-18  9:44               ` [Devel] " James Morse
2017-10-18  9:44               ` James Morse
2017-10-18 10:04               ` Borislav Petkov
2017-10-18 10:04                 ` Borislav Petkov
2017-10-18 10:25                 ` gengdongjiu
2017-10-18 10:25                   ` [Devel] " gengdongjiu
2017-10-18 10:25                   ` gengdongjiu
2017-10-18 10:25                   ` gengdongjiu
2017-10-18 10:21               ` gengdongjiu
2017-10-18 10:21                 ` [Devel] " gengdongjiu
2017-10-18 10:21                 ` gengdongjiu
2017-10-18 10:21                 ` gengdongjiu
2017-10-18 10:26   ` James Morse
2017-10-18 10:26     ` [Devel] " James Morse
2017-10-18 10:26     ` James Morse
2017-10-18 11:39     ` gengdongjiu
2017-10-18 11:39       ` [Devel] " gengdongjiu
2017-10-18 11:39       ` gengdongjiu
2017-10-18 11:39       ` gengdongjiu
2017-10-17 14:06 ` Tyler Baicar [this message]
2017-10-17 14:06   ` [PATCH v5 1/2] acpi: apei: remove the unused dead-code for SEA/NMI notification type Tyler Baicar
2017-10-17 16:43 ` Borislav Petkov
2017-10-17 16:43   ` Borislav Petkov
2017-10-18  3:04   ` gengdongjiu
2017-10-18  3:04     ` [Devel] " gengdongjiu
2017-10-18  3:04     ` gengdongjiu
2017-10-18  3:04     ` gengdongjiu
2017-10-18 10:17     ` Borislav Petkov
2017-10-18 10:17       ` Borislav Petkov
2017-10-18 12:27       ` gengdongjiu
2017-10-18 12:27         ` [Devel] " gengdongjiu
2017-10-18 12:27         ` gengdongjiu
2017-10-18 12:27         ` gengdongjiu
2017-10-18 13:14         ` Borislav Petkov
2017-10-18 13:14           ` Borislav Petkov
2017-10-18 15:14 gengdongjiu
2017-10-18 15:14 ` gengdongjiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9287b646-7673-bf5d-bcde-933c8c98a0dd@codeaurora.org \
    --to=tbaicar@codeaurora.org \
    --cc=bp@suse.de \
    --cc=devel@acpica.or \
    --cc=gengdongjiu@huawei.com \
    --cc=james.morse@arm.com \
    --cc=kamensky@cisco.com \
    --cc=kristina.martsenko@arm.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lv.zheng@intel.com \
    --cc=mark.rutland@arm.com \
    --cc=mingo@kernel.org \
    --cc=prarit@redhat.com \
    --cc=punit.agrawal@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=robert.moore@intel.com \
    --cc=shiju.jose@huawei.com \
    --cc=stephen.boyd@linaro.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.