From: SF Markus Elfring <elfring@users.sourceforge.net> To: linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org> Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: [PATCH 9/9] pinctrl: Adjust nine checks for null pointers Date: Tue, 2 May 2017 11:29:09 +0200 [thread overview] Message-ID: <9294b4fd-f4f1-9540-973b-08c0cfee04c8@users.sourceforge.net> (raw) In-Reply-To: <d8cce619-5a37-2f8b-1c07-a4c45443fb50@users.sourceforge.net> From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 2 May 2017 11:04:55 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code places. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/pinctrl/core.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 7df16771fa13..b1044f07e0a1 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -170,7 +170,7 @@ const char *pin_get_name(struct pinctrl_dev *pctldev, const unsigned pin) const struct pin_desc *desc; desc = pin_desc_get(pctldev, pin); - if (desc == NULL) { + if (!desc) { dev_err(pctldev->dev, "failed to get pin(%d) name\n", pin); return NULL; @@ -214,7 +214,7 @@ static void pinctrl_free_pindescs(struct pinctrl_dev *pctldev, pindesc = radix_tree_lookup(&pctldev->pin_desc_tree, pins[i].number); - if (pindesc != NULL) { + if (pindesc) { radix_tree_delete(&pctldev->pin_desc_tree, pins[i].number); if (pindesc->dynamic_name) @@ -230,7 +230,7 @@ static int pinctrl_register_one_pin(struct pinctrl_dev *pctldev, struct pin_desc *pindesc; pindesc = pin_desc_get(pctldev, pin->number); - if (pindesc != NULL) { + if (pindesc) { dev_err(pctldev->dev, "pin %d already registered\n", pin->number); return -EINVAL; @@ -248,7 +248,7 @@ static int pinctrl_register_one_pin(struct pinctrl_dev *pctldev, pindesc->name = pin->name; } else { pindesc->name = kasprintf(GFP_KERNEL, "PIN%u", pin->number); - if (pindesc->name == NULL) { + if (!pindesc->name) { kfree(pindesc); return -ENOMEM; } @@ -402,7 +402,7 @@ static int pinctrl_get_device_gpio_range(unsigned gpio, struct pinctrl_gpio_range *range; range = pinctrl_match_gpio_range(pctldev, gpio); - if (range != NULL) { + if (range) { *outdev = pctldev; *outrange = range; mutex_unlock(&pinctrldev_list_mutex); @@ -947,7 +947,7 @@ static int add_setting(struct pinctrl *p, struct pinctrl_dev *pctldev, else setting->pctldev = get_pinctrl_dev_from_devname(map->ctrl_dev_name); - if (setting->pctldev == NULL) { + if (!setting->pctldev) { kfree(setting); /* Do not defer probing of hogs (circular loop) */ if (!strcmp(map->ctrl_dev_name, map->dev_name)) @@ -1094,7 +1094,7 @@ struct pinctrl *pinctrl_get(struct device *dev) * return another pointer to it. */ p = find_pinctrl(dev); - if (p != NULL) { + if (p) { dev_dbg(dev, "obtain a copy of previously claimed pinctrl\n"); kref_get(&p->users); return p; @@ -1565,7 +1565,7 @@ static int pinctrl_pins_show(struct seq_file *s, void *what) pin = pctldev->desc->pins[i].number; desc = pin_desc_get(pctldev, pin); /* Pin space may be sparse */ - if (desc == NULL) + if (!desc) continue; seq_printf(s, "pin %d (%s) ", pin, desc->name); @@ -2145,7 +2145,7 @@ void pinctrl_unregister(struct pinctrl_dev *pctldev) { struct pinctrl_gpio_range *range, *n; - if (pctldev == NULL) + if (!pctldev) return; mutex_lock(&pctldev->mutex); -- 2.12.2
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net> To: linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org> Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: [PATCH 9/9] pinctrl: Adjust nine checks for null pointers Date: Tue, 02 May 2017 09:29:09 +0000 [thread overview] Message-ID: <9294b4fd-f4f1-9540-973b-08c0cfee04c8@users.sourceforge.net> (raw) In-Reply-To: <d8cce619-5a37-2f8b-1c07-a4c45443fb50@users.sourceforge.net> From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 2 May 2017 11:04:55 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code places. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/pinctrl/core.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 7df16771fa13..b1044f07e0a1 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -170,7 +170,7 @@ const char *pin_get_name(struct pinctrl_dev *pctldev, const unsigned pin) const struct pin_desc *desc; desc = pin_desc_get(pctldev, pin); - if (desc = NULL) { + if (!desc) { dev_err(pctldev->dev, "failed to get pin(%d) name\n", pin); return NULL; @@ -214,7 +214,7 @@ static void pinctrl_free_pindescs(struct pinctrl_dev *pctldev, pindesc = radix_tree_lookup(&pctldev->pin_desc_tree, pins[i].number); - if (pindesc != NULL) { + if (pindesc) { radix_tree_delete(&pctldev->pin_desc_tree, pins[i].number); if (pindesc->dynamic_name) @@ -230,7 +230,7 @@ static int pinctrl_register_one_pin(struct pinctrl_dev *pctldev, struct pin_desc *pindesc; pindesc = pin_desc_get(pctldev, pin->number); - if (pindesc != NULL) { + if (pindesc) { dev_err(pctldev->dev, "pin %d already registered\n", pin->number); return -EINVAL; @@ -248,7 +248,7 @@ static int pinctrl_register_one_pin(struct pinctrl_dev *pctldev, pindesc->name = pin->name; } else { pindesc->name = kasprintf(GFP_KERNEL, "PIN%u", pin->number); - if (pindesc->name = NULL) { + if (!pindesc->name) { kfree(pindesc); return -ENOMEM; } @@ -402,7 +402,7 @@ static int pinctrl_get_device_gpio_range(unsigned gpio, struct pinctrl_gpio_range *range; range = pinctrl_match_gpio_range(pctldev, gpio); - if (range != NULL) { + if (range) { *outdev = pctldev; *outrange = range; mutex_unlock(&pinctrldev_list_mutex); @@ -947,7 +947,7 @@ static int add_setting(struct pinctrl *p, struct pinctrl_dev *pctldev, else setting->pctldev get_pinctrl_dev_from_devname(map->ctrl_dev_name); - if (setting->pctldev = NULL) { + if (!setting->pctldev) { kfree(setting); /* Do not defer probing of hogs (circular loop) */ if (!strcmp(map->ctrl_dev_name, map->dev_name)) @@ -1094,7 +1094,7 @@ struct pinctrl *pinctrl_get(struct device *dev) * return another pointer to it. */ p = find_pinctrl(dev); - if (p != NULL) { + if (p) { dev_dbg(dev, "obtain a copy of previously claimed pinctrl\n"); kref_get(&p->users); return p; @@ -1565,7 +1565,7 @@ static int pinctrl_pins_show(struct seq_file *s, void *what) pin = pctldev->desc->pins[i].number; desc = pin_desc_get(pctldev, pin); /* Pin space may be sparse */ - if (desc = NULL) + if (!desc) continue; seq_printf(s, "pin %d (%s) ", pin, desc->name); @@ -2145,7 +2145,7 @@ void pinctrl_unregister(struct pinctrl_dev *pctldev) { struct pinctrl_gpio_range *range, *n; - if (pctldev = NULL) + if (!pctldev) return; mutex_lock(&pctldev->mutex); -- 2.12.2
next prev parent reply other threads:[~2017-05-02 9:29 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-02 9:20 [PATCH 0/9] pinctrl: Fine-tuning for some function implementations SF Markus Elfring 2017-05-02 9:20 ` SF Markus Elfring 2017-05-02 9:21 ` [PATCH 1/9] pinctrl: Use seq_putc() in three functions SF Markus Elfring 2017-05-02 9:21 ` SF Markus Elfring 2017-05-11 11:34 ` Linus Walleij 2017-05-11 11:34 ` Linus Walleij 2017-05-02 9:22 ` [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in two functions SF Markus Elfring 2017-05-02 9:22 ` SF Markus Elfring 2017-05-03 17:47 ` Andy Shevchenko 2017-05-03 17:47 ` Andy Shevchenko 2017-05-02 9:23 ` [PATCH 3/9] pinctrl: Combine five seq_printf() calls into one call in pinconf_dbg_config_print() SF Markus Elfring 2017-05-02 9:23 ` SF Markus Elfring 2017-05-03 17:48 ` Andy Shevchenko 2017-05-03 17:48 ` Andy Shevchenko 2017-05-02 9:24 ` [PATCH 4/9] pinctrl: Replace two seq_printf() calls by seq_puts() in pinconf_show_map() SF Markus Elfring 2017-05-02 9:24 ` SF Markus Elfring 2017-05-11 13:24 ` Linus Walleij 2017-05-11 13:24 ` Linus Walleij 2017-05-02 9:25 ` [PATCH 5/9] pinctrl: Adjust five checks for null pointers SF Markus Elfring 2017-05-02 9:25 ` SF Markus Elfring 2017-05-11 13:25 ` Linus Walleij 2017-05-11 13:25 ` Linus Walleij 2017-05-02 9:26 ` [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get() SF Markus Elfring 2017-05-02 9:26 ` SF Markus Elfring 2017-05-03 17:49 ` Andy Shevchenko 2017-05-03 17:49 ` Andy Shevchenko 2017-05-11 13:26 ` Linus Walleij 2017-05-11 13:26 ` Linus Walleij 2017-05-02 9:27 ` [PATCH 7/9] pinctrl: Add spaces for better code readability SF Markus Elfring 2017-05-02 9:27 ` SF Markus Elfring 2017-05-11 13:27 ` Linus Walleij 2017-05-11 13:27 ` Linus Walleij 2017-05-02 9:28 ` [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show() SF Markus Elfring 2017-05-02 9:28 ` SF Markus Elfring 2017-05-03 17:45 ` Andy Shevchenko 2017-05-03 17:45 ` Andy Shevchenko 2017-05-11 13:28 ` Linus Walleij 2017-05-11 13:28 ` Linus Walleij 2017-05-02 9:29 ` SF Markus Elfring [this message] 2017-05-02 9:29 ` [PATCH 9/9] pinctrl: Adjust nine checks for null pointers SF Markus Elfring 2017-05-11 13:29 ` Linus Walleij 2017-05-11 13:29 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9294b4fd-f4f1-9540-973b-08c0cfee04c8@users.sourceforge.net \ --to=elfring@users.sourceforge.net \ --cc=kernel-janitors@vger.kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.