All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/9] pinctrl: Combine five seq_printf() calls into one call in pinconf_dbg_config_print()
Date: Wed, 3 May 2017 20:48:17 +0300	[thread overview]
Message-ID: <CAHp75Vdrz91SD=xxBZS9_3kL3XPeVbgyaZpYy52TUixcYHx3vw@mail.gmail.com> (raw)
In-Reply-To: <fe725663-d873-b8e4-f364-9abec47ba17e@users.sourceforge.net>

On Tue, May 2, 2017 at 12:23 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 1 May 2017 22:52:29 +0200
>
> Some data were put into a sequence by five separate function calls.
> Print the same data by a single function call instead.

> -               seq_printf(s, "No config found for dev/state/pin, expected:\n");
> -               seq_printf(s, "Searched dev:%s\n", dbg->dev_name);
> -               seq_printf(s, "Searched state:%s\n", dbg->state_name);
> -               seq_printf(s, "Searched pin:%s\n", dbg->pin_name);
> -               seq_printf(s, "Use: modify config_pin <devname> "\
> -                               "<state> <pinname> <value>\n");
> +               seq_printf(s,
> +                          "No config found for dev/state/pin, expected:\n"
> +                          "Searched dev:%s\n"
> +                          "Searched state:%s\n"
> +                          "Searched pin:%s\n"
> +                          "Use: modify config_pin <devname> <state> <pinname> <value>\n",
> +                          dbg->dev_name,
> +                          dbg->state_name,
> +                          dbg->pin_name);

Please, no.

-- 
With Best Regards,
Andy Shevchenko

WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/9] pinctrl: Combine five seq_printf() calls into one call in pinconf_dbg_config_print()
Date: Wed, 03 May 2017 17:48:17 +0000	[thread overview]
Message-ID: <CAHp75Vdrz91SD=xxBZS9_3kL3XPeVbgyaZpYy52TUixcYHx3vw@mail.gmail.com> (raw)
In-Reply-To: <fe725663-d873-b8e4-f364-9abec47ba17e@users.sourceforge.net>

On Tue, May 2, 2017 at 12:23 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 1 May 2017 22:52:29 +0200
>
> Some data were put into a sequence by five separate function calls.
> Print the same data by a single function call instead.

> -               seq_printf(s, "No config found for dev/state/pin, expected:\n");
> -               seq_printf(s, "Searched dev:%s\n", dbg->dev_name);
> -               seq_printf(s, "Searched state:%s\n", dbg->state_name);
> -               seq_printf(s, "Searched pin:%s\n", dbg->pin_name);
> -               seq_printf(s, "Use: modify config_pin <devname> "\
> -                               "<state> <pinname> <value>\n");
> +               seq_printf(s,
> +                          "No config found for dev/state/pin, expected:\n"
> +                          "Searched dev:%s\n"
> +                          "Searched state:%s\n"
> +                          "Searched pin:%s\n"
> +                          "Use: modify config_pin <devname> <state> <pinname> <value>\n",
> +                          dbg->dev_name,
> +                          dbg->state_name,
> +                          dbg->pin_name);

Please, no.

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2017-05-03 17:48 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-02  9:20 [PATCH 0/9] pinctrl: Fine-tuning for some function implementations SF Markus Elfring
2017-05-02  9:20 ` SF Markus Elfring
2017-05-02  9:21 ` [PATCH 1/9] pinctrl: Use seq_putc() in three functions SF Markus Elfring
2017-05-02  9:21   ` SF Markus Elfring
2017-05-11 11:34   ` Linus Walleij
2017-05-11 11:34     ` Linus Walleij
2017-05-02  9:22 ` [PATCH 2/9] pinctrl: Combine two seq_puts() calls into one call in two functions SF Markus Elfring
2017-05-02  9:22   ` SF Markus Elfring
2017-05-03 17:47   ` Andy Shevchenko
2017-05-03 17:47     ` Andy Shevchenko
2017-05-02  9:23 ` [PATCH 3/9] pinctrl: Combine five seq_printf() calls into one call in pinconf_dbg_config_print() SF Markus Elfring
2017-05-02  9:23   ` SF Markus Elfring
2017-05-03 17:48   ` Andy Shevchenko [this message]
2017-05-03 17:48     ` Andy Shevchenko
2017-05-02  9:24 ` [PATCH 4/9] pinctrl: Replace two seq_printf() calls by seq_puts() in pinconf_show_map() SF Markus Elfring
2017-05-02  9:24   ` SF Markus Elfring
2017-05-11 13:24   ` Linus Walleij
2017-05-11 13:24     ` Linus Walleij
2017-05-02  9:25 ` [PATCH 5/9] pinctrl: Adjust five checks for null pointers SF Markus Elfring
2017-05-02  9:25   ` SF Markus Elfring
2017-05-11 13:25   ` Linus Walleij
2017-05-11 13:25     ` Linus Walleij
2017-05-02  9:26 ` [PATCH 6/9] pinctrl: Combine substrings for a message in pin_config_group_get() SF Markus Elfring
2017-05-02  9:26   ` SF Markus Elfring
2017-05-03 17:49   ` Andy Shevchenko
2017-05-03 17:49     ` Andy Shevchenko
2017-05-11 13:26   ` Linus Walleij
2017-05-11 13:26     ` Linus Walleij
2017-05-02  9:27 ` [PATCH 7/9] pinctrl: Add spaces for better code readability SF Markus Elfring
2017-05-02  9:27   ` SF Markus Elfring
2017-05-11 13:27   ` Linus Walleij
2017-05-11 13:27     ` Linus Walleij
2017-05-02  9:28 ` [PATCH 8/9] pinctrl: Use seq_putc() in pinctrl_maps_show() SF Markus Elfring
2017-05-02  9:28   ` SF Markus Elfring
2017-05-03 17:45   ` Andy Shevchenko
2017-05-03 17:45     ` Andy Shevchenko
2017-05-11 13:28   ` Linus Walleij
2017-05-11 13:28     ` Linus Walleij
2017-05-02  9:29 ` [PATCH 9/9] pinctrl: Adjust nine checks for null pointers SF Markus Elfring
2017-05-02  9:29   ` SF Markus Elfring
2017-05-11 13:29   ` Linus Walleij
2017-05-11 13:29     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75Vdrz91SD=xxBZS9_3kL3XPeVbgyaZpYy52TUixcYHx3vw@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=elfring@users.sourceforge.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.