All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
To: Sinan Kaya <okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Lorenzo Pieralisi
	<lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>,
	Sricharan R <sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	Tomasz Nowicki <tn-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH V7 08/11] drivers: acpi: Handle IOMMU lookup failure with deferred probing or error
Date: Mon, 30 Jan 2017 12:22:11 +0000	[thread overview]
Message-ID: <93e79759-d614-9b36-d5ab-63e8eb725009@arm.com> (raw)
In-Reply-To: <f2370671-ece8-fbee-de19-350dd625088f-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>

On 29/01/17 17:53, Sinan Kaya wrote:
> On 1/24/2017 7:37 AM, Lorenzo Pieralisi wrote:
>> [+hanjun, tomasz, sinan]
>>
>> It is quite a key patchset, I would be glad if they can test on their
>> respective platforms with IORT.
>>
> 
> Tested on top of 4.10-rc5.
> 
> 1.	Platform Hidma device passed dmatest
> 2.	Seeing some USB stalls on a platform USB device.
> 3.	PCIe NVME drive probed and worked fine with MSI interrupts after boot.
> 4. 	NVMe driver didn't probe following a hotplug insertion and received an
> SMMU error event during the insertion.

What was the SMMU error - a translation/permission fault (implying the
wrong DMA ops) or a bad STE fault (implying we totally failed to tell
the SMMU about the device at all)?

Robin.

> 
> /sys/bus/pci/slots/4 #
> /sys/bus/pci/slots/4 # dmesg | grep nvme
> [   14.041357] nvme nvme0: pci function 0003:01:00.0
> [  198.399521] nvme nvme0: pci function 0003:01:00.0
> [__198.416232]_nvme_0003:01:00.0:_enabling_device_(0000_->_0002)
> [  264.402216] nvme nvme0: I/O 228 QID 0 timeout, disable controller
> [  264.402313] nvme nvme0: Identify Controller failed (-4)
> [  264.421270] nvme nvme0: Removing after probe failure status: -5
> /sys/bus/pci/slots/4 #
> 
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Sinan Kaya <okaya@codeaurora.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Sricharan R <sricharan@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, joro@8bytes.org,
	will.deacon@arm.com, linux-acpi@vger.kernel.org,
	iommu@lists.linux-foundation.org,
	Hanjun Guo <hanjun.guo@linaro.org>,
	linux-pci@vger.kernel.org, bhelgaas@google.com,
	Tomasz Nowicki <tn@semihalf.com>,
	linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com
Subject: Re: [PATCH V7 08/11] drivers: acpi: Handle IOMMU lookup failure with deferred probing or error
Date: Mon, 30 Jan 2017 12:22:11 +0000	[thread overview]
Message-ID: <93e79759-d614-9b36-d5ab-63e8eb725009@arm.com> (raw)
In-Reply-To: <f2370671-ece8-fbee-de19-350dd625088f@codeaurora.org>

On 29/01/17 17:53, Sinan Kaya wrote:
> On 1/24/2017 7:37 AM, Lorenzo Pieralisi wrote:
>> [+hanjun, tomasz, sinan]
>>
>> It is quite a key patchset, I would be glad if they can test on their
>> respective platforms with IORT.
>>
> 
> Tested on top of 4.10-rc5.
> 
> 1.	Platform Hidma device passed dmatest
> 2.	Seeing some USB stalls on a platform USB device.
> 3.	PCIe NVME drive probed and worked fine with MSI interrupts after boot.
> 4. 	NVMe driver didn't probe following a hotplug insertion and received an
> SMMU error event during the insertion.

What was the SMMU error - a translation/permission fault (implying the
wrong DMA ops) or a bad STE fault (implying we totally failed to tell
the SMMU about the device at all)?

Robin.

> 
> /sys/bus/pci/slots/4 #
> /sys/bus/pci/slots/4 # dmesg | grep nvme
> [   14.041357] nvme nvme0: pci function 0003:01:00.0
> [  198.399521] nvme nvme0: pci function 0003:01:00.0
> [__198.416232]_nvme_0003:01:00.0:_enabling_device_(0000_->_0002)
> [  264.402216] nvme nvme0: I/O 228 QID 0 timeout, disable controller
> [  264.402313] nvme nvme0: Identify Controller failed (-4)
> [  264.421270] nvme nvme0: Removing after probe failure status: -5
> /sys/bus/pci/slots/4 #
> 
> 
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: robin.murphy@arm.com (Robin Murphy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V7 08/11] drivers: acpi: Handle IOMMU lookup failure with deferred probing or error
Date: Mon, 30 Jan 2017 12:22:11 +0000	[thread overview]
Message-ID: <93e79759-d614-9b36-d5ab-63e8eb725009@arm.com> (raw)
In-Reply-To: <f2370671-ece8-fbee-de19-350dd625088f@codeaurora.org>

On 29/01/17 17:53, Sinan Kaya wrote:
> On 1/24/2017 7:37 AM, Lorenzo Pieralisi wrote:
>> [+hanjun, tomasz, sinan]
>>
>> It is quite a key patchset, I would be glad if they can test on their
>> respective platforms with IORT.
>>
> 
> Tested on top of 4.10-rc5.
> 
> 1.	Platform Hidma device passed dmatest
> 2.	Seeing some USB stalls on a platform USB device.
> 3.	PCIe NVME drive probed and worked fine with MSI interrupts after boot.
> 4. 	NVMe driver didn't probe following a hotplug insertion and received an
> SMMU error event during the insertion.

What was the SMMU error - a translation/permission fault (implying the
wrong DMA ops) or a bad STE fault (implying we totally failed to tell
the SMMU about the device at all)?

Robin.

> 
> /sys/bus/pci/slots/4 #
> /sys/bus/pci/slots/4 # dmesg | grep nvme
> [   14.041357] nvme nvme0: pci function 0003:01:00.0
> [  198.399521] nvme nvme0: pci function 0003:01:00.0
> [__198.416232]_nvme_0003:01:00.0:_enabling_device_(0000_->_0002)
> [  264.402216] nvme nvme0: I/O 228 QID 0 timeout, disable controller
> [  264.402313] nvme nvme0: Identify Controller failed (-4)
> [  264.421270] nvme nvme0: Removing after probe failure status: -5
> /sys/bus/pci/slots/4 #
> 
> 
> 

  parent reply	other threads:[~2017-01-30 12:22 UTC|newest]

Thread overview: 147+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170123161926epcas2p1cf464a2978d89d0c1fdd2f7cc6d38317@epcas2p1.samsung.com>
2017-01-23 16:18 ` [PATCH V7 00/11] IOMMU probe deferral support Sricharan R
2017-01-23 16:18   ` Sricharan R
2017-01-23 16:18   ` [PATCH V7 01/11] iommu/of: Refactor of_iommu_configure() for error handling Sricharan R
2017-01-23 16:18     ` Sricharan R
2017-01-23 16:18     ` Sricharan R
     [not found]     ` <1485188293-20263-2-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-01-25 17:17       ` Tomasz Nowicki
2017-01-25 17:17         ` Tomasz Nowicki
2017-01-25 17:17         ` Tomasz Nowicki
2017-01-25 17:35         ` Robin Murphy
2017-01-25 17:35           ` Robin Murphy
2017-01-25 18:13           ` Tomasz Nowicki
2017-01-25 18:13             ` Tomasz Nowicki
     [not found]           ` <c7bad124-d9f2-0ddf-168f-0b1950d3e1ed-5wv7dgnIgG8@public.gmane.org>
2017-01-27 18:00             ` Sricharan
2017-01-27 18:00               ` Sricharan
2017-01-27 18:00               ` Sricharan
2017-01-27 18:19               ` Robin Murphy
2017-01-27 18:19                 ` Robin Murphy
2017-01-27 18:19                 ` Robin Murphy
2017-01-30  7:00                 ` Sricharan
2017-01-30  7:00                   ` Sricharan
2017-01-30  7:00                   ` Sricharan
2017-01-30 18:42                   ` Robin Murphy
2017-01-30 18:42                     ` Robin Murphy
2017-01-30 18:42                     ` Robin Murphy
     [not found]                     ` <8387d057-15bd-500c-134e-0e731ff837d6-5wv7dgnIgG8@public.gmane.org>
2017-01-31 13:11                       ` Sricharan
2017-01-31 13:11                         ` Sricharan
2017-01-31 13:11                         ` Sricharan
2017-01-23 16:18   ` [PATCH V7 02/11] iommu/of: Prepare for deferred IOMMU configuration Sricharan R
2017-01-23 16:18     ` Sricharan R
2017-01-23 16:18   ` [PATCH V7 03/11] of: dma: Move range size workaround to of_dma_get_range() Sricharan R
2017-01-23 16:18     ` Sricharan R
2017-01-23 16:18   ` [PATCH V7 05/11] ACPI/IORT: Add function to check SMMUs drivers presence Sricharan R
2017-01-23 16:18     ` Sricharan R
2017-01-23 16:18   ` [PATCH V7 06/11] of/acpi: Configure dma operations at probe time for platform/amba/pci bus devices Sricharan R
2017-01-23 16:18     ` Sricharan R
2017-01-28 21:08     ` Bjorn Helgaas
2017-01-28 21:08       ` Bjorn Helgaas
2017-01-30  7:09     ` Rafael J. Wysocki
2017-01-30  7:09       ` Rafael J. Wysocki
2017-01-23 16:18   ` [PATCH V7 07/11] iommu: of: Handle IOMMU lookup failure with deferred probing or error Sricharan R
2017-01-23 16:18     ` Sricharan R
     [not found]     ` <1485188293-20263-8-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-01-28 21:03       ` Bjorn Helgaas
2017-01-28 21:03         ` Bjorn Helgaas
2017-01-28 21:03         ` Bjorn Helgaas
2017-01-30  8:01         ` Sricharan
2017-01-30  8:01           ` Sricharan
2017-01-30  8:01           ` Sricharan
2017-01-29 16:36     ` Sinan Kaya
2017-01-29 16:36       ` Sinan Kaya
2017-01-29 16:36       ` Sinan Kaya
     [not found]       ` <34a703f0-3b37-88f0-46fa-b56ab6717a42-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-01-30 12:00         ` Sricharan
2017-01-30 12:00           ` Sricharan
2017-01-30 12:00           ` Sricharan
2017-01-23 16:18   ` [PATCH V7 08/11] drivers: acpi: " Sricharan R
2017-01-23 16:18     ` Sricharan R
2017-01-24 12:37     ` Lorenzo Pieralisi
2017-01-24 12:37       ` Lorenzo Pieralisi
2017-01-24 13:14       ` Hanjun Guo
2017-01-24 13:14         ` Hanjun Guo
2017-01-24 13:14         ` Hanjun Guo
2017-01-25  7:31       ` Sricharan
2017-01-25  7:31         ` Sricharan
2017-01-25  7:31         ` Sricharan
2017-01-29 17:53       ` Sinan Kaya
2017-01-29 17:53         ` Sinan Kaya
2017-01-29 17:53         ` Sinan Kaya
     [not found]         ` <f2370671-ece8-fbee-de19-350dd625088f-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-01-30 12:22           ` Robin Murphy [this message]
2017-01-30 12:22             ` Robin Murphy
2017-01-30 12:22             ` Robin Murphy
     [not found]             ` <93e79759-d614-9b36-d5ab-63e8eb725009-5wv7dgnIgG8@public.gmane.org>
2017-01-30 13:59               ` Sinan Kaya
2017-01-30 13:59                 ` Sinan Kaya
2017-01-30 13:59                 ` Sinan Kaya
     [not found]                 ` <14751205-f034-7f0d-442a-854c3909425c-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-01-30 14:23                   ` Nate Watterson
2017-01-30 14:23                     ` Nate Watterson
2017-01-30 14:23                     ` Nate Watterson
     [not found]                     ` <5ba9f366d6e25397cdef8ad95b49e199-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-01-30 14:33                       ` Sinan Kaya
2017-01-30 14:33                         ` Sinan Kaya
2017-01-30 14:33                         ` Sinan Kaya
2017-01-30 14:38                         ` Will Deacon
2017-01-30 14:38                           ` Will Deacon
2017-01-30 14:38                           ` Will Deacon
     [not found]                           ` <20170130143851.GJ16461-5wv7dgnIgG8@public.gmane.org>
2017-01-30 14:54                             ` Nate Watterson
2017-01-30 14:54                               ` Nate Watterson
2017-01-30 14:54                               ` Nate Watterson
     [not found]                               ` <b2e50c17de156341deab9fb8e91a8dec-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-01-30 15:46                                 ` Sinan Kaya
2017-01-30 15:46                                   ` Sinan Kaya
2017-01-30 15:46                                   ` Sinan Kaya
     [not found]                                   ` <1e048aff-0d77-b9f2-ebf8-2ba315b90ca7-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-01-30 16:51                                     ` Lorenzo Pieralisi
2017-01-30 16:51                                       ` Lorenzo Pieralisi
2017-01-30 16:51                                       ` Lorenzo Pieralisi
2017-01-30 20:03                                       ` Sinan Kaya
2017-01-30 20:03                                         ` Sinan Kaya
2017-02-01 18:52                                         ` Lorenzo Pieralisi
2017-02-01 18:52                                           ` Lorenzo Pieralisi
2017-02-01 18:52                                           ` Lorenzo Pieralisi
2017-02-01 19:10                                           ` Sinan Kaya
2017-02-01 19:10                                             ` Sinan Kaya
2017-02-01 19:10                                             ` Sinan Kaya
2017-02-02 19:01                                           ` Nate Watterson
2017-02-02 19:01                                             ` Nate Watterson
     [not found]                                             ` <3f4aa4c1e660c7e62256de9ca64fc822-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-02-03  3:37                                               ` Hanjun Guo
2017-02-03  3:37                                                 ` Hanjun Guo
2017-02-03  3:37                                                 ` Hanjun Guo
2017-02-03  3:37                                             ` Sricharan
2017-02-03  3:37                                               ` Sricharan
2017-02-03  3:37                                               ` Sricharan
2017-01-23 16:18   ` [PATCH V7 09/11] arm64: dma-mapping: Remove the notifier trick to handle early setting of dma_ops Sricharan R
2017-01-23 16:18     ` Sricharan R
     [not found]     ` <1485188293-20263-10-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-01-28 21:06       ` Bjorn Helgaas
2017-01-28 21:06         ` Bjorn Helgaas
2017-01-28 21:06         ` Bjorn Helgaas
     [not found]         ` <20170128210611.GF20550-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org>
2017-01-30  8:04           ` Sricharan
2017-01-30  8:04             ` Sricharan
2017-01-30  8:04             ` Sricharan
2017-01-23 16:18   ` [PATCH V7 10/11] iommu/arm-smmu: Clean up early-probing workarounds Sricharan R
2017-01-23 16:18     ` Sricharan R
2017-01-25 17:28     ` Tomasz Nowicki
2017-01-25 17:28       ` Tomasz Nowicki
     [not found]     ` <1485188293-20263-11-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-01-28 21:07       ` Bjorn Helgaas
2017-01-28 21:07         ` Bjorn Helgaas
2017-01-28 21:07         ` Bjorn Helgaas
     [not found]         ` <20170128210709.GG20550-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org>
2017-01-30  8:05           ` Sricharan
2017-01-30  8:05             ` Sricharan
2017-01-30  8:05             ` Sricharan
2017-01-23 16:18   ` [PATCH V7 11/11] ACPI/IORT: Remove linker section for IORT entries probing Sricharan R
2017-01-23 16:18     ` Sricharan R
     [not found]   ` <1485188293-20263-1-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-01-23 16:18     ` [PATCH V7 04/11] of: dma: Make of_dma_deconfigure() public Sricharan R
2017-01-23 16:18       ` Sricharan R
2017-01-23 16:18       ` Sricharan R
2017-01-24  7:40     ` [PATCH V7 00/11] IOMMU probe deferral support Marek Szyprowski
2017-01-24  7:40       ` Marek Szyprowski
2017-01-24  7:40       ` Marek Szyprowski
2017-01-24 11:15       ` Sricharan
2017-01-24 11:15         ` Sricharan
2017-01-24 11:15         ` Sricharan
2017-01-25  4:33     ` Hanjun Guo
2017-01-25  4:33       ` Hanjun Guo
2017-01-25  4:33       ` Hanjun Guo
2017-01-25  7:33       ` Sricharan
2017-01-25  7:33         ` Sricharan
2017-01-25  7:33         ` Sricharan
2017-01-28 21:10     ` Bjorn Helgaas
2017-01-28 21:10       ` Bjorn Helgaas
2017-01-28 21:10       ` Bjorn Helgaas
     [not found]       ` <20170128211029.GI20550-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org>
2017-01-30  9:20         ` Sricharan
2017-01-30  9:20           ` Sricharan
2017-01-30  9:20           ` Sricharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93e79759-d614-9b36-d5ab-63e8eb725009@arm.com \
    --to=robin.murphy-5wv7dgnigg8@public.gmane.org \
    --cc=bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org \
    --cc=okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=tn-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org \
    --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.