All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: John Keeping <john@metanate.com>, u-boot@lists.denx.de
Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
	Philipp Tomsich <philipp.tomsich@vrull.eu>,
	Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH] rockchip: boot_mode: fix fastboot command
Date: Fri, 24 Dec 2021 15:07:18 +0800	[thread overview]
Message-ID: <951c970a-3d78-50b1-c162-497a83386628@rock-chips.com> (raw)
In-Reply-To: <20211125180522.4113337-1-john@metanate.com>


On 2021/11/26 上午2:05, John Keeping wrote:
> The USB controller index must be separated from the type argument,
> otherwise the preboot command fails with the error:
>
> 	Error: Wrong USB controller index format
>
> Add the missing space to fix fastboot mode here.
>
> Signed-off-by: John Keeping <john@metanate.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>
>   arch/arm/mach-rockchip/boot_mode.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/boot_mode.c b/arch/arm/mach-rockchip/boot_mode.c
> index 2158934159..1a1a887fc2 100644
> --- a/arch/arm/mach-rockchip/boot_mode.c
> +++ b/arch/arm/mach-rockchip/boot_mode.c
> @@ -95,7 +95,7 @@ int setup_boot_mode(void)
>   	switch (boot_mode) {
>   	case BOOT_FASTBOOT:
>   		debug("%s: enter fastboot!\n", __func__);
> -		env_set("preboot", "setenv preboot; fastboot usb0");
> +		env_set("preboot", "setenv preboot; fastboot usb 0");
>   		break;
>   	case BOOT_UMS:
>   		debug("%s: enter UMS!\n", __func__);



      reply	other threads:[~2021-12-24  7:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25 18:05 [PATCH] rockchip: boot_mode: fix fastboot command John Keeping
2021-12-24  7:07 ` Kever Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=951c970a-3d78-50b1-c162-497a83386628@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=john@metanate.com \
    --cc=philipp.tomsich@theobroma-systems.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.