* [PATCH] rockchip: boot_mode: fix fastboot command
@ 2021-11-25 18:05 John Keeping
2021-12-24 7:07 ` Kever Yang
0 siblings, 1 reply; 2+ messages in thread
From: John Keeping @ 2021-11-25 18:05 UTC (permalink / raw)
To: u-boot
Cc: John Keeping, Kever Yang, Philipp Tomsich, Philipp Tomsich, Simon Glass
The USB controller index must be separated from the type argument,
otherwise the preboot command fails with the error:
Error: Wrong USB controller index format
Add the missing space to fix fastboot mode here.
Signed-off-by: John Keeping <john@metanate.com>
---
arch/arm/mach-rockchip/boot_mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-rockchip/boot_mode.c b/arch/arm/mach-rockchip/boot_mode.c
index 2158934159..1a1a887fc2 100644
--- a/arch/arm/mach-rockchip/boot_mode.c
+++ b/arch/arm/mach-rockchip/boot_mode.c
@@ -95,7 +95,7 @@ int setup_boot_mode(void)
switch (boot_mode) {
case BOOT_FASTBOOT:
debug("%s: enter fastboot!\n", __func__);
- env_set("preboot", "setenv preboot; fastboot usb0");
+ env_set("preboot", "setenv preboot; fastboot usb 0");
break;
case BOOT_UMS:
debug("%s: enter UMS!\n", __func__);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rockchip: boot_mode: fix fastboot command
2021-11-25 18:05 [PATCH] rockchip: boot_mode: fix fastboot command John Keeping
@ 2021-12-24 7:07 ` Kever Yang
0 siblings, 0 replies; 2+ messages in thread
From: Kever Yang @ 2021-12-24 7:07 UTC (permalink / raw)
To: John Keeping, u-boot; +Cc: Philipp Tomsich, Philipp Tomsich, Simon Glass
On 2021/11/26 上午2:05, John Keeping wrote:
> The USB controller index must be separated from the type argument,
> otherwise the preboot command fails with the error:
>
> Error: Wrong USB controller index format
>
> Add the missing space to fix fastboot mode here.
>
> Signed-off-by: John Keeping <john@metanate.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
>
> arch/arm/mach-rockchip/boot_mode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/boot_mode.c b/arch/arm/mach-rockchip/boot_mode.c
> index 2158934159..1a1a887fc2 100644
> --- a/arch/arm/mach-rockchip/boot_mode.c
> +++ b/arch/arm/mach-rockchip/boot_mode.c
> @@ -95,7 +95,7 @@ int setup_boot_mode(void)
> switch (boot_mode) {
> case BOOT_FASTBOOT:
> debug("%s: enter fastboot!\n", __func__);
> - env_set("preboot", "setenv preboot; fastboot usb0");
> + env_set("preboot", "setenv preboot; fastboot usb 0");
> break;
> case BOOT_UMS:
> debug("%s: enter UMS!\n", __func__);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-24 7:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-25 18:05 [PATCH] rockchip: boot_mode: fix fastboot command John Keeping
2021-12-24 7:07 ` Kever Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.