From: Andrzej Hajda <andrzej.hajda@intel.com> To: Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org Cc: "Rob Clark" <robdclark@chromium.org>, "Thomas Hellström" <thomas.hellstrom@linux.intel.com>, "David Airlie" <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, "open list" <linux-kernel@vger.kernel.org>, "Sumit Semwal" <sumit.semwal@linaro.org>, "moderated list:DMA BUFFER SHARING FRAMEWORK" <linaro-mm-sig@lists.linaro.org>, "Matthew Auld" <matthew.auld@intel.com>, "Rodrigo Vivi" <rodrigo.vivi@intel.com>, "Christian König" <christian.koenig@amd.com>, "open list:DMA BUFFER SHARING FRAMEWORK" <linux-media@vger.kernel.org> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove __dma_fence_is_chain() Date: Thu, 30 Jun 2022 16:29:39 +0200 [thread overview] Message-ID: <95e834e2-bd6f-efd9-28d2-9e983f9de7ae@intel.com> (raw) In-Reply-To: <20220628233512.439555-1-robdclark@gmail.com> On 29.06.2022 01:35, Rob Clark wrote: > From: Rob Clark <robdclark@chromium.org> > > drive-by cleanup > > Signed-off-by: Rob Clark <robdclark@chromium.org> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Regards Andrzej > --- > drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c > index 319936f91ac5..667841780514 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c > @@ -73,11 +73,6 @@ static void fence_set_priority(struct dma_fence *fence, > rcu_read_unlock(); > } > > -static inline bool __dma_fence_is_chain(const struct dma_fence *fence) > -{ > - return fence->ops == &dma_fence_chain_ops; > -} > - > void i915_gem_fence_wait_priority(struct dma_fence *fence, > const struct i915_sched_attr *attr) > { > @@ -93,7 +88,7 @@ void i915_gem_fence_wait_priority(struct dma_fence *fence, > > for (i = 0; i < array->num_fences; i++) > fence_set_priority(array->fences[i], attr); > - } else if (__dma_fence_is_chain(fence)) { > + } else if (dma_fence_is_chain(fence)) { > struct dma_fence *iter; > > /* The chain is ordered; if we boost the last, we boost all */
WARNING: multiple messages have this Message-ID (diff)
From: Andrzej Hajda <andrzej.hajda@intel.com> To: Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org Cc: "Rob Clark" <robdclark@chromium.org>, "Thomas Hellström" <thomas.hellstrom@linux.intel.com>, "David Airlie" <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, "open list" <linux-kernel@vger.kernel.org>, "Christian König" <christian.koenig@amd.com>, "moderated list:DMA BUFFER SHARING FRAMEWORK" <linaro-mm-sig@lists.linaro.org>, "Matthew Auld" <matthew.auld@intel.com>, "Rodrigo Vivi" <rodrigo.vivi@intel.com>, "Sumit Semwal" <sumit.semwal@linaro.org>, "open list:DMA BUFFER SHARING FRAMEWORK" <linux-media@vger.kernel.org> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove __dma_fence_is_chain() Date: Thu, 30 Jun 2022 16:29:39 +0200 [thread overview] Message-ID: <95e834e2-bd6f-efd9-28d2-9e983f9de7ae@intel.com> (raw) In-Reply-To: <20220628233512.439555-1-robdclark@gmail.com> On 29.06.2022 01:35, Rob Clark wrote: > From: Rob Clark <robdclark@chromium.org> > > drive-by cleanup > > Signed-off-by: Rob Clark <robdclark@chromium.org> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Regards Andrzej > --- > drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c > index 319936f91ac5..667841780514 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c > @@ -73,11 +73,6 @@ static void fence_set_priority(struct dma_fence *fence, > rcu_read_unlock(); > } > > -static inline bool __dma_fence_is_chain(const struct dma_fence *fence) > -{ > - return fence->ops == &dma_fence_chain_ops; > -} > - > void i915_gem_fence_wait_priority(struct dma_fence *fence, > const struct i915_sched_attr *attr) > { > @@ -93,7 +88,7 @@ void i915_gem_fence_wait_priority(struct dma_fence *fence, > > for (i = 0; i < array->num_fences; i++) > fence_set_priority(array->fences[i], attr); > - } else if (__dma_fence_is_chain(fence)) { > + } else if (dma_fence_is_chain(fence)) { > struct dma_fence *iter; > > /* The chain is ordered; if we boost the last, we boost all */
next prev parent reply other threads:[~2022-06-30 14:29 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-28 23:35 [PATCH] drm/i915: Remove __dma_fence_is_chain() Rob Clark 2022-06-28 23:35 ` [Intel-gfx] " Rob Clark 2022-06-28 23:35 ` Rob Clark 2022-06-29 3:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2022-06-29 5:34 ` [Linaro-mm-sig] [PATCH] " Thomas Hellström (Intel) 2022-06-29 5:34 ` [Intel-gfx] " Thomas Hellström (Intel) 2022-06-29 5:34 ` Thomas Hellström (Intel) 2022-06-29 6:57 ` Christian König 2022-06-29 6:57 ` Christian König 2022-06-29 6:57 ` [Intel-gfx] " Christian König 2022-06-29 19:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork 2022-06-30 14:29 ` Andrzej Hajda [this message] 2022-06-30 14:29 ` [Intel-gfx] [PATCH] " Andrzej Hajda
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=95e834e2-bd6f-efd9-28d2-9e983f9de7ae@intel.com \ --to=andrzej.hajda@intel.com \ --cc=airlied@linux.ie \ --cc=christian.koenig@amd.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=linaro-mm-sig@lists.linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=matthew.auld@intel.com \ --cc=robdclark@chromium.org \ --cc=robdclark@gmail.com \ --cc=rodrigo.vivi@intel.com \ --cc=sumit.semwal@linaro.org \ --cc=thomas.hellstrom@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.