From: Chao Yu <yuchao0@huawei.com> To: Jaegeuk Kim <jaegeuk@kernel.org> Cc: <linux-kernel@vger.kernel.org>, <linux-f2fs-devel@lists.sourceforge.net> Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: do not select same victim right again Date: Mon, 9 Sep 2019 19:32:07 +0800 [thread overview] Message-ID: <97237da2-897a-8420-94de-812e94aa751f@huawei.com> (raw) In-Reply-To: <20190909080654.GD21625@jaegeuk-macbookpro.roam.corp.google.com> On 2019/9/9 16:06, Jaegeuk Kim wrote: > On 09/09, Chao Yu wrote: >> On 2019/9/9 9:25, Jaegeuk Kim wrote: >>> GC must avoid select the same victim again. >> >> Blocks in previous victim will occupy addition free segment, I doubt after this >> change, FGGC may encounter out-of-free space issue more frequently. > > Hmm, actually this change seems wrong by sec_usage_check(). > We may be able to avoid this only in the suspicious loop? > > --- > fs/f2fs/gc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index e88f98ddf396..5877bd729689 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -1326,7 +1326,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, > round++; > } > > - if (gc_type == FG_GC) > + if (gc_type == FG_GC && seg_freed) That's original solution Sahitya provided to avoid infinite loop of GC, but I suggest to find the root cause first, then we added .invalid_segmap for that purpose. Thanks, > sbi->cur_victim_sec = NULL_SEGNO; > > if (sync) >
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <yuchao0@huawei.com> To: Jaegeuk Kim <jaegeuk@kernel.org> Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: do not select same victim right again Date: Mon, 9 Sep 2019 19:32:07 +0800 [thread overview] Message-ID: <97237da2-897a-8420-94de-812e94aa751f@huawei.com> (raw) In-Reply-To: <20190909080654.GD21625@jaegeuk-macbookpro.roam.corp.google.com> On 2019/9/9 16:06, Jaegeuk Kim wrote: > On 09/09, Chao Yu wrote: >> On 2019/9/9 9:25, Jaegeuk Kim wrote: >>> GC must avoid select the same victim again. >> >> Blocks in previous victim will occupy addition free segment, I doubt after this >> change, FGGC may encounter out-of-free space issue more frequently. > > Hmm, actually this change seems wrong by sec_usage_check(). > We may be able to avoid this only in the suspicious loop? > > --- > fs/f2fs/gc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index e88f98ddf396..5877bd729689 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -1326,7 +1326,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, > round++; > } > > - if (gc_type == FG_GC) > + if (gc_type == FG_GC && seg_freed) That's original solution Sahitya provided to avoid infinite loop of GC, but I suggest to find the root cause first, then we added .invalid_segmap for that purpose. Thanks, > sbi->cur_victim_sec = NULL_SEGNO; > > if (sync) > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-09-09 11:32 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-09 1:25 [PATCH 1/2] f2fs: do not select same victim right again Jaegeuk Kim 2019-09-09 1:25 ` [f2fs-dev] " Jaegeuk Kim 2019-09-09 1:25 ` [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files Jaegeuk Kim 2019-09-09 1:25 ` [f2fs-dev] " Jaegeuk Kim 2019-09-09 3:03 ` Chao Yu 2019-09-09 3:03 ` Chao Yu 2019-09-09 7:30 ` Jaegeuk Kim 2019-09-09 7:30 ` Jaegeuk Kim 2019-09-09 7:54 ` Chao Yu 2019-09-09 7:54 ` Chao Yu 2019-09-09 8:01 ` Jaegeuk Kim 2019-09-09 8:01 ` Jaegeuk Kim 2019-09-09 8:05 ` Chao Yu 2019-09-09 8:05 ` Chao Yu 2019-09-09 8:21 ` Jaegeuk Kim 2019-09-09 8:21 ` Jaegeuk Kim 2019-09-09 8:27 ` Chao Yu 2019-09-09 8:27 ` Chao Yu 2019-09-09 8:38 ` Jaegeuk Kim 2019-09-09 8:38 ` Jaegeuk Kim 2019-09-09 8:44 ` Jaegeuk Kim 2019-09-09 8:44 ` Jaegeuk Kim 2019-09-09 11:26 ` Chao Yu 2019-09-09 11:26 ` Chao Yu 2019-09-09 14:34 ` Jaegeuk Kim 2019-09-09 14:34 ` Jaegeuk Kim 2019-09-10 0:59 ` Chao Yu 2019-09-10 0:59 ` Chao Yu 2019-09-10 11:58 ` Jaegeuk Kim 2019-09-10 11:58 ` Jaegeuk Kim 2019-09-10 12:04 ` Chao Yu 2019-09-10 12:04 ` Chao Yu 2019-09-10 12:09 ` Jaegeuk Kim 2019-09-10 12:09 ` Jaegeuk Kim 2019-09-16 1:15 ` Chao Yu 2019-09-16 1:15 ` Chao Yu 2019-09-09 2:56 ` [f2fs-dev] [PATCH 1/2] f2fs: do not select same victim right again Chao Yu 2019-09-09 2:56 ` Chao Yu 2019-09-09 8:06 ` Jaegeuk Kim 2019-09-09 8:06 ` Jaegeuk Kim 2019-09-09 11:32 ` Chao Yu [this message] 2019-09-09 11:32 ` Chao Yu 2019-09-09 12:04 ` Jaegeuk Kim 2019-09-09 12:04 ` Jaegeuk Kim 2019-09-16 1:22 ` Chao Yu 2019-09-16 1:22 ` Chao Yu 2019-09-16 15:37 ` Jaegeuk Kim 2019-09-16 15:37 ` Jaegeuk Kim 2019-09-17 1:42 ` Chao Yu 2019-09-17 1:42 ` Chao Yu 2019-09-17 20:55 ` Jaegeuk Kim 2019-09-17 20:55 ` Jaegeuk Kim 2019-09-18 1:43 ` Chao Yu 2019-09-18 1:43 ` Chao Yu 2019-09-18 3:12 ` Jaegeuk Kim 2019-09-18 3:12 ` Jaegeuk Kim 2019-09-18 3:26 ` Chao Yu 2019-09-18 3:26 ` Chao Yu 2019-09-18 16:47 ` Jaegeuk Kim 2019-09-18 16:47 ` Jaegeuk Kim 2019-09-19 0:53 ` Chao Yu 2019-09-19 0:53 ` Chao Yu 2019-09-19 17:11 ` Jaegeuk Kim 2019-09-19 17:11 ` Jaegeuk Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=97237da2-897a-8420-94de-812e94aa751f@huawei.com \ --to=yuchao0@huawei.com \ --cc=jaegeuk@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.