All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhiyong.tao <zhiyong.tao@mediatek.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Chen-Yu Tsai <wenst@chromium.org>,
	Rob Herring <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Sean Wang <sean.wang@kernel.org>,
	srv_heupstream <srv_heupstream@mediatek.com>,
	<hui.liu@mediatek.com>, Eddie Huang <eddie.huang@mediatek.com>,
	Light Hsieh <light.hsieh@mediatek.com>,
	"Biao Huang" <biao.huang@mediatek.com>,
	Hongzhou Yang <hongzhou.yang@mediatek.com>,
	 Sean Wang <sean.wang@mediatek.com>,
	Seiya Wang <seiya.wang@mediatek.com>,
	Devicetree List <devicetree@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v11 4/4] pinctrl: mediatek: add rsel setting on MT8195
Date: Wed, 22 Sep 2021 09:47:46 +0800	[thread overview]
Message-ID: <973137c1330588517592be475e75be75067e66dd.camel@mediatek.com> (raw)
In-Reply-To: <CACRpkdZjqMk_gVpeZ2SqCijuOiiGfPOXHhBOdyL9Y+j750cGsQ@mail.gmail.com>

On Sun, 2021-09-19 at 21:33 +0200, Linus Walleij wrote:
> On Thu, Sep 16, 2021 at 11:31 AM zhiyong.tao <
> zhiyong.tao@mediatek.com> wrote:
> > On Mon, 2021-09-06 at 18:09 +0800, Chen-Yu Tsai wrote:
> > > > > > +       if (!found) {
> > > > > > +               dev_err(hw->dev, "Not support rsel value %d
> > > > > > Ohm
> > > > > > for
> > > > > > pin = %d (%s)\n",
> > > > > > +                       arg, desc->number, desc->name);
> > > > > > +               return -EOPNOTSUPP;
> > > > > 
> > > > > I believe ENOTSUPP is the correct one. EOPNOTSUPP seems to be
> > > > > network
> > > > > related.
> > > > > 
> > > > 
> > > > if we change it as "ENOTSUPP", it will report warning"ENOTSUPP
> > > > is
> > > > not
> > > > SUSV4 error code, prefer EOPNOTSUP" when checking patch.
> > > 
> > > The context surrounding this warning seems to be that ENOTSUPP is
> > > hard
> > > for userspace to understand. AFAIK the return code here does not
> > > get
> > > passed to userspace? And the pinctrl core does check for EINVAL
> > > or
> > > ENOTSUPP, so I think this is a valid use case.
> > > 
> > > Linus?
> > > 
> > 
> > Hi Linus,
> > 
> > Do you have some suggestion for the warning issue?
> 
> Ignore the warning. We use this code in the pinctrl subsystem.
> 
> The pinctrl subsystem has no userspace API so that is certainly
> not a problem.

> Yours,
> Linus Walleij

Thanks for your suggestion,

we will change it in the next version.

Thanks
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: zhiyong.tao <zhiyong.tao@mediatek.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Chen-Yu Tsai <wenst@chromium.org>,
	Rob Herring <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Sean Wang <sean.wang@kernel.org>,
	srv_heupstream <srv_heupstream@mediatek.com>,
	<hui.liu@mediatek.com>, Eddie Huang <eddie.huang@mediatek.com>,
	Light Hsieh <light.hsieh@mediatek.com>,
	"Biao Huang" <biao.huang@mediatek.com>,
	Hongzhou Yang <hongzhou.yang@mediatek.com>,
	 Sean Wang <sean.wang@mediatek.com>,
	Seiya Wang <seiya.wang@mediatek.com>,
	Devicetree List <devicetree@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v11 4/4] pinctrl: mediatek: add rsel setting on MT8195
Date: Wed, 22 Sep 2021 09:47:46 +0800	[thread overview]
Message-ID: <973137c1330588517592be475e75be75067e66dd.camel@mediatek.com> (raw)
In-Reply-To: <CACRpkdZjqMk_gVpeZ2SqCijuOiiGfPOXHhBOdyL9Y+j750cGsQ@mail.gmail.com>

On Sun, 2021-09-19 at 21:33 +0200, Linus Walleij wrote:
> On Thu, Sep 16, 2021 at 11:31 AM zhiyong.tao <
> zhiyong.tao@mediatek.com> wrote:
> > On Mon, 2021-09-06 at 18:09 +0800, Chen-Yu Tsai wrote:
> > > > > > +       if (!found) {
> > > > > > +               dev_err(hw->dev, "Not support rsel value %d
> > > > > > Ohm
> > > > > > for
> > > > > > pin = %d (%s)\n",
> > > > > > +                       arg, desc->number, desc->name);
> > > > > > +               return -EOPNOTSUPP;
> > > > > 
> > > > > I believe ENOTSUPP is the correct one. EOPNOTSUPP seems to be
> > > > > network
> > > > > related.
> > > > > 
> > > > 
> > > > if we change it as "ENOTSUPP", it will report warning"ENOTSUPP
> > > > is
> > > > not
> > > > SUSV4 error code, prefer EOPNOTSUP" when checking patch.
> > > 
> > > The context surrounding this warning seems to be that ENOTSUPP is
> > > hard
> > > for userspace to understand. AFAIK the return code here does not
> > > get
> > > passed to userspace? And the pinctrl core does check for EINVAL
> > > or
> > > ENOTSUPP, so I think this is a valid use case.
> > > 
> > > Linus?
> > > 
> > 
> > Hi Linus,
> > 
> > Do you have some suggestion for the warning issue?
> 
> Ignore the warning. We use this code in the pinctrl subsystem.
> 
> The pinctrl subsystem has no userspace API so that is certainly
> not a problem.

> Yours,
> Linus Walleij

Thanks for your suggestion,

we will change it in the next version.

Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-22  1:52 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30  0:35 [PATCH v11 0/4] Mediatek pinctrl patch on mt8195 Zhiyong Tao
2021-08-30  0:35 ` Zhiyong Tao
2021-08-30  0:35 ` Zhiyong Tao
2021-08-30  0:36 ` [PATCH v11 1/4] dt-bindings: pinctrl: mt8195: add rsel define Zhiyong Tao
2021-08-30  0:36   ` Zhiyong Tao
2021-08-30  0:36   ` Zhiyong Tao
2021-08-31 22:09   ` Rob Herring
2021-08-31 22:09     ` Rob Herring
2021-08-31 22:09     ` Rob Herring
2021-09-01  4:35   ` Chen-Yu Tsai
2021-09-01  4:35     ` Chen-Yu Tsai
2021-09-01  4:35     ` Chen-Yu Tsai
2021-09-02  2:54     ` zhiyong.tao
2021-09-02  2:54       ` zhiyong.tao
2021-09-02  3:35       ` Chen-Yu Tsai
2021-09-02  3:35         ` Chen-Yu Tsai
2021-09-02  3:35         ` Chen-Yu Tsai
2021-09-04  8:40         ` zhiyong.tao
2021-09-04  8:40           ` zhiyong.tao
2021-09-06  8:20           ` Chen-Yu Tsai
2021-09-06  8:20             ` Chen-Yu Tsai
2021-09-06  8:20             ` Chen-Yu Tsai
2021-09-09  6:46             ` zhiyong.tao
2021-09-09  6:46               ` zhiyong.tao
2021-09-14 12:27             ` zhiyong.tao
2021-09-14 12:27               ` zhiyong.tao
2021-09-15  3:25               ` Chen-Yu Tsai
2021-09-15  3:25                 ` Chen-Yu Tsai
2021-09-15  3:25                 ` Chen-Yu Tsai
2021-09-15  5:01                 ` Light Hsieh (謝明燈)
2021-08-30  0:36 ` [PATCH v11 2/4] dt-bindings: pinctrl: mt8195: change pull up/down description Zhiyong Tao
2021-08-30  0:36   ` Zhiyong Tao
2021-08-30  0:36   ` Zhiyong Tao
2021-08-31 22:13   ` Rob Herring
2021-08-31 22:13     ` Rob Herring
2021-08-31 22:13     ` Rob Herring
2021-09-01  2:00     ` zhiyong.tao
2021-09-01  2:00       ` zhiyong.tao
2021-09-01 10:21       ` Chen-Yu Tsai
2021-09-01 10:21         ` Chen-Yu Tsai
2021-09-01 10:21         ` Chen-Yu Tsai
2021-09-02  3:31         ` zhiyong.tao
2021-09-02  3:31           ` zhiyong.tao
2021-08-30  0:36 ` [PATCH v11 3/4] pinctrl: mediatek: mt8195: Add pm_ops Zhiyong Tao
2021-08-30  0:36   ` Zhiyong Tao
2021-08-30  0:36   ` Zhiyong Tao
2021-08-31  7:53   ` Chen-Yu Tsai
2021-08-31  7:53     ` Chen-Yu Tsai
2021-08-31  7:53     ` Chen-Yu Tsai
2021-08-31  9:11     ` zhiyong.tao
2021-08-31  9:11       ` zhiyong.tao
2021-08-30  0:36 ` [PATCH v11 4/4] pinctrl: mediatek: add rsel setting on MT8195 Zhiyong Tao
2021-08-30  0:36   ` Zhiyong Tao
2021-08-30  0:36   ` Zhiyong Tao
2021-08-30  3:33   ` kernel test robot
2021-08-30  3:33     ` kernel test robot
2021-09-01 10:10   ` Chen-Yu Tsai
2021-09-01 10:10     ` Chen-Yu Tsai
2021-09-01 10:10     ` Chen-Yu Tsai
2021-09-06  3:17     ` zhiyong.tao
2021-09-06  3:17       ` zhiyong.tao
2021-09-06 10:09       ` Chen-Yu Tsai
2021-09-06 10:09         ` Chen-Yu Tsai
2021-09-06 10:09         ` Chen-Yu Tsai
2021-09-09  7:46         ` zhiyong.tao
2021-09-09  7:46           ` zhiyong.tao
2021-09-16  9:31         ` zhiyong.tao
2021-09-16  9:31           ` zhiyong.tao
2021-09-16  9:40           ` Chen-Yu Tsai
2021-09-16  9:40             ` Chen-Yu Tsai
2021-09-16  9:40             ` Chen-Yu Tsai
2021-09-17  2:10             ` zhiyong.tao
2021-09-17  2:10               ` zhiyong.tao
2021-09-19 19:33           ` Linus Walleij
2021-09-19 19:33             ` Linus Walleij
2021-09-19 19:33             ` Linus Walleij
2021-09-22  1:47             ` zhiyong.tao [this message]
2021-09-22  1:47               ` zhiyong.tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=973137c1330588517592be475e75be75067e66dd.camel@mediatek.com \
    --to=zhiyong.tao@mediatek.com \
    --cc=biao.huang@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eddie.huang@mediatek.com \
    --cc=hongzhou.yang@mediatek.com \
    --cc=hui.liu@mediatek.com \
    --cc=light.hsieh@mediatek.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sean.wang@kernel.org \
    --cc=sean.wang@mediatek.com \
    --cc=seiya.wang@mediatek.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.