All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <gmazyland@gmail.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
Cc: Horia Geanta <horia.geanta@nxp.com>,
	Milan Broz <gmazyland@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [dm-devel] xts fuzz testing and lack of ciphertext stealing support
Date: Sat, 27 Jul 2019 18:04:32 +0200	[thread overview]
Message-ID: <97532fae-4c17-bb8f-d245-04bf97cef4d1@gmail.com> (raw)
In-Reply-To: <CAKv+Gu9krpqWYuD2mQFBTspo3y_TwrN6Arbvkcs=e4MpTeitHA@mail.gmail.com>

On 27/07/2019 07:39, Ard Biesheuvel wrote:
> Thanks for the additional test vectors. They work fine with my SIMD
> implementations for ARM [0], so this looks like it might be a CAAM
> problem, not a problem with the test vectors.
> 
> I will try to find some time today to run them through OpenSSL to double check.

I shamelessly copied your test vectors to my vector test for cryptsetup backend.

Both OpenSSL and gcrypt XTS implementation passed all tests here!

If interested - this is copy of backend we have in cryptsetup, vectors added in crypto-vectors.c
(there are some hard defines in Makefile, cryptsetup uses autoconf instead).
  OpenSSL: https://github.com/mbroz/cryptsetup_backend_test
  gcrypt branch: https://github.com/mbroz/cryptsetup_backend_test/tree/gcrypt

Once kernel AF_ALG supports it, I can easily test it the same way.

Thanks,
Milan

WARNING: multiple messages have this Message-ID (diff)
From: Milan Broz <gmazyland@gmail.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>,
	Milan Broz <gmazyland@gmail.com>,
	Horia Geanta <horia.geanta@nxp.com>,
	Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: xts fuzz testing and lack of ciphertext stealing support
Date: Sat, 27 Jul 2019 18:04:32 +0200	[thread overview]
Message-ID: <97532fae-4c17-bb8f-d245-04bf97cef4d1@gmail.com> (raw)
In-Reply-To: <CAKv+Gu9krpqWYuD2mQFBTspo3y_TwrN6Arbvkcs=e4MpTeitHA@mail.gmail.com>

On 27/07/2019 07:39, Ard Biesheuvel wrote:
> Thanks for the additional test vectors. They work fine with my SIMD
> implementations for ARM [0], so this looks like it might be a CAAM
> problem, not a problem with the test vectors.
> 
> I will try to find some time today to run them through OpenSSL to double check.

I shamelessly copied your test vectors to my vector test for cryptsetup backend.

Both OpenSSL and gcrypt XTS implementation passed all tests here!

If interested - this is copy of backend we have in cryptsetup, vectors added in crypto-vectors.c
(there are some hard defines in Makefile, cryptsetup uses autoconf instead).
  OpenSSL: https://github.com/mbroz/cryptsetup_backend_test
  gcrypt branch: https://github.com/mbroz/cryptsetup_backend_test/tree/gcrypt

Once kernel AF_ALG supports it, I can easily test it the same way.

Thanks,
Milan

  parent reply	other threads:[~2019-07-27 16:04 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-16 17:46 xts fuzz testing and lack of ciphertext stealing support Horia Geanta
2019-07-16 22:16 ` Eric Biggers
2019-07-17 17:09   ` Horia Geanta
2019-07-17 17:09     ` Horia Geanta
2019-07-17 17:28     ` Eric Biggers
2019-07-17 17:28       ` Eric Biggers
2019-07-17 18:08       ` Ard Biesheuvel
2019-07-18  6:52         ` Herbert Xu
2019-07-18  6:52           ` Herbert Xu
2019-07-18  7:15           ` Ard Biesheuvel
2019-07-18  7:15             ` Ard Biesheuvel
2019-07-18  7:21             ` Herbert Xu
2019-07-18  7:21               ` Herbert Xu
2019-07-18  7:28               ` Ard Biesheuvel
2019-07-18  7:28                 ` Ard Biesheuvel
2019-07-18  7:50                 ` Herbert Xu
2019-07-18  7:50                   ` Herbert Xu
2019-07-18  7:40               ` Milan Broz
2019-07-18  7:40                 ` Milan Broz
2019-07-18 10:40                 ` Pascal Van Leeuwen
2019-07-18 11:19                   ` Milan Broz
2019-07-18 11:19                     ` Milan Broz
2019-07-18 15:27                     ` Herbert Xu
2019-07-18 15:27                       ` Herbert Xu
2019-07-20  6:58                     ` [dm-devel] " Eric Biggers
2019-07-20  6:58                       ` Eric Biggers
2019-07-20  7:35                       ` [dm-devel] " Milan Broz
2019-07-20  7:35                         ` Milan Broz
2019-07-20 10:13                         ` Markus
2019-07-21  9:50                         ` [dm-devel] " Ard Biesheuvel
2019-07-21  9:50                           ` Ard Biesheuvel
2019-07-22  9:44                           ` [dm-devel] " Pascal Van Leeuwen
2019-07-22 16:43                             ` Ard Biesheuvel
2019-07-22 16:43                               ` Ard Biesheuvel
2019-07-22 22:46                               ` [dm-devel] " Pascal Van Leeuwen
2019-07-24 12:23                               ` Pascal Van Leeuwen
2019-07-24 12:50                                 ` Pascal Van Leeuwen
2019-07-24 16:10                               ` Pascal Van Leeuwen
2019-07-25  6:22                                 ` Ard Biesheuvel
2019-07-25  6:22                                   ` Ard Biesheuvel
2019-07-25  7:49                                   ` [dm-devel] " Pascal Van Leeuwen
2019-07-25  8:01                                     ` Ard Biesheuvel
2019-07-25  8:01                                       ` Ard Biesheuvel
2019-07-26 10:31                                       ` [dm-devel] " Pascal Van Leeuwen
2019-07-26 19:59                                         ` Horia Geanta
2019-07-26 19:59                                           ` Horia Geanta
2019-07-26 21:43                                           ` [dm-devel] " Pascal Van Leeuwen
2019-07-27  5:39                                             ` Ard Biesheuvel
2019-07-27  5:39                                               ` Ard Biesheuvel
2019-07-27 12:56                                               ` [dm-devel] " Pascal Van Leeuwen
2019-07-27 16:04                                               ` Milan Broz [this message]
2019-07-27 16:04                                                 ` Milan Broz
2019-08-04  8:36                                                 ` [dm-devel] " Ard Biesheuvel
2019-08-04  8:36                                                   ` Ard Biesheuvel
     [not found]                                         ` <20f4832e-e3af-e3c2-d946-13bf8c367a60@nxp.com>
2019-08-07 15:51                                           ` [dm-devel] " Horia Geanta
2019-08-07 15:51                                             ` Horia Geanta
2019-08-07 20:57                                             ` [dm-devel] " Pascal Van Leeuwen
2019-08-08 14:50                                               ` Horia Geanta
2019-08-08 14:50                                                 ` Horia Geanta
2019-08-09  8:35                                                 ` [dm-devel] " Pascal Van Leeuwen
2019-08-08 13:43                                             ` Pascal Van Leeuwen
2019-08-08 18:01                                               ` Horia Geanta
2019-08-08 18:01                                                 ` Horia Geanta
2019-08-09  2:48                                                 ` [dm-devel] " Herbert Xu
2019-08-09  2:48                                                   ` Herbert Xu
2019-08-09  6:45                                                   ` [dm-devel] " Ard Biesheuvel
2019-08-09  6:45                                                     ` Ard Biesheuvel
2019-08-09  7:44                                                     ` [dm-devel] " Horia Geanta
2019-08-09  7:44                                                       ` Horia Geanta
2019-08-09 17:49                                                       ` [dm-devel] " Ard Biesheuvel
2019-08-09 17:49                                                         ` Ard Biesheuvel
2019-08-09 20:57                                                         ` [dm-devel] " Pascal Van Leeuwen
2019-08-10  4:39                                                           ` Ard Biesheuvel
2019-08-10  4:39                                                             ` Ard Biesheuvel
2019-08-11 11:12                                                             ` [dm-devel] " Milan Broz
2019-08-11 11:12                                                               ` Milan Broz
2019-08-11 20:34                                                               ` [dm-devel] " Eric Biggers
2019-08-11 20:34                                                                 ` Eric Biggers
2019-08-11 21:39                                                                 ` [dm-devel] " Pascal Van Leeuwen
2019-08-11 21:29                                                               ` Pascal Van Leeuwen
2019-08-12  4:51                                                                 ` Herbert Xu
2019-08-12  4:51                                                                   ` Herbert Xu
2019-08-11 21:15                                                             ` [dm-devel] " Pascal Van Leeuwen
2019-08-11 22:24                                                               ` Ard Biesheuvel
2019-08-11 22:24                                                                 ` Ard Biesheuvel
2019-08-12  1:04                                                                 ` [dm-devel] " Pascal Van Leeuwen
2019-07-18 15:29                   ` Herbert Xu
2019-07-18 15:29                     ` Herbert Xu
2019-07-18 15:43                     ` Pascal Van Leeuwen
2019-07-18 15:51                       ` Herbert Xu
2019-07-18 15:51                         ` Herbert Xu
2019-07-18 16:19                         ` Ard Biesheuvel
2019-07-18 16:19                           ` Ard Biesheuvel
2019-07-18 16:22                           ` Herbert Xu
2019-07-18 16:22                             ` Herbert Xu
2019-07-18 17:03                           ` Pascal Van Leeuwen
2019-07-19  5:34                             ` Ard Biesheuvel
2019-07-19  5:34                               ` Ard Biesheuvel
2019-07-19  7:29                               ` Pascal Van Leeuwen
2019-07-19 17:14                                 ` Ard Biesheuvel
2019-07-19 17:14                                   ` Ard Biesheuvel
2019-07-19 20:07                                   ` Pascal Van Leeuwen
2019-07-19  7:29                               ` Pascal Van Leeuwen
2019-07-18 17:03                           ` Pascal Van Leeuwen
2019-07-18 16:35                         ` Pascal Van Leeuwen
2019-07-19  1:47                           ` Herbert Xu
2019-07-19  1:47                             ` Herbert Xu
2019-07-18 16:35                         ` Pascal Van Leeuwen
2019-07-18 15:43                     ` Pascal Van Leeuwen
2019-07-18 10:40                 ` Pascal Van Leeuwen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97532fae-4c17-bb8f-d245-04bf97cef4d1@gmail.com \
    --to=gmazyland@gmail.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=dm-devel@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@nxp.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=pvanleeuwen@verimatrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.