* [PATCH yocto-autobuilder-helper] scripts/run-docs-build: remove gatesgarth
@ 2021-11-24 17:16 Michael Opdenacker
2021-11-24 18:10 ` [docs] " Richard Purdie
0 siblings, 1 reply; 6+ messages in thread
From: Michael Opdenacker @ 2021-11-24 17:16 UTC (permalink / raw)
To: yocto; +Cc: docs, Michael Opdenacker
Together with the corresponding Bitbake version, which are no
longer supported.
Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
---
scripts/run-docs-build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/run-docs-build b/scripts/run-docs-build
index 3db4a97..5e1d649 100755
--- a/scripts/run-docs-build
+++ b/scripts/run-docs-build
@@ -35,7 +35,7 @@ mkdir $outputdir/bitbake/next
cp -r ./_build/final/* $outputdir/bitbake/next
# stable branches
-for branch in 1.46 1.48 1.50 1.52; do
+for branch in 1.46 1.50 1.52; do
git checkout $branch
make clean
make publish
@@ -68,7 +68,7 @@ mkdir $outputdir/next
cp -r ./_build/final/* $outputdir/next
# stable branches
-for branch in dunfell gatesgarth hardknott honister; do
+for branch in dunfell hardknott honister; do
cd $ypdocs
git checkout $branch
make clean
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [docs] [PATCH yocto-autobuilder-helper] scripts/run-docs-build: remove gatesgarth
2021-11-24 17:16 [PATCH yocto-autobuilder-helper] scripts/run-docs-build: remove gatesgarth Michael Opdenacker
@ 2021-11-24 18:10 ` Richard Purdie
2021-11-24 18:45 ` [yocto] " Michael Opdenacker
2021-11-24 18:47 ` Quentin Schulz
0 siblings, 2 replies; 6+ messages in thread
From: Richard Purdie @ 2021-11-24 18:10 UTC (permalink / raw)
To: Michael Opdenacker, yocto; +Cc: docs
On Wed, 2021-11-24 at 18:16 +0100, Michael Opdenacker wrote:
> Together with the corresponding Bitbake version, which are no
> longer supported.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> ---
> scripts/run-docs-build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/run-docs-build b/scripts/run-docs-build
> index 3db4a97..5e1d649 100755
> --- a/scripts/run-docs-build
> +++ b/scripts/run-docs-build
> @@ -35,7 +35,7 @@ mkdir $outputdir/bitbake/next
> cp -r ./_build/final/* $outputdir/bitbake/next
>
> # stable branches
> -for branch in 1.46 1.48 1.50 1.52; do
> +for branch in 1.46 1.50 1.52; do
> git checkout $branch
> make clean
> make publish
> @@ -68,7 +68,7 @@ mkdir $outputdir/next
> cp -r ./_build/final/* $outputdir/next
>
> # stable branches
> -for branch in dunfell gatesgarth hardknott honister; do
> +for branch in dunfell hardknott honister; do
> cd $ypdocs
> git checkout $branch
> make clean
I'm a bit torn on this. They are no longer officially supported releases now but
it may make sense to rebuild all the sphinx docs in this script rather than some
subset?
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [yocto] [docs] [PATCH yocto-autobuilder-helper] scripts/run-docs-build: remove gatesgarth
2021-11-24 18:10 ` [docs] " Richard Purdie
@ 2021-11-24 18:45 ` Michael Opdenacker
2021-11-24 18:47 ` Quentin Schulz
1 sibling, 0 replies; 6+ messages in thread
From: Michael Opdenacker @ 2021-11-24 18:45 UTC (permalink / raw)
To: Richard Purdie, yocto; +Cc: docs
Hi Richard,
Thanks for the review!
On 11/24/21 7:10 PM, Richard Purdie wrote:
> On Wed, 2021-11-24 at 18:16 +0100, Michael Opdenacker wrote:
>> Together with the corresponding Bitbake version, which are no
>> longer supported.
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
>> ---
>> scripts/run-docs-build | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/run-docs-build b/scripts/run-docs-build
>> index 3db4a97..5e1d649 100755
>> --- a/scripts/run-docs-build
>> +++ b/scripts/run-docs-build
>> @@ -35,7 +35,7 @@ mkdir $outputdir/bitbake/next
>> cp -r ./_build/final/* $outputdir/bitbake/next
>>
>> # stable branches
>> -for branch in 1.46 1.48 1.50 1.52; do
>> +for branch in 1.46 1.50 1.52; do
>> git checkout $branch
>> make clean
>> make publish
>> @@ -68,7 +68,7 @@ mkdir $outputdir/next
>> cp -r ./_build/final/* $outputdir/next
>>
>> # stable branches
>> -for branch in dunfell gatesgarth hardknott honister; do
>> +for branch in dunfell hardknott honister; do
>> cd $ypdocs
>> git checkout $branch
>> make clean
> I'm a bit torn on this. They are no longer officially supported releases now but
> it may make sense to rebuild all the sphinx docs in this script rather than some
> subset?
I understand. Your decision to make.
I just proposed this change for consistency with the current implementation.
Any other opinions?
Cheers
Michael.
--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [docs] [PATCH yocto-autobuilder-helper] scripts/run-docs-build: remove gatesgarth
2021-11-24 18:10 ` [docs] " Richard Purdie
2021-11-24 18:45 ` [yocto] " Michael Opdenacker
@ 2021-11-24 18:47 ` Quentin Schulz
2021-11-24 18:50 ` Michael Opdenacker
1 sibling, 1 reply; 6+ messages in thread
From: Quentin Schulz @ 2021-11-24 18:47 UTC (permalink / raw)
To: Richard Purdie; +Cc: Michael Opdenacker, yocto, docs
Hi Michael, Richard,
On Wed, Nov 24, 2021 at 06:10:56PM +0000, Richard Purdie wrote:
> On Wed, 2021-11-24 at 18:16 +0100, Michael Opdenacker wrote:
> > Together with the corresponding Bitbake version, which are no
> > longer supported.
> >
> > Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> > ---
> > scripts/run-docs-build | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/scripts/run-docs-build b/scripts/run-docs-build
> > index 3db4a97..5e1d649 100755
> > --- a/scripts/run-docs-build
> > +++ b/scripts/run-docs-build
> > @@ -35,7 +35,7 @@ mkdir $outputdir/bitbake/next
> > cp -r ./_build/final/* $outputdir/bitbake/next
> >
> > # stable branches
> > -for branch in 1.46 1.48 1.50 1.52; do
> > +for branch in 1.46 1.50 1.52; do
> > git checkout $branch
> > make clean
> > make publish
> > @@ -68,7 +68,7 @@ mkdir $outputdir/next
> > cp -r ./_build/final/* $outputdir/next
> >
> > # stable branches
> > -for branch in dunfell gatesgarth hardknott honister; do
> > +for branch in dunfell hardknott honister; do
> > cd $ypdocs
> > git checkout $branch
> > make clean
>
> I'm a bit torn on this. They are no longer officially supported releases now but
> it may make sense to rebuild all the sphinx docs in this script rather than some
> subset?
>
I think we want to make sure we have all docs up-to-date, even for the
branches that aren't maintained anymore. Especially since it's not
taking a lot of CPU time to build them, it's fine IMO. We could always
make minor changes to old docs. E.g. the releases.rst might get updates
until we figure something out.
Cheers,
Quentin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [docs] [PATCH yocto-autobuilder-helper] scripts/run-docs-build: remove gatesgarth
2021-11-24 18:47 ` Quentin Schulz
@ 2021-11-24 18:50 ` Michael Opdenacker
2021-11-25 8:42 ` Nicolas Dechesne
0 siblings, 1 reply; 6+ messages in thread
From: Michael Opdenacker @ 2021-11-24 18:50 UTC (permalink / raw)
To: Quentin Schulz, Richard Purdie; +Cc: yocto, docs
Hi Quentin,
On 11/24/21 7:47 PM, Quentin Schulz wrote:
> Hi Michael, Richard,
>
> On Wed, Nov 24, 2021 at 06:10:56PM +0000, Richard Purdie wrote:
>> On Wed, 2021-11-24 at 18:16 +0100, Michael Opdenacker wrote:
>>> Together with the corresponding Bitbake version, which are no
>>> longer supported.
>>>
>>> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
>>> ---
>>> scripts/run-docs-build | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/scripts/run-docs-build b/scripts/run-docs-build
>>> index 3db4a97..5e1d649 100755
>>> --- a/scripts/run-docs-build
>>> +++ b/scripts/run-docs-build
>>> @@ -35,7 +35,7 @@ mkdir $outputdir/bitbake/next
>>> cp -r ./_build/final/* $outputdir/bitbake/next
>>>
>>> # stable branches
>>> -for branch in 1.46 1.48 1.50 1.52; do
>>> +for branch in 1.46 1.50 1.52; do
>>> git checkout $branch
>>> make clean
>>> make publish
>>> @@ -68,7 +68,7 @@ mkdir $outputdir/next
>>> cp -r ./_build/final/* $outputdir/next
>>>
>>> # stable branches
>>> -for branch in dunfell gatesgarth hardknott honister; do
>>> +for branch in dunfell hardknott honister; do
>>> cd $ypdocs
>>> git checkout $branch
>>> make clean
>> I'm a bit torn on this. They are no longer officially supported releases now but
>> it may make sense to rebuild all the sphinx docs in this script rather than some
>> subset?
>>
> I think we want to make sure we have all docs up-to-date, even for the
> branches that aren't maintained anymore. Especially since it's not
> taking a lot of CPU time to build them, it's fine IMO. We could always
> make minor changes to old docs. E.g. the releases.rst might get updates
> until we figure something out.
Thanks for casting your vote. It makes sense. I'll send another patch
with this decision in the comments.
Cheers
Michael.
--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [docs] [PATCH yocto-autobuilder-helper] scripts/run-docs-build: remove gatesgarth
2021-11-24 18:50 ` Michael Opdenacker
@ 2021-11-25 8:42 ` Nicolas Dechesne
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Dechesne @ 2021-11-25 8:42 UTC (permalink / raw)
To: Michael Opdenacker; +Cc: Quentin Schulz, Richard Purdie, yocto, docs
[-- Attachment #1: Type: text/plain, Size: 2728 bytes --]
On Wed, Nov 24, 2021 at 7:50 PM Michael Opdenacker <
michael.opdenacker@bootlin.com> wrote:
> Hi Quentin,
>
> On 11/24/21 7:47 PM, Quentin Schulz wrote:
> > Hi Michael, Richard,
> >
> > On Wed, Nov 24, 2021 at 06:10:56PM +0000, Richard Purdie wrote:
> >> On Wed, 2021-11-24 at 18:16 +0100, Michael Opdenacker wrote:
> >>> Together with the corresponding Bitbake version, which are no
> >>> longer supported.
> >>>
> >>> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> >>> ---
> >>> scripts/run-docs-build | 4 ++--
> >>> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/scripts/run-docs-build b/scripts/run-docs-build
> >>> index 3db4a97..5e1d649 100755
> >>> --- a/scripts/run-docs-build
> >>> +++ b/scripts/run-docs-build
> >>> @@ -35,7 +35,7 @@ mkdir $outputdir/bitbake/next
> >>> cp -r ./_build/final/* $outputdir/bitbake/next
> >>>
> >>> # stable branches
> >>> -for branch in 1.46 1.48 1.50 1.52; do
> >>> +for branch in 1.46 1.50 1.52; do
> >>> git checkout $branch
> >>> make clean
> >>> make publish
> >>> @@ -68,7 +68,7 @@ mkdir $outputdir/next
> >>> cp -r ./_build/final/* $outputdir/next
> >>>
> >>> # stable branches
> >>> -for branch in dunfell gatesgarth hardknott honister; do
> >>> +for branch in dunfell hardknott honister; do
> >>> cd $ypdocs
> >>> git checkout $branch
> >>> make clean
> >> I'm a bit torn on this. They are no longer officially supported
> releases now but
> >> it may make sense to rebuild all the sphinx docs in this script rather
> than some
> >> subset?
> >>
> > I think we want to make sure we have all docs up-to-date, even for the
> > branches that aren't maintained anymore. Especially since it's not
> > taking a lot of CPU time to build them, it's fine IMO. We could always
> > make minor changes to old docs. E.g. the releases.rst might get updates
> > until we figure something out.
>
> Thanks for casting your vote. It makes sense. I'll send another patch
> with this decision in the comments.
>
I agree with Quentin here. Until we have a better mechanism (to rebuild
only modified branches not all of them each time, ..) I think we should
continue to build them all.
> Cheers
> Michael.
>
> --
> Michael Opdenacker, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#2196):
> https://lists.yoctoproject.org/g/docs/message/2196
> Mute This Topic: https://lists.yoctoproject.org/mt/87285736/1279857
> Group Owner: docs+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/docs/unsub [
> nicolas.dechesne@linaro.org]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
[-- Attachment #2: Type: text/html, Size: 4345 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-25 8:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-24 17:16 [PATCH yocto-autobuilder-helper] scripts/run-docs-build: remove gatesgarth Michael Opdenacker
2021-11-24 18:10 ` [docs] " Richard Purdie
2021-11-24 18:45 ` [yocto] " Michael Opdenacker
2021-11-24 18:47 ` Quentin Schulz
2021-11-24 18:50 ` Michael Opdenacker
2021-11-25 8:42 ` Nicolas Dechesne
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.