Re: [PATCH 3/8] drm/amdgpu:Add DPG support flag

[James Zhu <jamesz-5C7GfCeVMHo@public.gmane.org>]

On 2018-09-26 04:02 AM, Christian König wrote:
> Am 25.09.2018 um 21:55 schrieb James Zhu:
>> Add DPG support flag for VCN DPG mode.
>>
>> Signed-off-by: James Zhu <James.Zhu@amd.com>
>> ---
>>   drivers/gpu/drm/amd/include/amd_shared.h | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/include/amd_shared.h 
>> b/drivers/gpu/drm/amd/include/amd_shared.h
>> index 86b167e..2f6bdf1 100644
>> --- a/drivers/gpu/drm/amd/include/amd_shared.h
>> +++ b/drivers/gpu/drm/amd/include/amd_shared.h
>> @@ -110,6 +110,8 @@ enum amd_powergating_state {
>>   #define AMD_PG_SUPPORT_MMHUB            (1 << 13)
>>   #define AMD_PG_SUPPORT_VCN            (1 << 14)
>
> Looks like you added an extra empty line between AMD_PG_SUPPORT_VCN 
> and the new entry, was that intentional?
Already fixed with Alex's comments.
James
>
> Apart from that the patches look good to me, but can't judge if that 
> is really correct.
>
> Acked-by: Christian König <christian.koenig@amd.com> for the series.
>
> Regards,
> Christian.
>
>> +#define AMD_PG_SUPPORT_DPG            (1 << 15)
>> +
>>   enum PP_FEATURE_MASK {
>>       PP_SCLK_DPM_MASK = 0x1,
>>       PP_MCLK_DPM_MASK = 0x2,
>

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx