From: abhinavk@codeaurora.org To: Rob Clark <robdclark@gmail.com> Cc: dri-devel@lists.freedesktop.org, Rob Clark <robdclark@chromium.org>, Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Jordan Crouse <jcrouse@codeaurora.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Jonathan Marek <jonathan@marek.ca>, Brian Masney <masneyb@onstation.org>, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/msm: fix 32b build warns Date: Mon, 28 Sep 2020 17:31:06 -0700 [thread overview] Message-ID: <99486d8eae2223bc5131c56accca1444@codeaurora.org> (raw) In-Reply-To: <20200929001925.2916984-1-robdclark@gmail.com> On 2020-09-28 17:19, Rob Clark wrote: > From: Rob Clark <robdclark@chromium.org> > > Neither of these code-paths apply to older 32b devices, but it is rude > to introduce warnings. > > Signed-off-by: Rob Clark <robdclark@chromium.org> Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org> > --- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- > drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > index fd8f491f2e48..458b5b26d3c2 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > @@ -209,7 +209,7 @@ adreno_iommu_create_address_space(struct msm_gpu > *gpu, > size = iommu->geometry.aperture_end - start + 1; > > aspace = msm_gem_address_space_create(mmu, "gpu", > - start & GENMASK(48, 0), size); > + start & GENMASK_ULL(48, 0), size); > > if (IS_ERR(aspace) && !IS_ERR(mmu)) > mmu->funcs->destroy(mmu); > diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c > b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c > index 029cc8bf5a04..de0dfb815125 100644 > --- a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c > +++ b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c > @@ -879,7 +879,7 @@ struct msm_dsi_pll *msm_dsi_pll_7nm_init(struct > platform_device *pdev, int id) > pll->max_rate = 3500000000UL; > if (pll->type == MSM_DSI_PHY_7NM_V4_1) { > pll->min_rate = 600000000UL; > - pll->max_rate = 5000000000UL; > + pll->max_rate = (unsigned long)5000000000ULL; > /* workaround for max rate overflowing on 32-bit builds: */ > pll->max_rate = max(pll->max_rate, 0xffffffffUL); > }
WARNING: multiple messages have this Message-ID (diff)
From: abhinavk@codeaurora.org To: Rob Clark <robdclark@gmail.com> Cc: Rob Clark <robdclark@chromium.org>, freedreno@lists.freedesktop.org, Jonathan Marek <jonathan@marek.ca>, David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bjorn Andersson <bjorn.andersson@linaro.org>, Sean Paul <sean@poorly.run>, Brian Masney <masneyb@onstation.org> Subject: Re: [PATCH] drm/msm: fix 32b build warns Date: Mon, 28 Sep 2020 17:31:06 -0700 [thread overview] Message-ID: <99486d8eae2223bc5131c56accca1444@codeaurora.org> (raw) In-Reply-To: <20200929001925.2916984-1-robdclark@gmail.com> On 2020-09-28 17:19, Rob Clark wrote: > From: Rob Clark <robdclark@chromium.org> > > Neither of these code-paths apply to older 32b devices, but it is rude > to introduce warnings. > > Signed-off-by: Rob Clark <robdclark@chromium.org> Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org> > --- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- > drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > index fd8f491f2e48..458b5b26d3c2 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > @@ -209,7 +209,7 @@ adreno_iommu_create_address_space(struct msm_gpu > *gpu, > size = iommu->geometry.aperture_end - start + 1; > > aspace = msm_gem_address_space_create(mmu, "gpu", > - start & GENMASK(48, 0), size); > + start & GENMASK_ULL(48, 0), size); > > if (IS_ERR(aspace) && !IS_ERR(mmu)) > mmu->funcs->destroy(mmu); > diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c > b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c > index 029cc8bf5a04..de0dfb815125 100644 > --- a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c > +++ b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_7nm.c > @@ -879,7 +879,7 @@ struct msm_dsi_pll *msm_dsi_pll_7nm_init(struct > platform_device *pdev, int id) > pll->max_rate = 3500000000UL; > if (pll->type == MSM_DSI_PHY_7NM_V4_1) { > pll->min_rate = 600000000UL; > - pll->max_rate = 5000000000UL; > + pll->max_rate = (unsigned long)5000000000ULL; > /* workaround for max rate overflowing on 32-bit builds: */ > pll->max_rate = max(pll->max_rate, 0xffffffffUL); > } _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-09-29 0:31 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-29 0:19 [PATCH] drm/msm: fix 32b build warns Rob Clark 2020-09-29 0:19 ` Rob Clark 2020-09-29 0:31 ` abhinavk [this message] 2020-09-29 0:31 ` abhinavk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=99486d8eae2223bc5131c56accca1444@codeaurora.org \ --to=abhinavk@codeaurora.org \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=jcrouse@codeaurora.org \ --cc=jonathan@marek.ca \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=masneyb@onstation.org \ --cc=robdclark@chromium.org \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.