All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [RFC 4/4] drm/i915: Expose RPCS (SSEU) configuration to userspace
Date: Tue, 11 Jul 2017 18:14:16 +0100	[thread overview]
Message-ID: <9b222410-7644-0692-e716-5f328909c024@intel.com> (raw)
In-Reply-To: <20170502114942.2703-4-chris@chris-wilson.co.uk>

On 02/05/17 12:49, Chris Wilson wrote:
> +
> +union drm_i915_gem_context_param_sseu {
> +	struct {
> +		u8 slice_mask;
> +		u8 subslice_mask;
> +		u8 min_eu_per_subslice;
> +		u8 max_eu_per_subslice;
> +	} packed;
>   	__u64 value;
>   };

I think we should probably rename slice_mask & subslice_mask and 
anywhere in the kernel as well.
Those aren't actually masks but numbers (ie number of slices/subslices 
on/off). It doesn't look like we can actually control which ones are on 
or off.

-
Lionel

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-07-11 17:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-02 11:49 [RFC 1/4] drm/i915: Record both min/max eu_per_subslice in sseu_dev_info Chris Wilson
2017-05-02 11:49 ` [RFC 2/4] drm/i915: Program RPCS for Broadwell Chris Wilson
2017-05-02 12:22   ` Joonas Lahtinen
2017-05-02 19:32   ` Lionel Landwerlin
2017-05-02 11:49 ` [RFC 3/4] drm/i915: Record the sseu configuration per-context Chris Wilson
2017-05-02 11:49 ` [RFC 4/4] drm/i915: Expose RPCS (SSEU) configuration to userspace Chris Wilson
2017-05-02 10:33   ` Oscar Mateo
2017-05-02 19:55     ` Chris Wilson
2017-05-02 15:00       ` Oscar Mateo
2017-05-09  9:52   ` Lionel Landwerlin
2017-07-11 17:14   ` Lionel Landwerlin [this message]
2017-05-02 12:08 ` ✓ Fi.CI.BAT: success for series starting with [RFC,1/4] drm/i915: Record both min/max eu_per_subslice in sseu_dev_info Patchwork
2017-05-02 12:13 ` [RFC 1/4] " Joonas Lahtinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b222410-7644-0692-e716-5f328909c024@intel.com \
    --to=lionel.g.landwerlin@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.