From: John Hubbard <jhubbard@nvidia.com> To: <jglisse@redhat.com>, <linux-mm@kvack.org> Cc: Andrew Morton <akpm@linux-foundation.org>, <linux-kernel@vger.kernel.org>, Evgeny Baskakov <ebaskakov@nvidia.com>, Ralph Campbell <rcampbell@nvidia.com>, Mark Hairgrove <mhairgrove@nvidia.com> Subject: Re: [PATCH 05/14] mm/hmm: use struct for hmm_vma_fault(), hmm_vma_get_pfns() parameters Date: Fri, 16 Mar 2018 20:08:11 -0700 [thread overview] Message-ID: <9b8ad818-252d-e1f2-0cdb-a7228ccaa392@nvidia.com> (raw) In-Reply-To: <20180316191414.3223-6-jglisse@redhat.com> On 03/16/2018 12:14 PM, jglisse@redhat.com wrote: > From: Jérôme Glisse <jglisse@redhat.com> > Hi Jerome, I failed to find any problems in this patch, so: Reviewed-by: John Hubbard <jhubbard@nvidia.com> There are a couple of documentation recommended typo fixes listed below, which are very minor but as long as I'm here I'll point them out. > Both hmm_vma_fault() and hmm_vma_get_pfns() were taking a hmm_range > struct as parameter and were initializing that struct with others of > their parameters. Have caller of those function do this as they are > likely to already do and only pass this struct to both function this > shorten function signature and make it easiers in the future to add easier > new parameters by simply adding them to the structure. > > Signed-off-by: Jérôme Glisse <jglisse@redhat.com> > Cc: Evgeny Baskakov <ebaskakov@nvidia.com> > Cc: Ralph Campbell <rcampbell@nvidia.com> > Cc: Mark Hairgrove <mhairgrove@nvidia.com> > Cc: John Hubbard <jhubbard@nvidia.com> > --- > include/linux/hmm.h | 18 ++++--------- > mm/hmm.c | 78 +++++++++++++++++++---------------------------------- > 2 files changed, 33 insertions(+), 63 deletions(-) <snip> > > > diff --git a/mm/hmm.c b/mm/hmm.c > index 64d9e7dae712..49f0f6b337ed 100644 > --- a/mm/hmm.c > +++ b/mm/hmm.c > @@ -490,11 +490,7 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp, > > /* > * hmm_vma_get_pfns() - snapshot CPU page table for a range of virtual addresses > - * @vma: virtual memory area containing the virtual address range > - * @range: used to track snapshot validity > - * @start: range virtual start address (inclusive) > - * @end: range virtual end address (exclusive) > - * @entries: array of hmm_pfn_t: provided by the caller, filled in by function > + * @range: range being snapshoted and all needed informations Let's just say this: * @range: range being snapshotted <snip> > @@ -628,11 +617,7 @@ EXPORT_SYMBOL(hmm_vma_range_done); > > /* > * hmm_vma_fault() - try to fault some address in a virtual address range > - * @vma: virtual memory area containing the virtual address range > - * @range: use to track pfns array content validity > - * @start: fault range virtual start address (inclusive) > - * @end: fault range virtual end address (exclusive) > - * @pfns: array of hmm_pfn_t, only entry with fault flag set will be faulted > + * @range: range being faulted and all needed informations Similarly here, let's just write it like this: * @range: range being faulted thanks, -- John Hubbard NVIDIA
WARNING: multiple messages have this Message-ID (diff)
From: John Hubbard <jhubbard@nvidia.com> To: jglisse@redhat.com, linux-mm@kvack.org Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, Evgeny Baskakov <ebaskakov@nvidia.com>, Ralph Campbell <rcampbell@nvidia.com>, Mark Hairgrove <mhairgrove@nvidia.com> Subject: Re: [PATCH 05/14] mm/hmm: use struct for hmm_vma_fault(), hmm_vma_get_pfns() parameters Date: Fri, 16 Mar 2018 20:08:11 -0700 [thread overview] Message-ID: <9b8ad818-252d-e1f2-0cdb-a7228ccaa392@nvidia.com> (raw) In-Reply-To: <20180316191414.3223-6-jglisse@redhat.com> On 03/16/2018 12:14 PM, jglisse@redhat.com wrote: > From: Jérôme Glisse <jglisse@redhat.com> > Hi Jerome, I failed to find any problems in this patch, so: Reviewed-by: John Hubbard <jhubbard@nvidia.com> There are a couple of documentation recommended typo fixes listed below, which are very minor but as long as I'm here I'll point them out. > Both hmm_vma_fault() and hmm_vma_get_pfns() were taking a hmm_range > struct as parameter and were initializing that struct with others of > their parameters. Have caller of those function do this as they are > likely to already do and only pass this struct to both function this > shorten function signature and make it easiers in the future to add easier > new parameters by simply adding them to the structure. > > Signed-off-by: Jérôme Glisse <jglisse@redhat.com> > Cc: Evgeny Baskakov <ebaskakov@nvidia.com> > Cc: Ralph Campbell <rcampbell@nvidia.com> > Cc: Mark Hairgrove <mhairgrove@nvidia.com> > Cc: John Hubbard <jhubbard@nvidia.com> > --- > include/linux/hmm.h | 18 ++++--------- > mm/hmm.c | 78 +++++++++++++++++++---------------------------------- > 2 files changed, 33 insertions(+), 63 deletions(-) <snip> > > > diff --git a/mm/hmm.c b/mm/hmm.c > index 64d9e7dae712..49f0f6b337ed 100644 > --- a/mm/hmm.c > +++ b/mm/hmm.c > @@ -490,11 +490,7 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp, > > /* > * hmm_vma_get_pfns() - snapshot CPU page table for a range of virtual addresses > - * @vma: virtual memory area containing the virtual address range > - * @range: used to track snapshot validity > - * @start: range virtual start address (inclusive) > - * @end: range virtual end address (exclusive) > - * @entries: array of hmm_pfn_t: provided by the caller, filled in by function > + * @range: range being snapshoted and all needed informations Let's just say this: * @range: range being snapshotted <snip> > @@ -628,11 +617,7 @@ EXPORT_SYMBOL(hmm_vma_range_done); > > /* > * hmm_vma_fault() - try to fault some address in a virtual address range > - * @vma: virtual memory area containing the virtual address range > - * @range: use to track pfns array content validity > - * @start: fault range virtual start address (inclusive) > - * @end: fault range virtual end address (exclusive) > - * @pfns: array of hmm_pfn_t, only entry with fault flag set will be faulted > + * @range: range being faulted and all needed informations Similarly here, let's just write it like this: * @range: range being faulted thanks, -- John Hubbard NVIDIA
next prev parent reply other threads:[~2018-03-17 3:08 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-16 19:14 [PATCH 0/4] hmm: fixes and documentations v2 jglisse 2018-03-16 19:14 ` jglisse 2018-03-16 19:14 ` [PATCH 01/14] mm/hmm: documentation editorial update to HMM documentation jglisse 2018-03-16 19:14 ` jglisse 2018-03-16 19:14 ` [PATCH 02/14] mm/hmm: fix header file if/else/endif maze jglisse 2018-03-16 19:14 ` jglisse 2018-03-16 21:09 ` Andrew Morton 2018-03-16 21:18 ` Jerome Glisse 2018-03-16 21:18 ` Jerome Glisse 2018-03-16 21:18 ` Jerome Glisse 2018-03-16 21:35 ` Andrew Morton 2018-03-16 21:40 ` John Hubbard 2018-03-16 21:40 ` John Hubbard 2018-03-17 1:20 ` [PATCH 02/14] mm/hmm: fix header file if/else/endif maze v2 jglisse 2018-03-17 1:20 ` jglisse 2018-03-16 19:14 ` [PATCH 03/14] mm/hmm: HMM should have a callback before MM is destroyed v2 jglisse 2018-03-16 19:14 ` jglisse 2018-03-16 21:12 ` Andrew Morton 2018-03-16 21:26 ` Jerome Glisse 2018-03-16 21:26 ` Jerome Glisse 2018-03-16 21:26 ` Jerome Glisse 2018-03-16 21:37 ` John Hubbard 2018-03-16 21:37 ` John Hubbard 2018-03-17 2:36 ` John Hubbard 2018-03-17 2:36 ` John Hubbard 2018-03-17 3:47 ` John Hubbard 2018-03-17 3:47 ` John Hubbard 2018-03-17 4:39 ` John Hubbard 2018-03-17 4:39 ` John Hubbard 2018-03-16 19:14 ` [PATCH 04/14] mm/hmm: hmm_pfns_bad() was accessing wrong struct jglisse 2018-03-16 19:14 ` jglisse 2018-03-17 2:04 ` John Hubbard 2018-03-17 2:04 ` John Hubbard 2018-03-16 19:14 ` [PATCH 05/14] mm/hmm: use struct for hmm_vma_fault(), hmm_vma_get_pfns() parameters jglisse 2018-03-16 19:14 ` jglisse 2018-03-17 3:08 ` John Hubbard [this message] 2018-03-17 3:08 ` John Hubbard 2018-03-16 19:14 ` [PATCH 06/14] mm/hmm: remove HMM_PFN_READ flag and ignore peculiar architecture jglisse 2018-03-16 19:14 ` jglisse 2018-03-17 3:30 ` John Hubbard 2018-03-17 3:30 ` John Hubbard 2018-03-16 19:14 ` [PATCH 07/14] mm/hmm: use uint64_t for HMM pfn instead of defining hmm_pfn_t to ulong jglisse 2018-03-16 19:14 ` jglisse 2018-03-17 3:59 ` John Hubbard 2018-03-17 3:59 ` John Hubbard 2018-03-16 19:14 ` [PATCH 08/14] mm/hmm: cleanup special vma handling (VM_SPECIAL) jglisse 2018-03-16 19:14 ` jglisse 2018-03-17 4:35 ` John Hubbard 2018-03-17 4:35 ` John Hubbard 2018-03-16 19:14 ` [PATCH 09/14] mm/hmm: do not differentiate between empty entry or missing directory jglisse 2018-03-16 19:14 ` jglisse 2018-03-19 23:06 ` John Hubbard 2018-03-19 23:06 ` John Hubbard 2018-03-20 2:08 ` Jerome Glisse 2018-03-20 2:08 ` Jerome Glisse
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9b8ad818-252d-e1f2-0cdb-a7228ccaa392@nvidia.com \ --to=jhubbard@nvidia.com \ --cc=akpm@linux-foundation.org \ --cc=ebaskakov@nvidia.com \ --cc=jglisse@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhairgrove@nvidia.com \ --cc=rcampbell@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.