From: John Hubbard <jhubbard@nvidia.com> To: <jglisse@redhat.com>, <linux-mm@kvack.org> Cc: Andrew Morton <akpm@linux-foundation.org>, <linux-kernel@vger.kernel.org>, Evgeny Baskakov <ebaskakov@nvidia.com>, Ralph Campbell <rcampbell@nvidia.com>, Mark Hairgrove <mhairgrove@nvidia.com> Subject: Re: [PATCH 07/14] mm/hmm: use uint64_t for HMM pfn instead of defining hmm_pfn_t to ulong Date: Fri, 16 Mar 2018 20:59:49 -0700 [thread overview] Message-ID: <e20e4e55-c99b-03c2-0bcf-4167d583dcbe@nvidia.com> (raw) In-Reply-To: <20180316191414.3223-8-jglisse@redhat.com> On 03/16/2018 12:14 PM, jglisse@redhat.com wrote: > From: Jérôme Glisse <jglisse@redhat.com> > Hi Jerome, This one looks great. A couple of trivial typo fixes are listed below. You can add: Reviewed-by: John Hubbard <jhubbard@nvidia.com> > All device driver we care about are using 64bits page table entry. In > order to match this and to avoid useless define convert all HMM pfn to > directly use uint64_t. It is a first step on the road to allow driver > to directly use pfn value return by HMM (saving memory and CPU cycles > use for convertion between the two). used for conversion > > Signed-off-by: Jérôme Glisse <jglisse@redhat.com> > Cc: Evgeny Baskakov <ebaskakov@nvidia.com> > Cc: Ralph Campbell <rcampbell@nvidia.com> > Cc: Mark Hairgrove <mhairgrove@nvidia.com> > Cc: John Hubbard <jhubbard@nvidia.com> > --- > include/linux/hmm.h | 46 +++++++++++++++++++++------------------------- > mm/hmm.c | 26 +++++++++++++------------- > 2 files changed, 34 insertions(+), 38 deletions(-) > <snip> > @@ -104,14 +100,14 @@ typedef unsigned long hmm_pfn_t; > #define HMM_PFN_SHIFT 6 > > /* > - * hmm_pfn_t_to_page() - return struct page pointed to by a valid hmm_pfn_t > - * @pfn: hmm_pfn_t to convert to struct page > - * Returns: struct page pointer if pfn is a valid hmm_pfn_t, NULL otherwise > + * hmm_pfn_to_page() - return struct page pointed to by a valid HMM pfn > + * @pfn: HMM pfn value to get corresponding struct page from > + * Returns: struct page pointer if pfn is a valid HMM pfn, NULL otherwise > * > - * If the hmm_pfn_t is valid (ie valid flag set) then return the struct page > - * matching the pfn value stored in the hmm_pfn_t. Otherwise return NULL. > + * If the uint64_t is valid (ie valid flag set) then return the struct page If the HMM pfn is valid <snip> > > @@ -634,8 +634,8 @@ EXPORT_SYMBOL(hmm_vma_range_done); > * This is similar to a regular CPU page fault except that it will not trigger > * any memory migration if the memory being faulted is not accessible by CPUs. > * > - * On error, for one virtual address in the range, the function will set the > - * hmm_pfn_t error flag for the corresponding pfn entry. > + * On error, for one virtual address in the range, the function will mark the > + * correspond HMM pfn entry with error flag. corresponding HMM pfn entry with an error flag. thanks, -- John Hubbard NVIDIA
WARNING: multiple messages have this Message-ID (diff)
From: John Hubbard <jhubbard@nvidia.com> To: jglisse@redhat.com, linux-mm@kvack.org Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, Evgeny Baskakov <ebaskakov@nvidia.com>, Ralph Campbell <rcampbell@nvidia.com>, Mark Hairgrove <mhairgrove@nvidia.com> Subject: Re: [PATCH 07/14] mm/hmm: use uint64_t for HMM pfn instead of defining hmm_pfn_t to ulong Date: Fri, 16 Mar 2018 20:59:49 -0700 [thread overview] Message-ID: <e20e4e55-c99b-03c2-0bcf-4167d583dcbe@nvidia.com> (raw) In-Reply-To: <20180316191414.3223-8-jglisse@redhat.com> On 03/16/2018 12:14 PM, jglisse@redhat.com wrote: > From: Jérôme Glisse <jglisse@redhat.com> > Hi Jerome, This one looks great. A couple of trivial typo fixes are listed below. You can add: Reviewed-by: John Hubbard <jhubbard@nvidia.com> > All device driver we care about are using 64bits page table entry. In > order to match this and to avoid useless define convert all HMM pfn to > directly use uint64_t. It is a first step on the road to allow driver > to directly use pfn value return by HMM (saving memory and CPU cycles > use for convertion between the two). used for conversion > > Signed-off-by: Jérôme Glisse <jglisse@redhat.com> > Cc: Evgeny Baskakov <ebaskakov@nvidia.com> > Cc: Ralph Campbell <rcampbell@nvidia.com> > Cc: Mark Hairgrove <mhairgrove@nvidia.com> > Cc: John Hubbard <jhubbard@nvidia.com> > --- > include/linux/hmm.h | 46 +++++++++++++++++++++------------------------- > mm/hmm.c | 26 +++++++++++++------------- > 2 files changed, 34 insertions(+), 38 deletions(-) > <snip> > @@ -104,14 +100,14 @@ typedef unsigned long hmm_pfn_t; > #define HMM_PFN_SHIFT 6 > > /* > - * hmm_pfn_t_to_page() - return struct page pointed to by a valid hmm_pfn_t > - * @pfn: hmm_pfn_t to convert to struct page > - * Returns: struct page pointer if pfn is a valid hmm_pfn_t, NULL otherwise > + * hmm_pfn_to_page() - return struct page pointed to by a valid HMM pfn > + * @pfn: HMM pfn value to get corresponding struct page from > + * Returns: struct page pointer if pfn is a valid HMM pfn, NULL otherwise > * > - * If the hmm_pfn_t is valid (ie valid flag set) then return the struct page > - * matching the pfn value stored in the hmm_pfn_t. Otherwise return NULL. > + * If the uint64_t is valid (ie valid flag set) then return the struct page If the HMM pfn is valid <snip> > > @@ -634,8 +634,8 @@ EXPORT_SYMBOL(hmm_vma_range_done); > * This is similar to a regular CPU page fault except that it will not trigger > * any memory migration if the memory being faulted is not accessible by CPUs. > * > - * On error, for one virtual address in the range, the function will set the > - * hmm_pfn_t error flag for the corresponding pfn entry. > + * On error, for one virtual address in the range, the function will mark the > + * correspond HMM pfn entry with error flag. corresponding HMM pfn entry with an error flag. thanks, -- John Hubbard NVIDIA
next prev parent reply other threads:[~2018-03-17 3:59 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-16 19:14 [PATCH 0/4] hmm: fixes and documentations v2 jglisse 2018-03-16 19:14 ` jglisse 2018-03-16 19:14 ` [PATCH 01/14] mm/hmm: documentation editorial update to HMM documentation jglisse 2018-03-16 19:14 ` jglisse 2018-03-16 19:14 ` [PATCH 02/14] mm/hmm: fix header file if/else/endif maze jglisse 2018-03-16 19:14 ` jglisse 2018-03-16 21:09 ` Andrew Morton 2018-03-16 21:18 ` Jerome Glisse 2018-03-16 21:18 ` Jerome Glisse 2018-03-16 21:18 ` Jerome Glisse 2018-03-16 21:35 ` Andrew Morton 2018-03-16 21:40 ` John Hubbard 2018-03-16 21:40 ` John Hubbard 2018-03-17 1:20 ` [PATCH 02/14] mm/hmm: fix header file if/else/endif maze v2 jglisse 2018-03-17 1:20 ` jglisse 2018-03-16 19:14 ` [PATCH 03/14] mm/hmm: HMM should have a callback before MM is destroyed v2 jglisse 2018-03-16 19:14 ` jglisse 2018-03-16 21:12 ` Andrew Morton 2018-03-16 21:26 ` Jerome Glisse 2018-03-16 21:26 ` Jerome Glisse 2018-03-16 21:26 ` Jerome Glisse 2018-03-16 21:37 ` John Hubbard 2018-03-16 21:37 ` John Hubbard 2018-03-17 2:36 ` John Hubbard 2018-03-17 2:36 ` John Hubbard 2018-03-17 3:47 ` John Hubbard 2018-03-17 3:47 ` John Hubbard 2018-03-17 4:39 ` John Hubbard 2018-03-17 4:39 ` John Hubbard 2018-03-16 19:14 ` [PATCH 04/14] mm/hmm: hmm_pfns_bad() was accessing wrong struct jglisse 2018-03-16 19:14 ` jglisse 2018-03-17 2:04 ` John Hubbard 2018-03-17 2:04 ` John Hubbard 2018-03-16 19:14 ` [PATCH 05/14] mm/hmm: use struct for hmm_vma_fault(), hmm_vma_get_pfns() parameters jglisse 2018-03-16 19:14 ` jglisse 2018-03-17 3:08 ` John Hubbard 2018-03-17 3:08 ` John Hubbard 2018-03-16 19:14 ` [PATCH 06/14] mm/hmm: remove HMM_PFN_READ flag and ignore peculiar architecture jglisse 2018-03-16 19:14 ` jglisse 2018-03-17 3:30 ` John Hubbard 2018-03-17 3:30 ` John Hubbard 2018-03-16 19:14 ` [PATCH 07/14] mm/hmm: use uint64_t for HMM pfn instead of defining hmm_pfn_t to ulong jglisse 2018-03-16 19:14 ` jglisse 2018-03-17 3:59 ` John Hubbard [this message] 2018-03-17 3:59 ` John Hubbard 2018-03-16 19:14 ` [PATCH 08/14] mm/hmm: cleanup special vma handling (VM_SPECIAL) jglisse 2018-03-16 19:14 ` jglisse 2018-03-17 4:35 ` John Hubbard 2018-03-17 4:35 ` John Hubbard 2018-03-16 19:14 ` [PATCH 09/14] mm/hmm: do not differentiate between empty entry or missing directory jglisse 2018-03-16 19:14 ` jglisse 2018-03-19 23:06 ` John Hubbard 2018-03-19 23:06 ` John Hubbard 2018-03-20 2:08 ` Jerome Glisse 2018-03-20 2:08 ` Jerome Glisse
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e20e4e55-c99b-03c2-0bcf-4167d583dcbe@nvidia.com \ --to=jhubbard@nvidia.com \ --cc=akpm@linux-foundation.org \ --cc=ebaskakov@nvidia.com \ --cc=jglisse@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhairgrove@nvidia.com \ --cc=rcampbell@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.