* [PATCH net] net/ipv4: fix sysctl max for fib_multipath_hash_policy
@ 2019-11-18 12:46 Marcelo Ricardo Leitner
2019-11-18 13:02 ` Matteo Croce
2019-11-19 1:27 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Marcelo Ricardo Leitner @ 2019-11-18 12:46 UTC (permalink / raw)
To: netdev; +Cc: Matteo Croce
Commit eec4844fae7c ("proc/sysctl: add shared variables for range
check") did:
- .extra2 = &two,
+ .extra2 = SYSCTL_ONE,
here, which doesn't seem to be intentional, given the changelog.
This patch restores it to the previous, as the value of 2 still makes
sense (used in fib_multipath_hash()).
Fixes: eec4844fae7c ("proc/sysctl: add shared variables for range check")
Cc: Matteo Croce <mcroce@redhat.com>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
---
net/ipv4/sysctl_net_ipv4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
index 59ded25acd045d90573eb144381df4381ecba837..0902cb32bbad69f77b93f5c4175f37ad706d1cde 100644
--- a/net/ipv4/sysctl_net_ipv4.c
+++ b/net/ipv4/sysctl_net_ipv4.c
@@ -1037,7 +1037,7 @@ static struct ctl_table ipv4_net_table[] = {
.mode = 0644,
.proc_handler = proc_fib_multipath_hash_policy,
.extra1 = SYSCTL_ZERO,
- .extra2 = SYSCTL_ONE,
+ .extra2 = &two,
},
#endif
{
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net/ipv4: fix sysctl max for fib_multipath_hash_policy
2019-11-18 12:46 [PATCH net] net/ipv4: fix sysctl max for fib_multipath_hash_policy Marcelo Ricardo Leitner
@ 2019-11-18 13:02 ` Matteo Croce
2019-11-19 1:27 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Matteo Croce @ 2019-11-18 13:02 UTC (permalink / raw)
To: Marcelo Ricardo Leitner; +Cc: netdev
On Mon, Nov 18, 2019 at 1:46 PM Marcelo Ricardo Leitner
<marcelo.leitner@gmail.com> wrote:
>
> Commit eec4844fae7c ("proc/sysctl: add shared variables for range
> check") did:
> - .extra2 = &two,
> + .extra2 = SYSCTL_ONE,
> here, which doesn't seem to be intentional, given the changelog.
> This patch restores it to the previous, as the value of 2 still makes
> sense (used in fib_multipath_hash()).
>
Nice catch.
Somehow a chunk in 363887a2cdfeb was partially reverted.
Acked-by: Matteo Croce <mcroce@redhat.com>
--
Matteo Croce
per aspera ad upstream
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net/ipv4: fix sysctl max for fib_multipath_hash_policy
2019-11-18 12:46 [PATCH net] net/ipv4: fix sysctl max for fib_multipath_hash_policy Marcelo Ricardo Leitner
2019-11-18 13:02 ` Matteo Croce
@ 2019-11-19 1:27 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-11-19 1:27 UTC (permalink / raw)
To: marcelo.leitner; +Cc: netdev, mcroce
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Date: Mon, 18 Nov 2019 09:46:09 -0300
> Commit eec4844fae7c ("proc/sysctl: add shared variables for range
> check") did:
> - .extra2 = &two,
> + .extra2 = SYSCTL_ONE,
> here, which doesn't seem to be intentional, given the changelog.
> This patch restores it to the previous, as the value of 2 still makes
> sense (used in fib_multipath_hash()).
>
> Fixes: eec4844fae7c ("proc/sysctl: add shared variables for range check")
> Cc: Matteo Croce <mcroce@redhat.com>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-19 1:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 12:46 [PATCH net] net/ipv4: fix sysctl max for fib_multipath_hash_policy Marcelo Ricardo Leitner
2019-11-18 13:02 ` Matteo Croce
2019-11-19 1:27 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.