From: yanhong wang <yanhong.wang@starfivetech.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, <linux-riscv@lists.infradead.org>, <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> Cc: "David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Emil Renner Berthing <kernel@esmil.dk>, Richard Cochran <richardcochran@gmail.com>, Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Peter Geis <pgwipeout@gmail.com> Subject: Re: [PATCH v2 4/9] dt-bindings: net: Add bindings for StarFive dwmac Date: Tue, 20 Dec 2022 14:53:41 +0800 [thread overview] Message-ID: <9bdb7929-a801-d244-2731-dd55541ad2ce@starfivetech.com> (raw) In-Reply-To: <2da394a6-411a-ca2b-90d3-7e97f3637d9f@linaro.org> On 2022/12/16 19:05, Krzysztof Kozlowski wrote: > On 16/12/2022 08:06, Yanhong Wang wrote: >> Add documentation to describe StarFive dwmac driver(GMAC). >> >> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com> >> --- >> .../devicetree/bindings/net/snps,dwmac.yaml | 1 + >> .../bindings/net/starfive,jh71x0-dwmac.yaml | 103 ++++++++++++++++++ >> MAINTAINERS | 5 + >> 3 files changed, 109 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/starfive,jh71x0-dwmac.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> index 7870228b4cd3..cdb045d1c618 100644 >> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> @@ -91,6 +91,7 @@ properties: >> - snps,dwmac-5.20 >> - snps,dwxgmac >> - snps,dwxgmac-2.10 >> + - starfive,jh7110-dwmac >> >> reg: >> minItems: 1 >> diff --git a/Documentation/devicetree/bindings/net/starfive,jh71x0-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh71x0-dwmac.yaml >> new file mode 100644 >> index 000000000000..5cb1272fe959 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/starfive,jh71x0-dwmac.yaml >> @@ -0,0 +1,103 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +# Copyright (C) 2022 StarFive Technology Co., Ltd. >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/starfive,jh71x0-dwmac.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH71x0 DWMAC glue layer >> + >> +maintainers: >> + - Yanhong Wang <yanhong.wang@starfivetech.com> >> + >> +select: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - starfive,jh7110-dwmac >> + required: >> + - compatible >> + >> +allOf: >> + - $ref: snps,dwmac.yaml# >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - starfive,jh7110-dwmac > > Is it going to grow with new models? If yes, when? If not, filename does > not match compatible. I will update the filename in the next version. > >> + - const: snps,dwmac-5.20 >> + >> + clocks: >> + items: >> + - description: GMAC main clock >> + - description: GMAC AHB clock >> + - description: PTP clock >> + - description: TX clock >> + - description: GTXC clock >> + - description: GTX clock >> + >> + clock-names: >> + items: >> + - const: stmmaceth >> + - const: pclk >> + - const: ptp_ref >> + - const: tx >> + - const: gtxc >> + - const: gtx > > missing resets and reset-names. > I will add resets and reset-names in the next version. >> + >> +required: >> + - compatible >> + - clocks >> + - clock-names >> + - resets >> + - reset-names >> + >> +unevaluatedProperties: false >> + > Best regards, > Krzysztof >
WARNING: multiple messages have this Message-ID (diff)
From: yanhong wang <yanhong.wang@starfivetech.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, <linux-riscv@lists.infradead.org>, <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> Cc: "David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Emil Renner Berthing <kernel@esmil.dk>, Richard Cochran <richardcochran@gmail.com>, Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Peter Geis <pgwipeout@gmail.com> Subject: Re: [PATCH v2 4/9] dt-bindings: net: Add bindings for StarFive dwmac Date: Tue, 20 Dec 2022 14:53:41 +0800 [thread overview] Message-ID: <9bdb7929-a801-d244-2731-dd55541ad2ce@starfivetech.com> (raw) In-Reply-To: <2da394a6-411a-ca2b-90d3-7e97f3637d9f@linaro.org> On 2022/12/16 19:05, Krzysztof Kozlowski wrote: > On 16/12/2022 08:06, Yanhong Wang wrote: >> Add documentation to describe StarFive dwmac driver(GMAC). >> >> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com> >> --- >> .../devicetree/bindings/net/snps,dwmac.yaml | 1 + >> .../bindings/net/starfive,jh71x0-dwmac.yaml | 103 ++++++++++++++++++ >> MAINTAINERS | 5 + >> 3 files changed, 109 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/starfive,jh71x0-dwmac.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> index 7870228b4cd3..cdb045d1c618 100644 >> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> @@ -91,6 +91,7 @@ properties: >> - snps,dwmac-5.20 >> - snps,dwxgmac >> - snps,dwxgmac-2.10 >> + - starfive,jh7110-dwmac >> >> reg: >> minItems: 1 >> diff --git a/Documentation/devicetree/bindings/net/starfive,jh71x0-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh71x0-dwmac.yaml >> new file mode 100644 >> index 000000000000..5cb1272fe959 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/starfive,jh71x0-dwmac.yaml >> @@ -0,0 +1,103 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +# Copyright (C) 2022 StarFive Technology Co., Ltd. >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/starfive,jh71x0-dwmac.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH71x0 DWMAC glue layer >> + >> +maintainers: >> + - Yanhong Wang <yanhong.wang@starfivetech.com> >> + >> +select: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - starfive,jh7110-dwmac >> + required: >> + - compatible >> + >> +allOf: >> + - $ref: snps,dwmac.yaml# >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - starfive,jh7110-dwmac > > Is it going to grow with new models? If yes, when? If not, filename does > not match compatible. I will update the filename in the next version. > >> + - const: snps,dwmac-5.20 >> + >> + clocks: >> + items: >> + - description: GMAC main clock >> + - description: GMAC AHB clock >> + - description: PTP clock >> + - description: TX clock >> + - description: GTXC clock >> + - description: GTX clock >> + >> + clock-names: >> + items: >> + - const: stmmaceth >> + - const: pclk >> + - const: ptp_ref >> + - const: tx >> + - const: gtxc >> + - const: gtx > > missing resets and reset-names. > I will add resets and reset-names in the next version. >> + >> +required: >> + - compatible >> + - clocks >> + - clock-names >> + - resets >> + - reset-names >> + >> +unevaluatedProperties: false >> + > Best regards, > Krzysztof > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-12-20 6:54 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-16 7:06 [PATCH v2 0/9] Add Ethernet driver for StarFive JH7110 SoC Yanhong Wang 2022-12-16 7:06 ` Yanhong Wang 2022-12-16 7:06 ` [PATCH v2 1/9] dt-bindings: net: snps,dwmac: Add dwmac-5.20 version Yanhong Wang 2022-12-16 7:06 ` Yanhong Wang 2022-12-16 7:06 ` [PATCH v2 2/9] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names Yanhong Wang 2022-12-16 7:06 ` Yanhong Wang 2022-12-16 11:03 ` Krzysztof Kozlowski 2022-12-16 11:03 ` Krzysztof Kozlowski 2022-12-20 6:48 ` yanhong wang 2022-12-20 6:48 ` yanhong wang 2022-12-20 9:21 ` Krzysztof Kozlowski 2022-12-20 9:21 ` Krzysztof Kozlowski 2022-12-27 7:48 ` yanhong wang 2022-12-27 7:48 ` yanhong wang 2022-12-27 8:18 ` Krzysztof Kozlowski 2022-12-27 8:18 ` Krzysztof Kozlowski 2022-12-16 7:06 ` [PATCH v2 3/9] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string Yanhong Wang 2022-12-16 7:06 ` Yanhong Wang 2022-12-16 7:06 ` [PATCH v2 4/9] dt-bindings: net: Add bindings for StarFive dwmac Yanhong Wang 2022-12-16 7:06 ` Yanhong Wang 2022-12-16 11:05 ` Krzysztof Kozlowski 2022-12-16 11:05 ` Krzysztof Kozlowski 2022-12-20 6:53 ` yanhong wang [this message] 2022-12-20 6:53 ` yanhong wang 2022-12-16 11:06 ` Krzysztof Kozlowski 2022-12-16 11:06 ` Krzysztof Kozlowski 2022-12-20 6:57 ` yanhong wang 2022-12-20 6:57 ` yanhong wang 2022-12-20 18:03 ` Rob Herring 2022-12-20 18:03 ` Rob Herring 2022-12-16 7:06 ` [PATCH v2 5/9] dt-bindings: net: motorcomm: add support for Motorcomm YT8531 Yanhong Wang 2022-12-16 7:06 ` Yanhong Wang 2022-12-16 11:15 ` Krzysztof Kozlowski 2022-12-16 11:15 ` Krzysztof Kozlowski 2022-12-27 9:38 ` yanhong wang 2022-12-27 9:38 ` yanhong wang 2022-12-27 9:52 ` Krzysztof Kozlowski 2022-12-27 9:52 ` Krzysztof Kozlowski 2022-12-28 3:23 ` yanhong wang 2022-12-28 3:23 ` yanhong wang 2022-12-28 9:11 ` Krzysztof Kozlowski 2022-12-28 9:11 ` Krzysztof Kozlowski 2022-12-28 9:24 ` yanhong wang 2022-12-28 9:24 ` yanhong wang 2022-12-16 7:06 ` [PATCH v2 6/9] net: phy: motorcomm: Add YT8531 phy support Yanhong Wang 2022-12-16 7:06 ` Yanhong Wang 2022-12-16 8:41 ` Arun.Ramadoss 2022-12-16 8:41 ` Arun.Ramadoss 2022-12-16 11:58 ` Heiner Kallweit 2022-12-16 11:58 ` Heiner Kallweit 2022-12-21 1:16 ` yanhong wang 2022-12-21 1:16 ` yanhong wang 2022-12-20 14:20 ` Andrew Lunn 2022-12-20 14:20 ` Andrew Lunn 2022-12-16 7:06 ` [PATCH v2 7/9] net: stmmac: Add glue layer for StarFive JH71x0 SoCs Yanhong Wang 2022-12-16 7:06 ` Yanhong Wang 2022-12-16 11:19 ` Krzysztof Kozlowski 2022-12-16 11:19 ` Krzysztof Kozlowski 2022-12-16 7:06 ` [PATCH v2 8/9] riscv: dts: starfive: jh7110: Add ethernet device node Yanhong Wang 2022-12-16 7:06 ` Yanhong Wang 2022-12-16 7:06 ` [PATCH v2 9/9] riscv: dts: starfive: visionfive-v2: Add phy clock delay train configuration Yanhong Wang 2022-12-16 7:06 ` Yanhong Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9bdb7929-a801-d244-2731-dd55541ad2ce@starfivetech.com \ --to=yanhong.wang@starfivetech.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=edumazet@google.com \ --cc=hkallweit1@gmail.com \ --cc=kernel@esmil.dk \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=kuba@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=pgwipeout@gmail.com \ --cc=richardcochran@gmail.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.