All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trilok Soni <tsoni@codeaurora.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
	Rishabh Bhatnagar <rishabhb@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org
Cc: linux-arm@lists.infradead.org, linux-kernel@vger.kernel.org,
	kyan@codeaurora.org, ckadabi@codeaurora.org
Subject: Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver
Date: Thu, 29 Mar 2018 17:31:47 -0700	[thread overview]
Message-ID: <9d6dad94-3e17-2ca6-2921-3f461e8315ca@codeaurora.org> (raw)
In-Reply-To: <ff949d44-1b2a-15d4-511d-8686a973b081@linaro.org>

Hi Stanimir,

+/* Get the slice entry by index */
>> +static struct llcc_slice_desc *llcc_slice_get_entry(struct device *dev, int n)
> drop this *slice* word from function names

Please note that we are activating/de-activating  a "slice" of the LLCC 
and not a whole LLCC. "slice" makes perfect sense here since the 
granularity is at the "slice" level and not the complete LLCC.

--Trilok Soni

WARNING: multiple messages have this Message-ID (diff)
From: tsoni@codeaurora.org (Trilok Soni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] drivers: soc: Add LLCC driver
Date: Thu, 29 Mar 2018 17:31:47 -0700	[thread overview]
Message-ID: <9d6dad94-3e17-2ca6-2921-3f461e8315ca@codeaurora.org> (raw)
In-Reply-To: <ff949d44-1b2a-15d4-511d-8686a973b081@linaro.org>

Hi Stanimir,

+/* Get the slice entry by index */
>> +static struct llcc_slice_desc *llcc_slice_get_entry(struct device *dev, int n)
> drop this *slice* word from function names

Please note that we are activating/de-activating? a "slice" of the LLCC 
and not a whole LLCC. "slice" makes perfect sense here since the 
granularity is at the "slice" level and not the complete LLCC.

--Trilok Soni

  parent reply	other threads:[~2018-03-30  0:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-27 18:52 [PATCH v3 0/2] SDM845 System Cache Driver Rishabh Bhatnagar
2018-03-27 18:52 ` Rishabh Bhatnagar
2018-03-27 18:52 ` [PATCH v3 1/2] Documentation: Documentation for qcom, llcc Rishabh Bhatnagar
2018-03-27 18:52   ` Rishabh Bhatnagar
2018-03-29  8:25   ` Stanimir Varbanov
2018-03-29  8:25     ` Stanimir Varbanov
2018-04-02 12:31   ` Rob Herring
2018-04-02 12:31     ` Rob Herring
2018-03-27 18:52 ` [PATCH v3 2/2] drivers: soc: Add LLCC driver Rishabh Bhatnagar
2018-03-27 18:52   ` Rishabh Bhatnagar
2018-03-28 22:02   ` Evan Green
2018-03-28 22:02     ` Evan Green
2018-03-29  8:08   ` Stanimir Varbanov
2018-03-29  8:08     ` Stanimir Varbanov
2018-03-29 17:55     ` Channa
2018-03-29 17:55       ` Channa
2018-04-02  9:11       ` Stanimir Varbanov
2018-04-02  9:11         ` Stanimir Varbanov
2018-04-02 19:03         ` Channa
2018-04-02 19:03           ` Channa
2018-03-30  0:31     ` Trilok Soni [this message]
2018-03-30  0:31       ` Trilok Soni
2018-04-04 17:30     ` rishabhb
2018-04-04 17:30       ` rishabhb at codeaurora.org
2018-04-07 10:43       ` Stanimir Varbanov
2018-04-07 10:43         ` Stanimir Varbanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d6dad94-3e17-2ca6-2921-3f461e8315ca@codeaurora.org \
    --to=tsoni@codeaurora.org \
    --cc=ckadabi@codeaurora.org \
    --cc=kyan@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-arm@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rishabhb@codeaurora.org \
    --cc=stanimir.varbanov@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.