* [PATCH] drm/amdgpu: Use drm_dbg_kms for reporting failure to get a GEM FB
@ 2021-06-02 9:53 Michel Dänzer
2021-06-02 9:56 ` Christian König
0 siblings, 1 reply; 6+ messages in thread
From: Michel Dänzer @ 2021-06-02 9:53 UTC (permalink / raw)
To: amd-gfx; +Cc: Mark Yacoub
From: Michel Dänzer <mdaenzer@redhat.com>
drm_err meant broken user space could spam dmesg.
Fixes: f258907fdd835e "drm/amdgpu: Verify bo size can fit framebuffer
size on init."
Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
index 8170e24ce37d..2a4cd7d377bf 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
@@ -1058,7 +1058,7 @@ int amdgpu_display_gem_fb_init(struct drm_device *dev,
return 0;
err:
- drm_err(dev, "Failed to init gem fb: %d\n", ret);
+ drm_dbg_kms(dev, "Failed to init gem fb: %d\n", ret);
rfb->base.obj[0] = NULL;
return ret;
}
@@ -1096,7 +1096,7 @@ int amdgpu_display_gem_fb_verify_and_init(
return 0;
err:
- drm_err(dev, "Failed to verify and init gem fb: %d\n", ret);
+ drm_dbg_kms(dev, "Failed to verify and init gem fb: %d\n", ret);
rfb->base.obj[0] = NULL;
return ret;
}
--
2.31.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/amdgpu: Use drm_dbg_kms for reporting failure to get a GEM FB
2021-06-02 9:53 [PATCH] drm/amdgpu: Use drm_dbg_kms for reporting failure to get a GEM FB Michel Dänzer
@ 2021-06-02 9:56 ` Christian König
2021-06-02 14:44 ` Mark Yacoub
0 siblings, 1 reply; 6+ messages in thread
From: Christian König @ 2021-06-02 9:56 UTC (permalink / raw)
To: Michel Dänzer, amd-gfx; +Cc: Mark Yacoub
Am 02.06.21 um 11:53 schrieb Michel Dänzer:
> From: Michel Dänzer <mdaenzer@redhat.com>
>
> drm_err meant broken user space could spam dmesg.
>
> Fixes: f258907fdd835e "drm/amdgpu: Verify bo size can fit framebuffer
> size on init."
> Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> index 8170e24ce37d..2a4cd7d377bf 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> @@ -1058,7 +1058,7 @@ int amdgpu_display_gem_fb_init(struct drm_device *dev,
>
> return 0;
> err:
> - drm_err(dev, "Failed to init gem fb: %d\n", ret);
> + drm_dbg_kms(dev, "Failed to init gem fb: %d\n", ret);
> rfb->base.obj[0] = NULL;
> return ret;
> }
> @@ -1096,7 +1096,7 @@ int amdgpu_display_gem_fb_verify_and_init(
>
> return 0;
> err:
> - drm_err(dev, "Failed to verify and init gem fb: %d\n", ret);
> + drm_dbg_kms(dev, "Failed to verify and init gem fb: %d\n", ret);
> rfb->base.obj[0] = NULL;
> return ret;
> }
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: Use drm_dbg_kms for reporting failure to get a GEM FB
2021-06-02 9:56 ` Christian König
@ 2021-06-02 14:44 ` Mark Yacoub
2021-06-02 14:45 ` Mark Yacoub
0 siblings, 1 reply; 6+ messages in thread
From: Mark Yacoub @ 2021-06-02 14:44 UTC (permalink / raw)
To: Mark Yacoub; +Cc: Michel Dänzer, amd-gfx list
[-- Attachment #1.1: Type: text/plain, Size: 1546 bytes --]
On Wed, Jun 2, 2021 at 5:56 AM Christian König <
ckoenig.leichtzumerken@gmail.com> wrote:
>
>
> Am 02.06.21 um 11:53 schrieb Michel Dänzer:
> > From: Michel Dänzer <mdaenzer@redhat.com>
> >
> > drm_err meant broken user space could spam dmesg.
> >
> > Fixes: f258907fdd835e "drm/amdgpu: Verify bo size can fit framebuffer
> > size on init."
> > Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> > index 8170e24ce37d..2a4cd7d377bf 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> > @@ -1058,7 +1058,7 @@ int amdgpu_display_gem_fb_init(struct drm_device
> *dev,
> >
> > return 0;
> > err:
> > - drm_err(dev, "Failed to init gem fb: %d\n", ret);
> > + drm_dbg_kms(dev, "Failed to init gem fb: %d\n", ret);
> > rfb->base.obj[0] = NULL;
> > return ret;
> > }
> > @@ -1096,7 +1096,7 @@ int amdgpu_display_gem_fb_verify_and_init(
> >
> > return 0;
> > err:
> > - drm_err(dev, "Failed to verify and init gem fb: %d\n", ret);
> > + drm_dbg_kms(dev, "Failed to verify and init gem fb: %d\n", ret);
> > rfb->base.obj[0] = NULL;
> > return ret;
> > }
>
>
[-- Attachment #1.2: Type: text/html, Size: 2336 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: Use drm_dbg_kms for reporting failure to get a GEM FB
2021-06-02 14:44 ` Mark Yacoub
@ 2021-06-02 14:45 ` Mark Yacoub
2021-06-02 16:21 ` Alex Deucher
0 siblings, 1 reply; 6+ messages in thread
From: Mark Yacoub @ 2021-06-02 14:45 UTC (permalink / raw)
To: amd-gfx list; +Cc: ckoenig.leichtzumerken, Michel Dänzer
lgtm. Thanks!
> On Wed, Jun 2, 2021 at 5:56 AM Christian König <ckoenig.leichtzumerken@gmail.com> wrote:
>>
>>
>>
>> Am 02.06.21 um 11:53 schrieb Michel Dänzer:
>> > From: Michel Dänzer <mdaenzer@redhat.com>
>> >
>> > drm_err meant broken user space could spam dmesg.
>> >
>> > Fixes: f258907fdd835e "drm/amdgpu: Verify bo size can fit framebuffer
>> > size on init."
>> > Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
>>
>> Reviewed-by: Christian König <christian.koenig@amd.com>
>>
>> > ---
>> > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
>> > index 8170e24ce37d..2a4cd7d377bf 100644
>> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
>> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
>> > @@ -1058,7 +1058,7 @@ int amdgpu_display_gem_fb_init(struct drm_device *dev,
>> >
>> > return 0;
>> > err:
>> > - drm_err(dev, "Failed to init gem fb: %d\n", ret);
>> > + drm_dbg_kms(dev, "Failed to init gem fb: %d\n", ret);
>> > rfb->base.obj[0] = NULL;
>> > return ret;
>> > }
>> > @@ -1096,7 +1096,7 @@ int amdgpu_display_gem_fb_verify_and_init(
>> >
>> > return 0;
>> > err:
>> > - drm_err(dev, "Failed to verify and init gem fb: %d\n", ret);
>> > + drm_dbg_kms(dev, "Failed to verify and init gem fb: %d\n", ret);
>> > rfb->base.obj[0] = NULL;
>> > return ret;
>> > }
>>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: Use drm_dbg_kms for reporting failure to get a GEM FB
2021-06-02 14:45 ` Mark Yacoub
@ 2021-06-02 16:21 ` Alex Deucher
2021-06-03 7:48 ` Michel Dänzer
0 siblings, 1 reply; 6+ messages in thread
From: Alex Deucher @ 2021-06-02 16:21 UTC (permalink / raw)
To: Mark Yacoub; +Cc: Christian König, Michel Dänzer, amd-gfx list
Applied. Thanks!
Alex
On Wed, Jun 2, 2021 at 10:56 AM Mark Yacoub <markyacoub@chromium.org> wrote:
>
> lgtm. Thanks!
>
> > On Wed, Jun 2, 2021 at 5:56 AM Christian König <ckoenig.leichtzumerken@gmail.com> wrote:
> >>
> >>
> >>
> >> Am 02.06.21 um 11:53 schrieb Michel Dänzer:
> >> > From: Michel Dänzer <mdaenzer@redhat.com>
> >> >
> >> > drm_err meant broken user space could spam dmesg.
> >> >
> >> > Fixes: f258907fdd835e "drm/amdgpu: Verify bo size can fit framebuffer
> >> > size on init."
> >> > Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
> >>
> >> Reviewed-by: Christian König <christian.koenig@amd.com>
> >>
> >> > ---
> >> > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ++--
> >> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >> >
> >> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> >> > index 8170e24ce37d..2a4cd7d377bf 100644
> >> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> >> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> >> > @@ -1058,7 +1058,7 @@ int amdgpu_display_gem_fb_init(struct drm_device *dev,
> >> >
> >> > return 0;
> >> > err:
> >> > - drm_err(dev, "Failed to init gem fb: %d\n", ret);
> >> > + drm_dbg_kms(dev, "Failed to init gem fb: %d\n", ret);
> >> > rfb->base.obj[0] = NULL;
> >> > return ret;
> >> > }
> >> > @@ -1096,7 +1096,7 @@ int amdgpu_display_gem_fb_verify_and_init(
> >> >
> >> > return 0;
> >> > err:
> >> > - drm_err(dev, "Failed to verify and init gem fb: %d\n", ret);
> >> > + drm_dbg_kms(dev, "Failed to verify and init gem fb: %d\n", ret);
> >> > rfb->base.obj[0] = NULL;
> >> > return ret;
> >> > }
> >>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-03 7:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-02 9:53 [PATCH] drm/amdgpu: Use drm_dbg_kms for reporting failure to get a GEM FB Michel Dänzer
2021-06-02 9:56 ` Christian König
2021-06-02 14:44 ` Mark Yacoub
2021-06-02 14:45 ` Mark Yacoub
2021-06-02 16:21 ` Alex Deucher
2021-06-03 7:48 ` Michel Dänzer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.