From: "Arınç ÜNAL via B4 Relay" <devnull+arinc.unal.arinc9.com@kernel.org> To: "Daniel Golle" <daniel@makrotopia.org>, "DENG Qingfang" <dqfext@gmail.com>, "Sean Wang" <sean.wang@mediatek.com>, "Andrew Lunn" <andrew@lunn.ch>, "Florian Fainelli" <f.fainelli@gmail.com>, "Vladimir Oltean" <olteanv@gmail.com>, "David S. Miller" <davem@davemloft.net>, "Eric Dumazet" <edumazet@google.com>, "Jakub Kicinski" <kuba@kernel.org>, "Paolo Abeni" <pabeni@redhat.com>, "Matthias Brugger" <matthias.bgg@gmail.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, "René van Dorst" <opensource@vdorst.com>, "Russell King" <linux@armlinux.org.uk>, "SkyLake Huang" <SkyLake.Huang@mediatek.com>, "Heiner Kallweit" <hkallweit1@gmail.com> Cc: "Bartel Eerdekens" <bartel.eerdekens@constell8.be>, mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, "Arınç ÜNAL" <arinc.unal@arinc9.com> Subject: [PATCH 3/3] net: phy: mediatek-ge: do not disable EEE advertisement Date: Mon, 18 Mar 2024 10:46:25 +0300 [thread overview] Message-ID: <=?utf-8?q?=3C20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v?= =?utf-8?q?1-3-3f17226344e8=40arinc9=2Ecom=3E?=> (raw) In-Reply-To: =?utf-8?q?=3C20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-?= =?utf-8?q?v1-0-3f17226344e8=40arinc9=2Ecom=3E?= From: Arınç ÜNAL <arinc.unal@arinc9.com> There's no need to disable Energy-Efficient Ethernet (EEE) advertisement on the MT7530 and MT7531 switch PHYs. EEE works fine on MT7530 and MT7531 switch PHYs. Remove the code where EEE advertisement is disabled. This is a bugfix because there's a possible race condition where the mediatek-ge driver would kick in after the MT7530 DSA subdriver which would have EEE disabled until manually enabled. Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver") Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- drivers/net/phy/mediatek-ge.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c index a493ae01b267..54ea64a37ab3 100644 --- a/drivers/net/phy/mediatek-ge.c +++ b/drivers/net/phy/mediatek-ge.c @@ -23,9 +23,6 @@ static int mtk_gephy_write_page(struct phy_device *phydev, int page) static void mtk_gephy_config_init(struct phy_device *phydev) { - /* Disable EEE */ - phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_EEE_ADV, 0); - /* Enable HW auto downshift */ phy_modify_paged(phydev, MTK_PHY_PAGE_EXTENDED, 0x14, 0, BIT(4)); -- 2.40.1
WARNING: multiple messages have this Message-ID (diff)
From: "Arınç ÜNAL via B4 Relay" <devnull+arinc.unal.arinc9.com@kernel.org> To: "Daniel Golle" <daniel@makrotopia.org>, "DENG Qingfang" <dqfext@gmail.com>, "Sean Wang" <sean.wang@mediatek.com>, "Andrew Lunn" <andrew@lunn.ch>, "Florian Fainelli" <f.fainelli@gmail.com>, "Vladimir Oltean" <olteanv@gmail.com>, "David S. Miller" <davem@davemloft.net>, "Eric Dumazet" <edumazet@google.com>, "Jakub Kicinski" <kuba@kernel.org>, "Paolo Abeni" <pabeni@redhat.com>, "Matthias Brugger" <matthias.bgg@gmail.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, "René van Dorst" <opensource@vdorst.com>, "Russell King" <linux@armlinux.org.uk>, "SkyLake Huang" <SkyLake.Huang@mediatek.com>, "Heiner Kallweit" <hkallweit1@gmail.com> Cc: "Bartel Eerdekens" <bartel.eerdekens@constell8.be>, mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, "Arınç ÜNAL" <arinc.unal@arinc9.com> Subject: [PATCH 3/3] net: phy: mediatek-ge: do not disable EEE advertisement Date: Mon, 18 Mar 2024 10:46:25 +0300 [thread overview] Message-ID: <=?utf-8?q?=3C20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v?= =?utf-8?q?1-3-3f17226344e8=40arinc9=2Ecom=3E?=> (raw) In-Reply-To: =?utf-8?q?=3C20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-?= =?utf-8?q?v1-0-3f17226344e8=40arinc9=2Ecom=3E?= From: Arınç ÜNAL <arinc.unal@arinc9.com> There's no need to disable Energy-Efficient Ethernet (EEE) advertisement on the MT7530 and MT7531 switch PHYs. EEE works fine on MT7530 and MT7531 switch PHYs. Remove the code where EEE advertisement is disabled. This is a bugfix because there's a possible race condition where the mediatek-ge driver would kick in after the MT7530 DSA subdriver which would have EEE disabled until manually enabled. Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver") Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- drivers/net/phy/mediatek-ge.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c index a493ae01b267..54ea64a37ab3 100644 --- a/drivers/net/phy/mediatek-ge.c +++ b/drivers/net/phy/mediatek-ge.c @@ -23,9 +23,6 @@ static int mtk_gephy_write_page(struct phy_device *phydev, int page) static void mtk_gephy_config_init(struct phy_device *phydev) { - /* Disable EEE */ - phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_EEE_ADV, 0); - /* Enable HW auto downshift */ phy_modify_paged(phydev, MTK_PHY_PAGE_EXTENDED, 0x14, 0, BIT(4)); -- 2.40.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2024-03-18 7:47 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-18 7:46 Arınç ÜNAL via B4 Relay [this message] 2024-03-18 7:46 ` [PATCH 3/3] net: phy: mediatek-ge: do not disable EEE advertisement Arınç ÜNAL via B4 Relay -- strict thread matches above, loose matches on Subject: below -- 2024-03-18 7:46 [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch Arınç ÜNAL 2024-03-18 7:46 ` [PATCH 3/3] net: phy: mediatek-ge: do not disable EEE advertisement Arınç ÜNAL 2024-03-20 20:40 ` Arınç ÜNAL 2024-03-20 20:53 ` Russell King (Oracle) 2024-03-20 20:53 ` Russell King (Oracle) 2024-03-20 21:04 ` Arınç ÜNAL [not found] ` <65f7f17d.050a0220.c6db1.02bdSMTPIN_ADDED_BROKEN@mx.google.com> 2024-03-18 13:08 ` Florian Fainelli 2024-03-18 13:08 ` Florian Fainelli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='=?utf-8?q?=3C20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v?= =?utf-8?q?1-3-3f17226344e8=40arinc9=2Ecom=3E?=' \ --to=devnull+arinc.unal.arinc9.com@kernel.org \ --cc=SkyLake.Huang@mediatek.com \ --cc=andrew@lunn.ch \ --cc=angelogioacchino.delregno@collabora.com \ --cc=arinc.unal@arinc9.com \ --cc=bartel.eerdekens@constell8.be \ --cc=daniel@makrotopia.org \ --cc=davem@davemloft.net \ --cc=dqfext@gmail.com \ --cc=edumazet@google.com \ --cc=erkin.bozoglu@xeront.com \ --cc=f.fainelli@gmail.com \ --cc=hkallweit1@gmail.com \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux@armlinux.org.uk \ --cc=matthias.bgg@gmail.com \ --cc=mithat.guner@xeront.com \ --cc=netdev@vger.kernel.org \ --cc=olteanv@gmail.com \ --cc=opensource@vdorst.com \ --cc=pabeni@redhat.com \ --cc=sean.wang@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.