From: Kumar Gala <galak@codeaurora.org>
To: Josh Cartwright <joshc@codeaurora.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Ian Campbell <ian.campbell@citrix.com>,
Pawel Moll <pawel.moll@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Gilad Avidov <gavidov@codeaurora.org>,
linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Michael Bohan <mbohan@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
Grant Likely <grant.likely@linaro.org>,
Sagar Dharia <sdharia@codeaurora.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC 3/3] spmi: document the PMIC arbiter SPMI bindings
Date: Fri, 16 Aug 2013 14:48:59 -0500 [thread overview]
Message-ID: <A1FAB0A0-C205-4401-838C-B745B5B95FF3@codeaurora.org> (raw)
In-Reply-To: <20130816192549.GG4035@joshc.qualcomm.com>
On Aug 16, 2013, at 2:25 PM, Josh Cartwright wrote:
> Hey Kumar-
>
> Thanks for the review.
>
> On Fri, Aug 16, 2013 at 01:53:27PM -0500, Kumar Gala wrote:
>> On Aug 9, 2013, at 3:37 PM, Josh Cartwright wrote:
>>
>>> Signed-off-by: Josh Cartwright <joshc@codeaurora.org>
>>> ---
>>> .../devicetree/bindings/spmi/spmi-pmic-arb.txt | 26 ++++++++++++++++++++++
>>> 1 file changed, 26 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/spmi/spmi-pmic-arb.txt
>>
>> As this is a qcom specific binding, I think the file name should be msm-spmi-pmic-arb.txt or something like that.
>
> Agreed. It might be nice to use a vendor prefix in the name too. How's qcom,msm-pmic-arb.txt sound?
Sounds good, as I see we have other examples of having a comma in file names for bindings.
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: Kumar Gala <galak@codeaurora.org>
To: Josh Cartwright <joshc@codeaurora.org>
Cc: Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ian.campbell@citrix.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
Sagar Dharia <sdharia@codeaurora.org>,
Gilad Avidov <gavidov@codeaurora.org>,
Michael Bohan <mbohan@codeaurora.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH RFC 3/3] spmi: document the PMIC arbiter SPMI bindings
Date: Fri, 16 Aug 2013 14:48:59 -0500 [thread overview]
Message-ID: <A1FAB0A0-C205-4401-838C-B745B5B95FF3@codeaurora.org> (raw)
In-Reply-To: <20130816192549.GG4035@joshc.qualcomm.com>
On Aug 16, 2013, at 2:25 PM, Josh Cartwright wrote:
> Hey Kumar-
>
> Thanks for the review.
>
> On Fri, Aug 16, 2013 at 01:53:27PM -0500, Kumar Gala wrote:
>> On Aug 9, 2013, at 3:37 PM, Josh Cartwright wrote:
>>
>>> Signed-off-by: Josh Cartwright <joshc@codeaurora.org>
>>> ---
>>> .../devicetree/bindings/spmi/spmi-pmic-arb.txt | 26 ++++++++++++++++++++++
>>> 1 file changed, 26 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/spmi/spmi-pmic-arb.txt
>>
>> As this is a qcom specific binding, I think the file name should be msm-spmi-pmic-arb.txt or something like that.
>
> Agreed. It might be nice to use a vendor prefix in the name too. How's qcom,msm-pmic-arb.txt sound?
Sounds good, as I see we have other examples of having a comma in file names for bindings.
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: galak@codeaurora.org (Kumar Gala)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 3/3] spmi: document the PMIC arbiter SPMI bindings
Date: Fri, 16 Aug 2013 14:48:59 -0500 [thread overview]
Message-ID: <A1FAB0A0-C205-4401-838C-B745B5B95FF3@codeaurora.org> (raw)
In-Reply-To: <20130816192549.GG4035@joshc.qualcomm.com>
On Aug 16, 2013, at 2:25 PM, Josh Cartwright wrote:
> Hey Kumar-
>
> Thanks for the review.
>
> On Fri, Aug 16, 2013 at 01:53:27PM -0500, Kumar Gala wrote:
>> On Aug 9, 2013, at 3:37 PM, Josh Cartwright wrote:
>>
>>> Signed-off-by: Josh Cartwright <joshc@codeaurora.org>
>>> ---
>>> .../devicetree/bindings/spmi/spmi-pmic-arb.txt | 26 ++++++++++++++++++++++
>>> 1 file changed, 26 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/spmi/spmi-pmic-arb.txt
>>
>> As this is a qcom specific binding, I think the file name should be msm-spmi-pmic-arb.txt or something like that.
>
> Agreed. It might be nice to use a vendor prefix in the name too. How's qcom,msm-pmic-arb.txt sound?
Sounds good, as I see we have other examples of having a comma in file names for bindings.
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2013-08-16 19:48 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 19:50 [PATCH RFC 0/3] Add support for the System Power Management Interface (SPMI) Josh Cartwright
2013-08-15 19:50 ` Josh Cartwright
2013-08-09 20:37 ` [PATCH RFC 2/3] spmi: Add MSM PMIC Arbiter SPMI controller Josh Cartwright
2013-08-09 20:37 ` Josh Cartwright
2013-08-16 18:52 ` Greg Kroah-Hartman
2013-08-16 18:52 ` Greg Kroah-Hartman
2013-08-09 20:37 ` [PATCH RFC 1/3] spmi: Linux driver framework for SPMI Josh Cartwright
2013-08-09 20:37 ` Josh Cartwright
2013-08-16 18:46 ` Greg Kroah-Hartman
2013-08-16 18:46 ` Greg Kroah-Hartman
2013-08-16 19:47 ` Josh Cartwright
2013-08-16 19:47 ` Josh Cartwright
2013-08-16 19:47 ` Josh Cartwright
2013-08-16 19:50 ` Josh Cartwright
2013-08-16 19:50 ` Josh Cartwright
2013-08-16 19:50 ` Josh Cartwright
2013-08-16 19:58 ` Greg Kroah-Hartman
2013-08-16 19:58 ` Greg Kroah-Hartman
2013-08-16 19:58 ` Greg Kroah-Hartman
2013-08-16 20:40 ` Josh Cartwright
2013-08-16 20:40 ` Josh Cartwright
2013-08-16 20:40 ` Josh Cartwright
2013-08-16 20:50 ` Greg Kroah-Hartman
2013-08-16 20:50 ` Greg Kroah-Hartman
2013-08-16 20:50 ` Greg Kroah-Hartman
2013-08-16 18:49 ` Greg Kroah-Hartman
2013-08-16 18:49 ` Greg Kroah-Hartman
2013-08-16 20:21 ` Josh Cartwright
2013-08-16 20:21 ` Josh Cartwright
2013-08-16 20:21 ` Josh Cartwright
2013-08-16 20:28 ` Greg Kroah-Hartman
2013-08-16 20:28 ` Greg Kroah-Hartman
2013-08-16 20:28 ` Greg Kroah-Hartman
2013-08-16 19:04 ` Kumar Gala
2013-08-16 19:04 ` Kumar Gala
2013-08-16 19:04 ` Kumar Gala
[not found] ` <b639088d50df93caaef8fe7e09c12953b1153ce8.1376596224.git.joshc@codeaurora.org>
[not found] ` <D1534646-7CB5-4EE7-8C1E-1C607BE22396@codeaurora.org>
2013-08-16 19:25 ` [PATCH RFC 3/3] spmi: document the PMIC arbiter SPMI bindings Josh Cartwright
2013-08-16 19:25 ` Josh Cartwright
2013-08-16 19:25 ` Josh Cartwright
2013-08-16 19:48 ` Kumar Gala [this message]
2013-08-16 19:48 ` Kumar Gala
2013-08-16 19:48 ` Kumar Gala
2013-08-16 23:17 ` Stephen Warren
2013-08-16 23:17 ` Stephen Warren
2013-08-16 23:17 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A1FAB0A0-C205-4401-838C-B745B5B95FF3@codeaurora.org \
--to=galak@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=gavidov@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ian.campbell@citrix.com \
--cc=joshc@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mbohan@codeaurora.org \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=sdharia@codeaurora.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.