Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks

From: Nadav Amit <nadav.amit@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Nadav Amit <namit@cs.technion.ac.il>,
	Jan Kiszka <jan.kiszka@siemens.com>, Bandan Das <bsd@redhat.com>,
	qemu-devel@nongnu.org, kvm list <kvm@vger.kernel.org>,
	avi.kivity@gmail.com
Subject: Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks
Date: Mon, 13 Apr 2015 17:33:03 +0300	[thread overview]
Message-ID: <A2299E90-8DFA-49B7-884E-F90179D46BE5@gmail.com> (raw)
In-Reply-To: <552BD1B7.4080103@redhat.com>

Paolo Bonzini <pbonzini@redhat.com> wrote:

> 
> 
> On 13/04/2015 16:17, Nadav Amit wrote:
>> Paolo Bonzini <pbonzini@redhat.com> wrote:
>> 
>>> On 13/04/2015 01:32, Nadav Amit wrote:
>>>> +    if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) {
>>> 
>>> The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not
>>> KVM_CAP_ENABLE_CAP_VM.
>>> 
>>> Paolo
>>> 
>>>> +        ret = kvm_vm_enable_cap(s, KVM_CAP_DISABLE_QUIRKS, 0,
>>>> +                                KVM_QUIRK_LINT0_DISABLED |
>>>> +                                KVM_QUIRK_CD_NW_CLEARED);
>>>> +        if (ret < 0) {
>>>> +            return ret;
>>>> +        }
>>>> +    }
>> 
>> Of course…
>> Do you want a v2 now, later (after 4.2), or would you change it yourself?
> 
> Later, close to 4.2 but not necessarily after it.

Anyhow, in that case the KVM patch is also wrong (not reporting
KVM_CAP_DISABLE_QUIRKS is supported). I don’t want to spam, so I’ll run some
tests and resubmit.

Nadav