From: "Tian, Kevin" <kevin.tian@intel.com> To: Jacob Pan <jacob.jun.pan@linux.intel.com>, Lu Baolu <baolu.lu@linux.intel.com>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Joerg Roedel <joro@8bytes.org>, David Woodhouse <dwmw2@infradead.org>, "Alex Williamson" <alex.williamson@redhat.com>, Jean-Philippe Brucker <jean-philippe@linaro.com> Cc: "Liu, Yi L" <yi.l.liu@intel.com>, "Raj, Ashok" <ashok.raj@intel.com>, Christoph Hellwig <hch@infradead.org>, Jonathan Cameron <jic23@kernel.org>, Eric Auger <eric.auger@redhat.com> Subject: RE: [PATCH V10 04/11] iommu/vt-d: Use helper function to skip agaw for SL Date: Fri, 27 Mar 2020 11:55:09 +0000 [thread overview] Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D19D7ED91C@SHSMSX104.ccr.corp.intel.com> (raw) In-Reply-To: <1584746861-76386-5-git-send-email-jacob.jun.pan@linux.intel.com> > From: Jacob Pan <jacob.jun.pan@linux.intel.com> > Sent: Saturday, March 21, 2020 7:28 AM > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> > --- > drivers/iommu/intel-pasid.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/drivers/iommu/intel-pasid.c b/drivers/iommu/intel-pasid.c > index 191508c7c03e..9bdb7ee228b6 100644 > --- a/drivers/iommu/intel-pasid.c > +++ b/drivers/iommu/intel-pasid.c > @@ -544,17 +544,11 @@ int intel_pasid_setup_second_level(struct > intel_iommu *iommu, > return -EINVAL; > } > > - /* > - * Skip top levels of page tables for iommu which has less agaw > - * than default. Unnecessary for PT mode. > - */ > pgd = domain->pgd; > - for (agaw = domain->agaw; agaw > iommu->agaw; agaw--) { > - pgd = phys_to_virt(dma_pte_addr(pgd)); > - if (!dma_pte_present(pgd)) { > - dev_err(dev, "Invalid domain page table\n"); > - return -EINVAL; > - } > + agaw = iommu_skip_agaw(domain, iommu, &pgd); > + if (agaw < 0) { > + dev_err(dev, "Invalid domain page table\n"); > + return -EINVAL; > } ok, I see how it is used. possibly combine last and this one together since it's mostly moving code... > > pgd_val = virt_to_phys(pgd); > -- > 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: "Tian, Kevin" <kevin.tian@intel.com> To: Jacob Pan <jacob.jun.pan@linux.intel.com>, Lu Baolu <baolu.lu@linux.intel.com>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Joerg Roedel <joro@8bytes.org>, David Woodhouse <dwmw2@infradead.org>, "Alex Williamson" <alex.williamson@redhat.com>, Jean-Philippe Brucker <jean-philippe@linaro.com> Cc: "Raj, Ashok" <ashok.raj@intel.com>, Jonathan Cameron <jic23@kernel.org> Subject: RE: [PATCH V10 04/11] iommu/vt-d: Use helper function to skip agaw for SL Date: Fri, 27 Mar 2020 11:55:09 +0000 [thread overview] Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D19D7ED91C@SHSMSX104.ccr.corp.intel.com> (raw) In-Reply-To: <1584746861-76386-5-git-send-email-jacob.jun.pan@linux.intel.com> > From: Jacob Pan <jacob.jun.pan@linux.intel.com> > Sent: Saturday, March 21, 2020 7:28 AM > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> > --- > drivers/iommu/intel-pasid.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/drivers/iommu/intel-pasid.c b/drivers/iommu/intel-pasid.c > index 191508c7c03e..9bdb7ee228b6 100644 > --- a/drivers/iommu/intel-pasid.c > +++ b/drivers/iommu/intel-pasid.c > @@ -544,17 +544,11 @@ int intel_pasid_setup_second_level(struct > intel_iommu *iommu, > return -EINVAL; > } > > - /* > - * Skip top levels of page tables for iommu which has less agaw > - * than default. Unnecessary for PT mode. > - */ > pgd = domain->pgd; > - for (agaw = domain->agaw; agaw > iommu->agaw; agaw--) { > - pgd = phys_to_virt(dma_pte_addr(pgd)); > - if (!dma_pte_present(pgd)) { > - dev_err(dev, "Invalid domain page table\n"); > - return -EINVAL; > - } > + agaw = iommu_skip_agaw(domain, iommu, &pgd); > + if (agaw < 0) { > + dev_err(dev, "Invalid domain page table\n"); > + return -EINVAL; > } ok, I see how it is used. possibly combine last and this one together since it's mostly moving code... > > pgd_val = virt_to_phys(pgd); > -- > 2.7.4 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-03-27 11:55 UTC|newest] Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-20 23:27 [PATCH V10 00/11] Nested Shared Virtual Address (SVA) VT-d support Jacob Pan 2020-03-20 23:27 ` Jacob Pan 2020-03-20 23:27 ` [PATCH V10 01/11] iommu/vt-d: Move domain helper to header Jacob Pan 2020-03-20 23:27 ` Jacob Pan 2020-03-27 11:48 ` Tian, Kevin 2020-03-27 11:48 ` Tian, Kevin 2020-03-20 23:27 ` [PATCH V10 02/11] iommu/uapi: Define a mask for bind data Jacob Pan 2020-03-20 23:27 ` Jacob Pan 2020-03-22 1:29 ` Lu Baolu 2020-03-22 1:29 ` Lu Baolu 2020-03-23 19:37 ` Jacob Pan 2020-03-23 19:37 ` Jacob Pan 2020-03-24 1:50 ` Lu Baolu 2020-03-24 1:50 ` Lu Baolu 2020-03-27 11:50 ` Tian, Kevin 2020-03-27 11:50 ` Tian, Kevin 2020-03-27 14:13 ` Auger Eric 2020-03-27 14:13 ` Auger Eric 2020-03-20 23:27 ` [PATCH V10 03/11] iommu/vt-d: Add a helper function to skip agaw Jacob Pan 2020-03-20 23:27 ` Jacob Pan 2020-03-27 11:53 ` Tian, Kevin 2020-03-27 11:53 ` Tian, Kevin 2020-03-29 7:20 ` Lu Baolu 2020-03-29 7:20 ` Lu Baolu 2020-03-30 17:50 ` Jacob Pan 2020-03-30 17:50 ` Jacob Pan 2020-03-20 23:27 ` [PATCH V10 04/11] iommu/vt-d: Use helper function to skip agaw for SL Jacob Pan 2020-03-20 23:27 ` Jacob Pan 2020-03-27 11:55 ` Tian, Kevin [this message] 2020-03-27 11:55 ` Tian, Kevin 2020-03-27 16:05 ` Auger Eric 2020-03-27 16:05 ` Auger Eric 2020-03-29 7:35 ` Lu Baolu 2020-03-29 7:35 ` Lu Baolu 2020-03-20 23:27 ` [PATCH V10 05/11] iommu/vt-d: Add nested translation helper function Jacob Pan 2020-03-20 23:27 ` Jacob Pan 2020-03-26 10:41 ` kbuild test robot 2020-03-27 12:21 ` Tian, Kevin 2020-03-27 12:21 ` Tian, Kevin 2020-03-29 8:03 ` Lu Baolu 2020-03-29 8:03 ` Lu Baolu 2020-03-30 18:21 ` Jacob Pan 2020-03-30 18:21 ` Jacob Pan 2020-03-31 3:36 ` Tian, Kevin 2020-03-31 3:36 ` Tian, Kevin 2020-03-29 11:35 ` Auger Eric 2020-03-29 11:35 ` Auger Eric 2020-04-01 20:06 ` Jacob Pan 2020-04-01 20:06 ` Jacob Pan 2020-03-20 23:27 ` [PATCH V10 06/11] iommu/vt-d: Add bind guest PASID support Jacob Pan 2020-03-20 23:27 ` Jacob Pan 2020-03-28 8:02 ` Tian, Kevin 2020-03-28 8:02 ` Tian, Kevin 2020-03-30 20:51 ` Jacob Pan 2020-03-30 20:51 ` Jacob Pan 2020-03-31 3:43 ` Tian, Kevin 2020-03-31 3:43 ` Tian, Kevin 2020-04-01 17:13 ` Jacob Pan 2020-04-01 17:13 ` Jacob Pan 2020-03-29 13:40 ` Auger Eric 2020-03-29 13:40 ` Auger Eric 2020-03-30 22:53 ` Jacob Pan 2020-03-30 22:53 ` Jacob Pan 2020-03-20 23:27 ` [PATCH V10 07/11] iommu/vt-d: Support flushing more translation cache types Jacob Pan 2020-03-20 23:27 ` Jacob Pan 2020-03-27 14:46 ` Auger Eric 2020-03-27 14:46 ` Auger Eric 2020-03-30 23:28 ` Jacob Pan 2020-03-30 23:28 ` Jacob Pan 2020-03-31 16:13 ` Jacob Pan 2020-03-31 16:13 ` Jacob Pan 2020-03-31 16:15 ` Auger Eric 2020-03-31 16:15 ` Auger Eric 2020-03-20 23:27 ` [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function Jacob Pan 2020-03-20 23:27 ` Jacob Pan 2020-03-28 10:01 ` Tian, Kevin 2020-03-28 10:01 ` Tian, Kevin 2020-03-29 15:34 ` Auger Eric 2020-03-29 15:34 ` Auger Eric 2020-03-31 2:49 ` Tian, Kevin 2020-03-31 2:49 ` Tian, Kevin 2020-03-31 20:58 ` Jacob Pan 2020-03-31 20:58 ` Jacob Pan 2020-04-01 6:29 ` Tian, Kevin 2020-04-01 6:29 ` Tian, Kevin 2020-04-01 7:13 ` Liu, Yi L 2020-04-01 7:13 ` Liu, Yi L 2020-04-01 7:32 ` Auger Eric 2020-04-01 7:32 ` Auger Eric 2020-04-01 16:05 ` Jacob Pan 2020-04-01 16:05 ` Jacob Pan 2020-04-02 15:54 ` Jacob Pan 2020-04-02 15:54 ` Jacob Pan 2020-03-29 16:05 ` Auger Eric 2020-03-29 16:05 ` Auger Eric 2020-03-31 3:34 ` Tian, Kevin 2020-03-31 3:34 ` Tian, Kevin 2020-03-31 21:07 ` Jacob Pan 2020-03-31 21:07 ` Jacob Pan 2020-04-01 6:32 ` Tian, Kevin 2020-04-01 6:32 ` Tian, Kevin 2020-03-31 18:13 ` Jacob Pan 2020-03-31 18:13 ` Jacob Pan 2020-04-01 6:24 ` Tian, Kevin 2020-04-01 6:24 ` Tian, Kevin 2020-04-01 6:57 ` Liu, Yi L 2020-04-01 6:57 ` Liu, Yi L 2020-04-01 16:03 ` Jacob Pan 2020-04-01 16:03 ` Jacob Pan 2020-03-29 16:05 ` Auger Eric 2020-03-29 16:05 ` Auger Eric 2020-03-31 22:28 ` Jacob Pan 2020-03-31 22:28 ` Jacob Pan 2020-03-20 23:27 ` [PATCH V10 09/11] iommu/vt-d: Cache virtual command capability register Jacob Pan 2020-03-20 23:27 ` Jacob Pan 2020-03-28 10:04 ` Tian, Kevin 2020-03-28 10:04 ` Tian, Kevin 2020-03-31 22:33 ` Jacob Pan 2020-03-31 22:33 ` Jacob Pan 2020-03-20 23:27 ` [PATCH V10 10/11] iommu/vt-d: Enlightened PASID allocation Jacob Pan 2020-03-20 23:27 ` Jacob Pan 2020-03-28 10:08 ` Tian, Kevin 2020-03-28 10:08 ` Tian, Kevin 2020-03-31 22:37 ` Jacob Pan 2020-03-31 22:37 ` Jacob Pan 2020-03-20 23:27 ` [PATCH V10 11/11] iommu/vt-d: Add custom allocator for IOASID Jacob Pan 2020-03-20 23:27 ` Jacob Pan 2020-03-28 10:22 ` Tian, Kevin 2020-03-28 10:22 ` Tian, Kevin 2020-04-01 15:47 ` Jacob Pan 2020-04-01 15:47 ` Jacob Pan 2020-04-02 2:18 ` Tian, Kevin 2020-04-02 2:18 ` Tian, Kevin 2020-04-02 20:28 ` Jacob Pan 2020-04-02 20:28 ` Jacob Pan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AADFC41AFE54684AB9EE6CBC0274A5D19D7ED91C@SHSMSX104.ccr.corp.intel.com \ --to=kevin.tian@intel.com \ --cc=alex.williamson@redhat.com \ --cc=ashok.raj@intel.com \ --cc=baolu.lu@linux.intel.com \ --cc=dwmw2@infradead.org \ --cc=eric.auger@redhat.com \ --cc=hch@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@linux.intel.com \ --cc=jean-philippe@linaro.com \ --cc=jic23@kernel.org \ --cc=joro@8bytes.org \ --cc=linux-kernel@vger.kernel.org \ --cc=yi.l.liu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.