oFono exits on new voicecall with disconnected system bus

oFono exits on new voicecall with disconnected system bus

[Nicola Mfb]

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

Hi!
that's happen with oFono 0.38 on freerunner with debian sid on the
first incoming/outgoing call:

ofonod[6232]: drivers/calypsomodem/voicecall.c:cpi_notify() id:1,
msgtype:0, direction:1, mode:0
ofonod[6232]: drivers/calypsomodem/voicecall.c:cpi_notify() Len > 0
ofonod[6232]: drivers/calypsomodem/voicecall.c:cpi_notify() type obtained
ofonod[6232]: drivers/calypsomodem/voicecall.c:cpi_notify()
num:+xxxxxxxxxxxx, type:145
ofonod[6232]: drivers/calypsomodem/voicecall.c:cpi_notify() cause:892800, line:0
ofonod[6232]: src/voicecall.c:ofono_voicecall_notify() Got a voicecall
event, status: 4, id: 1, number: +xxxxxxxxxxx
ofonod[6232]: src/voicecall.c:ofono_voicecall_notify() Did not find a
call with id: 1
ofonod[6232]: System bus has disconnected!

Sometimes (about 1 of 10) oFono runs fine and survives to multiple voice calls.

Any suggestion?

Regards

    Niko

Re: oFono exits on new voicecall with disconnected system bus

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]

Hi Nicola,

> that's happen with oFono 0.38 on freerunner with debian sid on the
> first incoming/outgoing call:
> 
> ofonod[6232]: drivers/calypsomodem/voicecall.c:cpi_notify() id:1,
> msgtype:0, direction:1, mode:0
> ofonod[6232]: drivers/calypsomodem/voicecall.c:cpi_notify() Len > 0
> ofonod[6232]: drivers/calypsomodem/voicecall.c:cpi_notify() type obtained
> ofonod[6232]: drivers/calypsomodem/voicecall.c:cpi_notify()
> num:+xxxxxxxxxxxx, type:145
> ofonod[6232]: drivers/calypsomodem/voicecall.c:cpi_notify() cause:892800, line:0
> ofonod[6232]: src/voicecall.c:ofono_voicecall_notify() Got a voicecall
> event, status: 4, id: 1, number: +xxxxxxxxxxx
> ofonod[6232]: src/voicecall.c:ofono_voicecall_notify() Did not find a
> call with id: 1
> ofonod[6232]: System bus has disconnected!

this happens if something in a D-Bus message is corrupted and the D-Bus
daemon complains. The result is that it kicks us off the bus.

You need to track down which D-Bus API call causes this. Wild assumption
is that it is either a wrong message parameter or an invalid object
path.

Regards

Marcel

Re: oFono exits on new voicecall with disconnected system bus

[Nicola Mfb]

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

On Thu, Jan 20, 2011 at 3:55 PM, Marcel Holtmann <marcel@holtmann.org> wrote:

> Hi Nicola,

Hi Marcel,

[...]

>> ofonod[6232]: src/voicecall.c:ofono_voicecall_notify() Did not find a
>> call with id: 1
>> ofonod[6232]: System bus has disconnected!
>
> this happens if something in a D-Bus message is corrupted and the D-Bus
> daemon complains. The result is that it kicks us off the bus.
>
> You need to track down which D-Bus API call causes this. Wild assumption
> is that it is either a wrong message parameter or an invalid object
> path.

It seems that in src/voicecall.c/append_voicecall_properties "name"
points to garbage as commenting the line:
ofono_dbus_dict_append(dict, "Name", DBUS_TYPE_STRING, &name);
fixes the problem.

Regards

     Niko

Re: oFono exits on new voicecall with disconnected system bus

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

Hi Nicola,

> >> ofonod[6232]: src/voicecall.c:ofono_voicecall_notify() Did not find a
> >> call with id: 1
> >> ofonod[6232]: System bus has disconnected!
> >
> > this happens if something in a D-Bus message is corrupted and the D-Bus
> > daemon complains. The result is that it kicks us off the bus.
> >
> > You need to track down which D-Bus API call causes this. Wild assumption
> > is that it is either a wrong message parameter or an invalid object
> > path.
> 
> It seems that in src/voicecall.c/append_voicecall_properties "name"
> points to garbage as commenting the line:
> ofono_dbus_dict_append(dict, "Name", DBUS_TYPE_STRING, &name);
> fixes the problem.

can you print the content of name and call->name fields as part of a
debug statement. I like to see what is in there.

At least the pointer should be valid since it pointers to call->name
array. Maybe the content is just not UTF-8 string.

Regards

Marcel

Re: oFono exits on new voicecall with disconnected system bus

[Nicola Mfb]

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

On Fri, Jan 21, 2011 at 11:29 AM, Marcel Holtmann <marcel@holtmann.org> wrote:

[...]

>> It seems that in src/voicecall.c/append_voicecall_properties "name"
>> points to garbage as commenting the line:
>> ofono_dbus_dict_append(dict, "Name", DBUS_TYPE_STRING, &name);
>> fixes the problem.
>
> can you print the content of name and call->name fields as part of a
> debug statement. I like to see what is in there.
>
> At least the pointer should be valid since it pointers to call->name
> array. Maybe the content is just not UTF-8 string.


        ofono_dbus_dict_append(dict, "LineIdentification",
                                DBUS_TYPE_STRING, &callerid);

        DBG("name %s call->name %s", name, call->name);
        ofono_dbus_dict_append(dict, "Name", DBUS_TYPE_STRING, &name);


ofonod[5771]: src/voicecall.c:ofono_voicecall_notify() Did not find a
call with id: 1
ofonod[5771]: src/voicecall.c:append_voicecall_properties() name ��+@
call->name ��+@
ofonod[5771]: System bus has disconnected!

     Niko

Re: oFono exits on new voicecall with disconnected system bus

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]

Hi Nicola,

> >> It seems that in src/voicecall.c/append_voicecall_properties "name"
> >> points to garbage as commenting the line:
> >> ofono_dbus_dict_append(dict, "Name", DBUS_TYPE_STRING, &name);
> >> fixes the problem.
> >
> > can you print the content of name and call->name fields as part of a
> > debug statement. I like to see what is in there.
> >
> > At least the pointer should be valid since it pointers to call->name
> > array. Maybe the content is just not UTF-8 string.
> 
> 
>         ofono_dbus_dict_append(dict, "LineIdentification",
>                                 DBUS_TYPE_STRING, &callerid);
> 
>         DBG("name %s call->name %s", name, call->name);
>         ofono_dbus_dict_append(dict, "Name", DBUS_TYPE_STRING, &name);
> 
> 
> ofonod[5771]: src/voicecall.c:ofono_voicecall_notify() Did not find a
> call with id: 1
> ofonod[5771]: src/voicecall.c:append_voicecall_properties() name ��+@
> call->name ��+@
> ofonod[5771]: System bus has disconnected!

I bet this is not a valid UTF-8 string. So somewhere along the code the
call->name array got not initialized as 0.

Regards

Marcel

Re: oFono exits on new voicecall with disconnected system bus

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]

Hi Nicola,

> >> It seems that in src/voicecall.c/append_voicecall_properties "name"
> >> points to garbage as commenting the line:
> >> ofono_dbus_dict_append(dict, "Name", DBUS_TYPE_STRING, &name);
> >> fixes the problem.
> >
> > can you print the content of name and call->name fields as part of a
> > debug statement. I like to see what is in there.
> >
> > At least the pointer should be valid since it pointers to call->name
> > array. Maybe the content is just not UTF-8 string.
> 
> 
>         ofono_dbus_dict_append(dict, "LineIdentification",
>                                 DBUS_TYPE_STRING, &callerid);
> 
>         DBG("name %s call->name %s", name, call->name);
>         ofono_dbus_dict_append(dict, "Name", DBUS_TYPE_STRING, &name);
> 
> 
> ofonod[5771]: src/voicecall.c:ofono_voicecall_notify() Did not find a
> call with id: 1
> ofonod[5771]: src/voicecall.c:append_voicecall_properties() name ��+@
> call->name ��+@
> ofonod[5771]: System bus has disconnected!

I think that I found the problem. Pushed a patch for it. Please re-test
if this helps. The Calypso driver was using stack memory for the call
object.

Regards

Marcel

Re: oFono exits on new voicecall with disconnected system bus

[Nicola Mfb]

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

On Fri, Jan 21, 2011 at 1:10 PM, Marcel Holtmann <marcel@holtmann.org> wrote:

Hi Marcel,

[...]

>> ofonod[5771]: src/voicecall.c:ofono_voicecall_notify() Did not find a
>> call with id: 1
>> ofonod[5771]: src/voicecall.c:append_voicecall_properties() name ��+@
>> call->name ��+@
>> ofonod[5771]: System bus has disconnected!
>
> I think that I found the problem. Pushed a patch for it. Please re-test
> if this helps. The Calypso driver was using stack memory for the call
> object.

Yes, it works fine now, going further ;)

Regards

    Niko