[PATCH] dma: imx-dma: fix imxdma_probe error path

[PATCH] dma: imx-dma: fix imxdma_probe error path

[Axel Lin]

otherwise, i will be -1 inside the latest iteration of the while loop.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/dma/imx-dma.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
index f629e49..e53d438 100644
--- a/drivers/dma/imx-dma.c
+++ b/drivers/dma/imx-dma.c
@@ -379,7 +379,7 @@ static int __init imxdma_probe(struct platform_device *pdev)
 	return 0;
 
 err_init:
-	while (i-- >= 0) {
+	while (--i >= 0) {
 		struct imxdma_channel *imxdmac = &imxdma->channel[i];
 		imx_dma_free(imxdmac->imxdma_channel);
 	}
-- 
1.7.2

Re: [PATCH] dma: imx-dma: fix imxdma_probe error path

[Thiago Farina]

On Mon, Nov 1, 2010 at 11:12 PM, Axel Lin <axel.lin@gmail.com> wrote:
> otherwise, i will be -1 inside the latest iteration of the while loop.
>
nit: s/otherwise, i will be/Otherwise, it will be ?

Re: [PATCH] dma: imx-dma: fix imxdma_probe error path

[Axel Lin]

2010/11/2 Thiago Farina <tfransosi@gmail.com>:
> On Mon, Nov 1, 2010 at 11:12 PM, Axel Lin <axel.lin@gmail.com> wrote:
>> otherwise, i will be -1 inside the latest iteration of the while loop.
>>
> nit: s/otherwise, i will be/Otherwise, it will be ?

I mean the i variable will become -1 inside the latest iteration of
the while loop.

Should I resend the patch?

Regards,
Axel

Re: [PATCH] dma: imx-dma: fix imxdma_probe error path

[Thiago Farina]

On Mon, Nov 1, 2010 at 11:30 PM, Axel Lin <axel.lin@gmail.com> wrote:
> 2010/11/2 Thiago Farina <tfransosi@gmail.com>:
>> On Mon, Nov 1, 2010 at 11:12 PM, Axel Lin <axel.lin@gmail.com> wrote:
>>> otherwise, i will be -1 inside the latest iteration of the while loop.
>>>
>> nit: s/otherwise, i will be/Otherwise, it will be ?
>
> I mean the i variable will become -1 inside the latest iteration of
> the while loop.
>
> Should I resend the patch?
>
Your call, as I got confused others can get confused too.

Re: [PATCH] dma: imx-dma: fix imxdma_probe error path

[Dan Williams]

On Mon, Nov 1, 2010 at 6:12 PM, Axel Lin <axel.lin@gmail.com> wrote:
> otherwise, i will be -1 inside the latest iteration of the while loop.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---

Catching up on the backlog... applied.