* [PATCH] dma: imx-dma: fix imxdma_probe error path
@ 2010-11-02 1:12 Axel Lin
2010-11-02 1:28 ` Thiago Farina
2010-12-03 9:36 ` Dan Williams
0 siblings, 2 replies; 5+ messages in thread
From: Axel Lin @ 2010-11-02 1:12 UTC (permalink / raw)
To: linux-kernel; +Cc: Pengutronix, Dan Williams
otherwise, i will be -1 inside the latest iteration of the while loop.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/dma/imx-dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
index f629e49..e53d438 100644
--- a/drivers/dma/imx-dma.c
+++ b/drivers/dma/imx-dma.c
@@ -379,7 +379,7 @@ static int __init imxdma_probe(struct platform_device *pdev)
return 0;
err_init:
- while (i-- >= 0) {
+ while (--i >= 0) {
struct imxdma_channel *imxdmac = &imxdma->channel[i];
imx_dma_free(imxdmac->imxdma_channel);
}
--
1.7.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dma: imx-dma: fix imxdma_probe error path
2010-11-02 1:12 [PATCH] dma: imx-dma: fix imxdma_probe error path Axel Lin
@ 2010-11-02 1:28 ` Thiago Farina
2010-11-02 1:30 ` Axel Lin
2010-12-03 9:36 ` Dan Williams
1 sibling, 1 reply; 5+ messages in thread
From: Thiago Farina @ 2010-11-02 1:28 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Pengutronix, Dan Williams
On Mon, Nov 1, 2010 at 11:12 PM, Axel Lin <axel.lin@gmail.com> wrote:
> otherwise, i will be -1 inside the latest iteration of the while loop.
>
nit: s/otherwise, i will be/Otherwise, it will be ?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dma: imx-dma: fix imxdma_probe error path
2010-11-02 1:28 ` Thiago Farina
@ 2010-11-02 1:30 ` Axel Lin
2010-11-02 1:45 ` Thiago Farina
0 siblings, 1 reply; 5+ messages in thread
From: Axel Lin @ 2010-11-02 1:30 UTC (permalink / raw)
To: Thiago Farina; +Cc: linux-kernel, Pengutronix, Dan Williams
2010/11/2 Thiago Farina <tfransosi@gmail.com>:
> On Mon, Nov 1, 2010 at 11:12 PM, Axel Lin <axel.lin@gmail.com> wrote:
>> otherwise, i will be -1 inside the latest iteration of the while loop.
>>
> nit: s/otherwise, i will be/Otherwise, it will be ?
I mean the i variable will become -1 inside the latest iteration of
the while loop.
Should I resend the patch?
Regards,
Axel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dma: imx-dma: fix imxdma_probe error path
2010-11-02 1:30 ` Axel Lin
@ 2010-11-02 1:45 ` Thiago Farina
0 siblings, 0 replies; 5+ messages in thread
From: Thiago Farina @ 2010-11-02 1:45 UTC (permalink / raw)
To: axel.lin; +Cc: linux-kernel, Pengutronix, Dan Williams
On Mon, Nov 1, 2010 at 11:30 PM, Axel Lin <axel.lin@gmail.com> wrote:
> 2010/11/2 Thiago Farina <tfransosi@gmail.com>:
>> On Mon, Nov 1, 2010 at 11:12 PM, Axel Lin <axel.lin@gmail.com> wrote:
>>> otherwise, i will be -1 inside the latest iteration of the while loop.
>>>
>> nit: s/otherwise, i will be/Otherwise, it will be ?
>
> I mean the i variable will become -1 inside the latest iteration of
> the while loop.
>
> Should I resend the patch?
>
Your call, as I got confused others can get confused too.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dma: imx-dma: fix imxdma_probe error path
2010-11-02 1:12 [PATCH] dma: imx-dma: fix imxdma_probe error path Axel Lin
2010-11-02 1:28 ` Thiago Farina
@ 2010-12-03 9:36 ` Dan Williams
1 sibling, 0 replies; 5+ messages in thread
From: Dan Williams @ 2010-12-03 9:36 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Pengutronix
On Mon, Nov 1, 2010 at 6:12 PM, Axel Lin <axel.lin@gmail.com> wrote:
> otherwise, i will be -1 inside the latest iteration of the while loop.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
Catching up on the backlog... applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-12-03 9:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-02 1:12 [PATCH] dma: imx-dma: fix imxdma_probe error path Axel Lin
2010-11-02 1:28 ` Thiago Farina
2010-11-02 1:30 ` Axel Lin
2010-11-02 1:45 ` Thiago Farina
2010-12-03 9:36 ` Dan Williams
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.