All of lore.kernel.org
 help / color / mirror / Atom feed
From: pl bossart <bossart.nospam@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] pcm: pass hw_params flags to slave
Date: Tue, 2 Nov 2010 07:52:58 -0500	[thread overview]
Message-ID: <AANLkTimN7R3W6w4NQLpLbVmby6jFaBR=Lg3120vs7xLs@mail.gmail.com> (raw)
In-Reply-To: <s5heib418z5.wl%tiwai@suse.de>

Thanks Takashi for the review.

> I'm a bit skeptical whether this is safe to apply.
> The plugins might not be always transparent.  Double-check whether
> this doesn't break all plugins behaviors.

I am really not sure how I can prove that passing flags does not alter
existing behavior, I identified this issue experimentally after
several hours and I must admit I don't really understand the alsa-lib
code.
The question is really why weren't the flags propagated in the initial
code? All parameters (info, rate, etc) are passed to the slave, except
the flags. Either this was a conscious design decision, in which case
my patch would create a problem, or this was a miss and my patch
corrects it.

>>       params->info &= src->info;
>> +        params->flags = src->flags; /* propagate flags to slave */

      reply	other threads:[~2010-11-02 12:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-01 22:13 [PATCH 1/2] pcm: pass hw_params flags to slave Pierre-Louis Bossart
2010-11-01 22:13 ` [PATCH 2/2] add API to allow disabling period interrupt Pierre-Louis Bossart
2010-11-02  7:28   ` Takashi Iwai
2010-11-02  8:23   ` Clemens Ladisch
2010-11-02  8:34     ` Jaroslav Kysela
2010-11-02  8:38     ` Jaroslav Kysela
2010-11-02  9:04       ` Clemens Ladisch
2010-11-02  9:52         ` Jaroslav Kysela
2010-11-02 13:12           ` pl bossart
2010-11-03  7:38             ` Jaroslav Kysela
2010-11-08 20:58               ` pl bossart
2010-11-08 21:03                 ` Jaroslav Kysela
2010-11-02  7:27 ` [PATCH 1/2] pcm: pass hw_params flags to slave Takashi Iwai
2010-11-02 12:52   ` pl bossart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTimN7R3W6w4NQLpLbVmby6jFaBR=Lg3120vs7xLs@mail.gmail.com' \
    --to=bossart.nospam@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.