All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaroslav Kysela <perex@perex.cz>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: Pierre-Louis Bossart <bossart.nospam@gmail.com>,
	alsa-devel@alsa-project.org,
	Pierre-Louis Bossart <pierre-louis.bossart@intel.com>
Subject: Re: [PATCH 2/2] add API to allow disabling period interrupt
Date: Tue, 2 Nov 2010 09:38:10 +0100 (CET)	[thread overview]
Message-ID: <alpine.LNX.2.00.1011020935550.29422@eeebox2.perex-int.cz> (raw)
In-Reply-To: <4CCFCA6A.8010803@ladisch.de>

On Tue, 2 Nov 2010, Clemens Ladisch wrote:

>> + * It is not allowed to call this function when given configuration is not exactly one.
>> ...
>> +int snd_pcm_hw_params_can_disable_period_irq(const snd_pcm_hw_params_t *params)
>
> This function is useless because it cannot be called before
> snd_pcm_hw_params_set_period_irq().

I don't think so. The info bits from the driver are used in this check 
which are read-only.

>> + * This function should be called only on devices where
>> + * #snd_pcm_hw_params_can_disable_period_irq() returns true. (too late, FIXME)
>
> Therefore, this paragraph needs to go away.
>
> I think there should be a flag that can be added to snd_pcm_open, like
> SND_PCM_NO_AUTO_RESAMPLE.

It's not required. It's better to allow checking if no period update 
feature is available after snd_pcm_open().

 						Jaroslav

-----
Jaroslav Kysela <perex@perex.cz>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.

  parent reply	other threads:[~2010-11-02  8:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-01 22:13 [PATCH 1/2] pcm: pass hw_params flags to slave Pierre-Louis Bossart
2010-11-01 22:13 ` [PATCH 2/2] add API to allow disabling period interrupt Pierre-Louis Bossart
2010-11-02  7:28   ` Takashi Iwai
2010-11-02  8:23   ` Clemens Ladisch
2010-11-02  8:34     ` Jaroslav Kysela
2010-11-02  8:38     ` Jaroslav Kysela [this message]
2010-11-02  9:04       ` Clemens Ladisch
2010-11-02  9:52         ` Jaroslav Kysela
2010-11-02 13:12           ` pl bossart
2010-11-03  7:38             ` Jaroslav Kysela
2010-11-08 20:58               ` pl bossart
2010-11-08 21:03                 ` Jaroslav Kysela
2010-11-02  7:27 ` [PATCH 1/2] pcm: pass hw_params flags to slave Takashi Iwai
2010-11-02 12:52   ` pl bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1011020935550.29422@eeebox2.perex-int.cz \
    --to=perex@perex.cz \
    --cc=alsa-devel@alsa-project.org \
    --cc=bossart.nospam@gmail.com \
    --cc=clemens@ladisch.de \
    --cc=pierre-louis.bossart@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.