Re: [PATCH 1/2] pcm: pass hw_params flags to slave

[Takashi Iwai <tiwai@suse.de>]

At Mon,  1 Nov 2010 17:13:33 -0500,
Pierre-Louis Bossart wrote:
> 
> fix required before interrupt disabling routines patch can be applied.
> Without this fix, the interrupts are only disabled when accessing
> directly hw devices.
> 
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@intel.com>

I'm a bit skeptical whether this is safe to apply.
The plugins might not be always transparent.  Double-check whether
this doesn't break all plugins behaviors.


thanks,

Takashi


> ---
>  src/pcm/pcm_params.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/pcm/pcm_params.c b/src/pcm/pcm_params.c
> index 3a90bcd..416b081 100644
> --- a/src/pcm/pcm_params.c
> +++ b/src/pcm/pcm_params.c
> @@ -2126,6 +2126,7 @@ int _snd_pcm_hw_params_refine(snd_pcm_hw_params_t *params,
>  			err = changed;
>  	}
>  	params->info &= src->info;
> +        params->flags = src->flags; /* propagate flags to slave */
>  	return err;
>  }
>  
> -- 
> 1.7.2.3
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>