All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, dlaor@redhat.com,
	ananth@in.ibm.com, kvm@vger.kernel.org, mst@redhat.com,
	mtosatti@redhat.com, qemu-devel@nongnu.org,
	vatsa@linux.vnet.ibm.com, blauwirbel@gmail.com,
	ohmura.kei@lab.ntt.co.jp, avi@redhat.com,
	psuriset@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode.
Date: Sat, 29 Jan 2011 00:31:48 +0900	[thread overview]
Message-ID: <AANLkTimaAqcFipREj+XOdprfoL=Sy_nu=_=cjbjJZFD2@mail.gmail.com> (raw)
In-Reply-To: <4D42DC5E.8060203@redhat.com>

2011/1/29 Paolo Bonzini <pbonzini@redhat.com>:
> On 01/28/2011 04:05 PM, Yoshiaki Tamura wrote:
>>
>> Having a scheme like "kemari:tcp:host:port" looks quite
>> challenging to me.  We can of course add some quick hacks for it,
>> but adding a nice layered architecture should be more
>> appropriate.  Similar to protocols and formats in block layer?
>> At the same time, I want to avoid anything over engineered.
>
> I was simply thinking of
>
>   if (strstart (uri, "kemari:", &p)) {
>       ft_mode = FT_INIT;
>       uri = p;
>   }
>
> :)

That's the hack I was imaging :)

Maybe this is just an issue of preference, but I'm not sure
adding "kemari:" to be intuitive.  If there were similar
extensions having the same problem, I would have agreed quickly.
I originally didn't have this idea, but simply adding -kemari
separate from -incoming isn't enough?

Thanks,

Yoshi

> I think the same could be done for outgoing migration instead of -k
> actually.
>
> Paolo
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

WARNING: multiple messages have this Message-ID (diff)
From: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, mtosatti@redhat.com,
	ananth@in.ibm.com, kvm@vger.kernel.org, mst@redhat.com,
	dlaor@redhat.com, qemu-devel@nongnu.org,
	vatsa@linux.vnet.ibm.com, blauwirbel@gmail.com,
	ohmura.kei@lab.ntt.co.jp, avi@redhat.com,
	psuriset@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode.
Date: Sat, 29 Jan 2011 00:31:48 +0900	[thread overview]
Message-ID: <AANLkTimaAqcFipREj+XOdprfoL=Sy_nu=_=cjbjJZFD2@mail.gmail.com> (raw)
In-Reply-To: <4D42DC5E.8060203@redhat.com>

2011/1/29 Paolo Bonzini <pbonzini@redhat.com>:
> On 01/28/2011 04:05 PM, Yoshiaki Tamura wrote:
>>
>> Having a scheme like "kemari:tcp:host:port" looks quite
>> challenging to me.  We can of course add some quick hacks for it,
>> but adding a nice layered architecture should be more
>> appropriate.  Similar to protocols and formats in block layer?
>> At the same time, I want to avoid anything over engineered.
>
> I was simply thinking of
>
>   if (strstart (uri, "kemari:", &p)) {
>       ft_mode = FT_INIT;
>       uri = p;
>   }
>
> :)

That's the hack I was imaging :)

Maybe this is just an issue of preference, but I'm not sure
adding "kemari:" to be intuitive.  If there were similar
extensions having the same problem, I would have agreed quickly.
I originally didn't have this idea, but simply adding -kemari
separate from -incoming isn't enough?

Thanks,

Yoshi

> I think the same could be done for outgoing migration instead of -k
> actually.
>
> Paolo
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

  reply	other threads:[~2011-01-28 15:31 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-28  7:21 [PATCH 00/19] Kemari for KVM v0.2.8 Yoshiaki Tamura
2011-01-28  7:21 ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 01/19] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer() Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 02/19] Introduce read() to FdMigrationState Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 03/19] Introduce skip_header parameter to qemu_loadvm_state() Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 04/19] qemu-char: export socket_set_nodelay() Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 05/19] vl.c: add deleted flag for deleting the handler Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 06/19] virtio: decrement last_avail_idx with inuse before saving Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 07/19] Introduce fault tolerant VM transaction QEMUFile and ft_mode Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 08/19] savevm: introduce util functions to control ft_trans_file from savevm layer Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 09/19] Introduce event-tap Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 10/19] Call init handler of event-tap at main() in vl.c Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 11/19] ioport: insert event_tap_ioport() to ioport_write() Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 12/19] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 13/19] net: insert event-tap to qemu_send_packet() and qemu_sendv_packet_async() Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 14/19] block: insert event-tap to bdrv_aio_writev(), bdrv_aio_flush() and bdrv_flush() Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28  9:10   ` Kevin Wolf
2011-01-28  9:10     ` [Qemu-devel] " Kevin Wolf
2011-01-28  7:21 ` [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin,commit} Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit} Yoshiaki Tamura
2011-01-28 13:26   ` [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin,commit} Paolo Bonzini
2011-01-28 13:26     ` [Qemu-devel] Re: [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit} Paolo Bonzini
2011-01-28 14:41     ` [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin,commit} Yoshiaki Tamura
2011-01-28 14:41       ` [Qemu-devel] Re: [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit} Yoshiaki Tamura
2011-02-01 18:21       ` [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin,commit} Yoshiaki Tamura
2011-02-01 18:21         ` [Qemu-devel] Re: [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit} Yoshiaki Tamura
2011-02-02  8:05         ` [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin,commit} Paolo Bonzini
2011-02-02  8:05           ` [Qemu-devel] Re: [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit} Paolo Bonzini
2011-02-02  8:30           ` [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin,commit} Yoshiaki Tamura
2011-02-02  8:30             ` [Qemu-devel] Re: [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit} Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 16/19] migration: introduce migrate_ft_trans_{put,get}_ready(), and modify migrate_fd_put_ready() when ft_mode is on Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] [PATCH 16/19] migration: introduce migrate_ft_trans_{put, get}_ready(), " Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 17/19] migration-tcp: modify tcp_accept_incoming_migration() to handle ft_mode, and add a hack not to close fd when ft_mode is enabled Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari) Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28  7:21 ` [PATCH 19/19] migration: add a parser to accept FT migration incoming mode Yoshiaki Tamura
2011-01-28  7:21   ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28 12:58   ` Paolo Bonzini
2011-01-28 12:58     ` [Qemu-devel] " Paolo Bonzini
2011-01-28 13:53     ` Yoshiaki Tamura
2011-01-28 13:53       ` [Qemu-devel] " Yoshiaki Tamura
2011-01-28 14:43       ` Paolo Bonzini
2011-01-28 14:43         ` [Qemu-devel] " Paolo Bonzini
2011-01-28 15:05         ` Yoshiaki Tamura
2011-01-28 15:05           ` Yoshiaki Tamura
2011-01-28 15:10           ` Paolo Bonzini
2011-01-28 15:10             ` Paolo Bonzini
2011-01-28 15:31             ` Yoshiaki Tamura [this message]
2011-01-28 15:31               ` Yoshiaki Tamura
2011-01-28 15:40               ` Paolo Bonzini
2011-01-28 15:40                 ` Paolo Bonzini
2011-01-29  9:31                 ` Yoshiaki Tamura
2011-01-29  9:31                   ` Yoshiaki Tamura
2011-01-29 10:43                   ` Paolo Bonzini
2011-01-29 10:43                     ` Paolo Bonzini
2011-01-29 11:32                     ` Yoshiaki Tamura
2011-01-29 11:32                       ` Yoshiaki Tamura
2011-01-29 12:21                       ` Paolo Bonzini
2011-01-29 12:21                         ` Paolo Bonzini
2011-01-29 13:29                         ` Yoshiaki Tamura
2011-01-29 13:29                           ` Yoshiaki Tamura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTimaAqcFipREj+XOdprfoL=Sy_nu=_=cjbjJZFD2@mail.gmail.com' \
    --to=tamura.yoshiaki@lab.ntt.co.jp \
    --cc=aliguori@us.ibm.com \
    --cc=ananth@in.ibm.com \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=dlaor@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=ohmura.kei@lab.ntt.co.jp \
    --cc=pbonzini@redhat.com \
    --cc=psuriset@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=vatsa@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.