All of lore.kernel.org
 help / color / mirror / Atom feed
From: H Hartley Sweeten <hartleys@visionengravers.com>
To: Mika Westerberg <mika.westerberg@iki.fi>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"ryan@bluewatersys.com" <ryan@bluewatersys.com>,
	"kernel@wantstofly.org" <kernel@wantstofly.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v2 1/5] ep93xx: set DMA masks for the ep93xx_eth
Date: Thu, 9 Jun 2011 16:26:08 -0500	[thread overview]
Message-ID: <ADE657CA350FB648AAC2C43247A983F001F3820B863A@AUSP01VMBX24.collaborationhost.net> (raw)
In-Reply-To: <20110609204113.GE2857@acer>

On Thursday, June 09, 2011 1:41 PM, Mika Westerberg wrote:
> On Thu, Jun 09, 2011 at 03:27:11PM -0500, H Hartley Sweeten wrote:
>> On Thursday, June 02, 2011 12:00 PM, Mika Westerberg wrote:
>>>
>>> As the driver is now passing platform device to the DMA mapping functions,
>>> we should give it valid DMA masks.
>>>
>>> Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi>
>>> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
>> 
>> Since you made this patch the first in the series the commit message is not
>> quite right.  Other than that:
>> 
>> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>
> Ah, right. I forgot to change the commit message. How about following?
>
> From: Mika Westerberg <mika.westerberg@iki.fi>
> Subject: [PATCH 1/5] ep93xx: set DMA masks for the ep93xx_eth
>
> Since the driver uses the DMA API, we should pass it valid DMA masks.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi>
> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>

I like that better.

Thanks,
Hartley

WARNING: multiple messages have this Message-ID (diff)
From: hartleys@visionengravers.com (H Hartley Sweeten)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/5] ep93xx: set DMA masks for the ep93xx_eth
Date: Thu, 9 Jun 2011 16:26:08 -0500	[thread overview]
Message-ID: <ADE657CA350FB648AAC2C43247A983F001F3820B863A@AUSP01VMBX24.collaborationhost.net> (raw)
In-Reply-To: <20110609204113.GE2857@acer>

On Thursday, June 09, 2011 1:41 PM, Mika Westerberg wrote:
> On Thu, Jun 09, 2011 at 03:27:11PM -0500, H Hartley Sweeten wrote:
>> On Thursday, June 02, 2011 12:00 PM, Mika Westerberg wrote:
>>>
>>> As the driver is now passing platform device to the DMA mapping functions,
>>> we should give it valid DMA masks.
>>>
>>> Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi>
>>> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
>> 
>> Since you made this patch the first in the series the commit message is not
>> quite right.  Other than that:
>> 
>> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>
> Ah, right. I forgot to change the commit message. How about following?
>
> From: Mika Westerberg <mika.westerberg@iki.fi>
> Subject: [PATCH 1/5] ep93xx: set DMA masks for the ep93xx_eth
>
> Since the driver uses the DMA API, we should pass it valid DMA masks.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi>
> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>

I like that better.

Thanks,
Hartley

  reply	other threads:[~2011-06-09 21:26 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02 18:59 [PATCH v2 1/5] ep93xx: set DMA masks for the ep93xx_eth Mika Westerberg
2011-06-02 18:59 ` Mika Westerberg
2011-06-02 18:59 ` [PATCH v2 2/5] net: ep93xx_eth: pass struct device to DMA API functions Mika Westerberg
2011-06-02 18:59   ` Mika Westerberg
2011-06-09 20:41   ` H Hartley Sweeten
2011-06-09 20:41     ` H Hartley Sweeten
2011-06-09 23:40   ` H Hartley Sweeten
2011-06-09 23:40     ` H Hartley Sweeten
2011-06-10 16:55     ` Mika Westerberg
2011-06-10 16:55       ` Mika Westerberg
2011-06-10 17:30       ` H Hartley Sweeten
2011-06-10 17:30         ` H Hartley Sweeten
2011-06-02 18:59 ` [PATCH v2 3/5] net: ep93xx_eth: allocate buffers using kmalloc() Mika Westerberg
2011-06-02 18:59   ` Mika Westerberg
2011-06-09 20:53   ` H Hartley Sweeten
2011-06-09 20:53     ` H Hartley Sweeten
2011-06-02 18:59 ` [PATCH v2 4/5] net: ep93xx_eth: drop GFP_DMA from call to dma_alloc_coherent() Mika Westerberg
2011-06-02 18:59   ` Mika Westerberg
2011-06-09 20:59   ` H Hartley Sweeten
2011-06-09 20:59     ` H Hartley Sweeten
2011-06-02 18:59 ` [PATCH v2 5/5] net: ep93xx_eth: fix DMA API violations Mika Westerberg
2011-06-02 18:59   ` Mika Westerberg
2011-06-09 21:25   ` H Hartley Sweeten
2011-06-09 21:25     ` H Hartley Sweeten
2011-06-05  8:34 ` [PATCH v2 1/5] ep93xx: set DMA masks for the ep93xx_eth Petr Štetiar
2011-06-05  8:34   ` Petr Štetiar
2011-06-05  8:59   ` Mika Westerberg
2011-06-05  8:59     ` Mika Westerberg
2011-06-05  9:10     ` Petr Štetiar
2011-06-05  9:10       ` Petr Štetiar
2011-06-05 21:08     ` David Miller
2011-06-05 21:08       ` David Miller
2011-06-06 17:26       ` Mika Westerberg
2011-06-06 17:26         ` Mika Westerberg
2011-06-06 17:48         ` H Hartley Sweeten
2011-06-06 17:48           ` H Hartley Sweeten
2011-06-09 19:50           ` Mika Westerberg
2011-06-09 19:50             ` Mika Westerberg
2011-06-09 20:18             ` H Hartley Sweeten
2011-06-09 20:18               ` H Hartley Sweeten
2011-06-09 20:23               ` Mika Westerberg
2011-06-09 20:23                 ` Mika Westerberg
2011-06-15 10:21           ` Lennert Buytenhek
2011-06-15 10:21             ` Lennert Buytenhek
2011-06-10 15:47     ` Petr Štetiar
2011-06-10 15:47       ` Petr Štetiar
2011-06-10 16:56       ` Mika Westerberg
2011-06-10 16:56         ` Mika Westerberg
2011-06-09 20:27 ` H Hartley Sweeten
2011-06-09 20:27   ` H Hartley Sweeten
2011-06-09 20:41   ` Mika Westerberg
2011-06-09 20:41     ` Mika Westerberg
2011-06-09 21:26     ` H Hartley Sweeten [this message]
2011-06-09 21:26       ` H Hartley Sweeten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ADE657CA350FB648AAC2C43247A983F001F3820B863A@AUSP01VMBX24.collaborationhost.net \
    --to=hartleys@visionengravers.com \
    --cc=kernel@wantstofly.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mika.westerberg@iki.fi \
    --cc=netdev@vger.kernel.org \
    --cc=ryan@bluewatersys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.