All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@iki.fi>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"kernel@wantstofly.org" <kernel@wantstofly.org>,
	rmallon@gmail.com
Subject: Re: [PATCH v2 2/5] net: ep93xx_eth: pass struct device to DMA API functions
Date: Fri, 10 Jun 2011 19:55:45 +0300	[thread overview]
Message-ID: <20110610165545.GA2753@acer> (raw)
In-Reply-To: <ADE657CA350FB648AAC2C43247A983F001F3820B8699@AUSP01VMBX24.collaborationhost.net>

On Thu, Jun 09, 2011 at 06:40:21PM -0500, H Hartley Sweeten wrote:
> 
> I just noticed this macro in include/linux/netdevice.h
> 
> /* Set the sysfs physical device reference for the network logical device
>  * if set prior to registration will cause a symlink during initialization.
>  */
> #define SET_NETDEV_DEV(net, pdev)       ((net)->dev.parent = (pdev))
> 
> Is there anyway you could use that macro in the probe to save the platform_device
> (with it's associated device) instead of introducing a new struct device * in the
> private data?

Nice finding, thanks.

I'll look into that and send new version of the whole series soon.

WARNING: multiple messages have this Message-ID (diff)
From: mika.westerberg@iki.fi (Mika Westerberg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] net: ep93xx_eth: pass struct device to DMA API functions
Date: Fri, 10 Jun 2011 19:55:45 +0300	[thread overview]
Message-ID: <20110610165545.GA2753@acer> (raw)
In-Reply-To: <ADE657CA350FB648AAC2C43247A983F001F3820B8699@AUSP01VMBX24.collaborationhost.net>

On Thu, Jun 09, 2011 at 06:40:21PM -0500, H Hartley Sweeten wrote:
> 
> I just noticed this macro in include/linux/netdevice.h
> 
> /* Set the sysfs physical device reference for the network logical device
>  * if set prior to registration will cause a symlink during initialization.
>  */
> #define SET_NETDEV_DEV(net, pdev)       ((net)->dev.parent = (pdev))
> 
> Is there anyway you could use that macro in the probe to save the platform_device
> (with it's associated device) instead of introducing a new struct device * in the
> private data?

Nice finding, thanks.

I'll look into that and send new version of the whole series soon.

  reply	other threads:[~2011-06-10 16:58 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02 18:59 [PATCH v2 1/5] ep93xx: set DMA masks for the ep93xx_eth Mika Westerberg
2011-06-02 18:59 ` Mika Westerberg
2011-06-02 18:59 ` [PATCH v2 2/5] net: ep93xx_eth: pass struct device to DMA API functions Mika Westerberg
2011-06-02 18:59   ` Mika Westerberg
2011-06-09 20:41   ` H Hartley Sweeten
2011-06-09 20:41     ` H Hartley Sweeten
2011-06-09 23:40   ` H Hartley Sweeten
2011-06-09 23:40     ` H Hartley Sweeten
2011-06-10 16:55     ` Mika Westerberg [this message]
2011-06-10 16:55       ` Mika Westerberg
2011-06-10 17:30       ` H Hartley Sweeten
2011-06-10 17:30         ` H Hartley Sweeten
2011-06-02 18:59 ` [PATCH v2 3/5] net: ep93xx_eth: allocate buffers using kmalloc() Mika Westerberg
2011-06-02 18:59   ` Mika Westerberg
2011-06-09 20:53   ` H Hartley Sweeten
2011-06-09 20:53     ` H Hartley Sweeten
2011-06-02 18:59 ` [PATCH v2 4/5] net: ep93xx_eth: drop GFP_DMA from call to dma_alloc_coherent() Mika Westerberg
2011-06-02 18:59   ` Mika Westerberg
2011-06-09 20:59   ` H Hartley Sweeten
2011-06-09 20:59     ` H Hartley Sweeten
2011-06-02 18:59 ` [PATCH v2 5/5] net: ep93xx_eth: fix DMA API violations Mika Westerberg
2011-06-02 18:59   ` Mika Westerberg
2011-06-09 21:25   ` H Hartley Sweeten
2011-06-09 21:25     ` H Hartley Sweeten
2011-06-05  8:34 ` [PATCH v2 1/5] ep93xx: set DMA masks for the ep93xx_eth Petr Štetiar
2011-06-05  8:34   ` Petr Štetiar
2011-06-05  8:59   ` Mika Westerberg
2011-06-05  8:59     ` Mika Westerberg
2011-06-05  9:10     ` Petr Štetiar
2011-06-05  9:10       ` Petr Štetiar
2011-06-05 21:08     ` David Miller
2011-06-05 21:08       ` David Miller
2011-06-06 17:26       ` Mika Westerberg
2011-06-06 17:26         ` Mika Westerberg
2011-06-06 17:48         ` H Hartley Sweeten
2011-06-06 17:48           ` H Hartley Sweeten
2011-06-09 19:50           ` Mika Westerberg
2011-06-09 19:50             ` Mika Westerberg
2011-06-09 20:18             ` H Hartley Sweeten
2011-06-09 20:18               ` H Hartley Sweeten
2011-06-09 20:23               ` Mika Westerberg
2011-06-09 20:23                 ` Mika Westerberg
2011-06-15 10:21           ` Lennert Buytenhek
2011-06-15 10:21             ` Lennert Buytenhek
2011-06-10 15:47     ` Petr Štetiar
2011-06-10 15:47       ` Petr Štetiar
2011-06-10 16:56       ` Mika Westerberg
2011-06-10 16:56         ` Mika Westerberg
2011-06-09 20:27 ` H Hartley Sweeten
2011-06-09 20:27   ` H Hartley Sweeten
2011-06-09 20:41   ` Mika Westerberg
2011-06-09 20:41     ` Mika Westerberg
2011-06-09 21:26     ` H Hartley Sweeten
2011-06-09 21:26       ` H Hartley Sweeten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110610165545.GA2753@acer \
    --to=mika.westerberg@iki.fi \
    --cc=hartleys@visionengravers.com \
    --cc=kernel@wantstofly.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=rmallon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.