* [PATCH] mfd: omap-usb-host: Make TLL mode work again
@ 2011-08-18 10:44 ` Anand Gadiyar
0 siblings, 0 replies; 9+ messages in thread
From: Anand Gadiyar @ 2011-08-18 10:44 UTC (permalink / raw)
To: linux-kernel, linux-omap, linux-usb
Cc: Anand Gadiyar, Keshava Munegowda, Samuel Ortiz
This code section seems to have been accidentally copy pasted.
It causes incorrect bits to be set up in the TLL_CHANNEL_CONF
register and prevents the TLL mode from working correctly.
Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
Cc: Keshava Munegowda <keshava_mgowda@ti.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>
---
Against v3.1-rc2; tested against linux-next as of 20110817 as well.
This probably needs to go to -stable as well. The original code
by me worked fine but this was broken during the code reorganization
Keshava did.
drivers/mfd/omap-usb-host.c | 1 -
1 file changed, 1 deletion(-)
Index: linux-2.6/drivers/mfd/omap-usb-host.c
===================================================================
--- linux-2.6.orig/drivers/mfd/omap-usb-host.c
+++ linux-2.6/drivers/mfd/omap-usb-host.c
@@ -676,7 +676,6 @@ static void usbhs_omap_tll_init(struct d
| OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
| OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
- reg |= (1 << (i + 1));
} else
continue;
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] mfd: omap-usb-host: Make TLL mode work again
@ 2011-08-18 10:44 ` Anand Gadiyar
0 siblings, 0 replies; 9+ messages in thread
From: Anand Gadiyar @ 2011-08-18 10:44 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA
Cc: Anand Gadiyar, Keshava Munegowda, Samuel Ortiz
This code section seems to have been accidentally copy pasted.
It causes incorrect bits to be set up in the TLL_CHANNEL_CONF
register and prevents the TLL mode from working correctly.
Signed-off-by: Anand Gadiyar <gadiyar-l0cyMroinI0@public.gmane.org>
Cc: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org>
Cc: Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
Against v3.1-rc2; tested against linux-next as of 20110817 as well.
This probably needs to go to -stable as well. The original code
by me worked fine but this was broken during the code reorganization
Keshava did.
drivers/mfd/omap-usb-host.c | 1 -
1 file changed, 1 deletion(-)
Index: linux-2.6/drivers/mfd/omap-usb-host.c
===================================================================
--- linux-2.6.orig/drivers/mfd/omap-usb-host.c
+++ linux-2.6/drivers/mfd/omap-usb-host.c
@@ -676,7 +676,6 @@ static void usbhs_omap_tll_init(struct d
| OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
| OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
- reg |= (1 << (i + 1));
} else
continue;
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: omap-usb-host: Make TLL mode work again
2011-08-18 10:44 ` Anand Gadiyar
(?)
@ 2011-08-18 11:22 ` Munegowda, Keshava
2011-08-18 11:24 ` Felipe Balbi
-1 siblings, 1 reply; 9+ messages in thread
From: Munegowda, Keshava @ 2011-08-18 11:22 UTC (permalink / raw)
To: Anand Gadiyar, Balbi, Felipe, Samuel Ortiz
Cc: linux-kernel, linux-omap, linux-usb
On Thu, Aug 18, 2011 at 4:14 PM, Anand Gadiyar <gadiyar@ti.com> wrote:
> This code section seems to have been accidentally copy pasted.
> It causes incorrect bits to be set up in the TLL_CHANNEL_CONF
> register and prevents the TLL mode from working correctly.
>
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> Cc: Keshava Munegowda <keshava_mgowda@ti.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> ---
> Against v3.1-rc2; tested against linux-next as of 20110817 as well.
>
> This probably needs to go to -stable as well. The original code
> by me worked fine but this was broken during the code reorganization
> Keshava did.
>
> drivers/mfd/omap-usb-host.c | 1 -
> 1 file changed, 1 deletion(-)
>
> Index: linux-2.6/drivers/mfd/omap-usb-host.c
> ===================================================================
> --- linux-2.6.orig/drivers/mfd/omap-usb-host.c
> +++ linux-2.6/drivers/mfd/omap-usb-host.c
> @@ -676,7 +676,6 @@ static void usbhs_omap_tll_init(struct d
> | OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
> | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
>
> - reg |= (1 << (i + 1));
> } else
> continue;
Samuel Ortiz and balbi
please ack this patch
I am going to re-base runtime pm patches on top of this patch.
Regards
keshava
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: omap-usb-host: Make TLL mode work again
2011-08-18 11:22 ` Munegowda, Keshava
@ 2011-08-18 11:24 ` Felipe Balbi
2011-08-18 11:44 ` Gadiyar, Anand
0 siblings, 1 reply; 9+ messages in thread
From: Felipe Balbi @ 2011-08-18 11:24 UTC (permalink / raw)
To: Munegowda, Keshava
Cc: Anand Gadiyar, Balbi, Felipe, Samuel Ortiz, linux-kernel,
linux-omap, linux-usb
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
HI,
On Thu, Aug 18, 2011 at 04:52:22PM +0530, Munegowda, Keshava wrote:
> On Thu, Aug 18, 2011 at 4:14 PM, Anand Gadiyar <gadiyar@ti.com> wrote:
> > This code section seems to have been accidentally copy pasted.
> > It causes incorrect bits to be set up in the TLL_CHANNEL_CONF
> > register and prevents the TLL mode from working correctly.
> >
> > Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> > Cc: Keshava Munegowda <keshava_mgowda@ti.com>
> > Cc: Samuel Ortiz <sameo@linux.intel.com>
Sam, you can apply this one:
Acked-by: Felipe Balbi <balbi@ti.com>
But I think it needs to be resent with Cc: stable@kernel.org
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] mfd: omap-usb-host: Make TLL mode work again
2011-08-18 11:24 ` Felipe Balbi
@ 2011-08-18 11:44 ` Gadiyar, Anand
2011-08-18 18:26 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Gadiyar, Anand @ 2011-08-18 11:44 UTC (permalink / raw)
To: Balbi, Felipe, Munegowda, Keshava
Cc: Samuel Ortiz, linux-kernel, linux-omap, linux-usb
Balbi, Felipe wrote:
> HI,
>
> On Thu, Aug 18, 2011 at 04:52:22PM +0530, Munegowda, Keshava wrote:
> > On Thu, Aug 18, 2011 at 4:14 PM, Anand Gadiyar <gadiyar@ti.com> wrote:
> > > This code section seems to have been accidentally copy pasted.
> > > It causes incorrect bits to be set up in the TLL_CHANNEL_CONF
> > > register and prevents the TLL mode from working correctly.
> > >
> > > Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> > > Cc: Keshava Munegowda <keshava_mgowda@ti.com>
> > > Cc: Samuel Ortiz <sameo@linux.intel.com>
>
> Sam, you can apply this one:
>
> Acked-by: Felipe Balbi <balbi@ti.com>
>
> But I think it needs to be resent with Cc: stable@kernel.org
I'm trying to avoid "Cc: stable@kernel.org" since RMK complained about
this on the Linux ARM kernel list. [1]
- Anand
[1] http://marc.info/?l=linux-arm-kernel&m=131107297012093&w=2
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: omap-usb-host: Make TLL mode work again
2011-08-18 11:44 ` Gadiyar, Anand
@ 2011-08-18 18:26 ` Greg KH
2011-08-19 5:12 ` Gadiyar, Anand
0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2011-08-18 18:26 UTC (permalink / raw)
To: Gadiyar, Anand
Cc: Balbi, Felipe, Munegowda, Keshava, Samuel Ortiz, linux-kernel,
linux-omap, linux-usb
On Thu, Aug 18, 2011 at 05:14:17PM +0530, Gadiyar, Anand wrote:
> Balbi, Felipe wrote:
> > HI,
> >
> > On Thu, Aug 18, 2011 at 04:52:22PM +0530, Munegowda, Keshava wrote:
> > > On Thu, Aug 18, 2011 at 4:14 PM, Anand Gadiyar <gadiyar@ti.com> wrote:
> > > > This code section seems to have been accidentally copy pasted.
> > > > It causes incorrect bits to be set up in the TLL_CHANNEL_CONF
> > > > register and prevents the TLL mode from working correctly.
> > > >
> > > > Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> > > > Cc: Keshava Munegowda <keshava_mgowda@ti.com>
> > > > Cc: Samuel Ortiz <sameo@linux.intel.com>
> >
> > Sam, you can apply this one:
> >
> > Acked-by: Felipe Balbi <balbi@ti.com>
> >
> > But I think it needs to be resent with Cc: stable@kernel.org
>
> I'm trying to avoid "Cc: stable@kernel.org" since RMK complained about
> this on the Linux ARM kernel list. [1]
Why would he do that? You need to put the Cc: in the signed off by
area, and all will be fine. If you just put it in your email, you will
get an automated email from me telling you to go read
Documentation/stable_kernel_rules.txt which tells you exactly how to do
this properly.
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] mfd: omap-usb-host: Make TLL mode work again
2011-08-18 18:26 ` Greg KH
@ 2011-08-19 5:12 ` Gadiyar, Anand
0 siblings, 0 replies; 9+ messages in thread
From: Gadiyar, Anand @ 2011-08-19 5:12 UTC (permalink / raw)
To: Greg KH
Cc: Balbi, Felipe, Munegowda, Keshava, Samuel Ortiz, linux-kernel,
linux-omap, linux-usb
Greg KH wrote:
> On Thu, Aug 18, 2011 at 05:14:17PM +0530, Gadiyar, Anand wrote:
> > Balbi, Felipe wrote:
> > > HI,
> > >
> > > On Thu, Aug 18, 2011 at 04:52:22PM +0530, Munegowda, Keshava wrote:
> > > > On Thu, Aug 18, 2011 at 4:14 PM, Anand Gadiyar <gadiyar@ti.com> wrote:
> > > > > This code section seems to have been accidentally copy pasted.
> > > > > It causes incorrect bits to be set up in the TLL_CHANNEL_CONF
> > > > > register and prevents the TLL mode from working correctly.
> > > > >
> > > > > Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> > > > > Cc: Keshava Munegowda <keshava_mgowda@ti.com>
> > > > > Cc: Samuel Ortiz <sameo@linux.intel.com>
> > >
> > > Sam, you can apply this one:
> > >
> > > Acked-by: Felipe Balbi <balbi@ti.com>
> > >
> > > But I think it needs to be resent with Cc: stable@kernel.org
> >
> > I'm trying to avoid "Cc: stable@kernel.org" since RMK complained about
> > this on the Linux ARM kernel list. [1]
>
> Why would he do that? You need to put the Cc: in the signed off by
> area, and all will be fine. If you just put it in your email, you will
> get an automated email from me telling you to go read
> Documentation/stable_kernel_rules.txt which tells you exactly how to do
> this properly.
Thanks for clearing that up.
I'm resending with Felipe's ack and CCing stable@kernel.org.
- Anand
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: omap-usb-host: Make TLL mode work again
@ 2011-08-22 14:45 ` Samuel Ortiz
0 siblings, 0 replies; 9+ messages in thread
From: Samuel Ortiz @ 2011-08-22 14:45 UTC (permalink / raw)
To: Anand Gadiyar; +Cc: linux-kernel, linux-omap, linux-usb, Keshava Munegowda
Hi Anand,
On Thu, Aug 18, 2011 at 04:14:31PM +0530, Anand Gadiyar wrote:
> This code section seems to have been accidentally copy pasted.
> It causes incorrect bits to be set up in the TLL_CHANNEL_CONF
> register and prevents the TLL mode from working correctly.
Patch applied, with Felipe's ACK and stable@kernel.org Cc'ed.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: omap-usb-host: Make TLL mode work again
@ 2011-08-22 14:45 ` Samuel Ortiz
0 siblings, 0 replies; 9+ messages in thread
From: Samuel Ortiz @ 2011-08-22 14:45 UTC (permalink / raw)
To: Anand Gadiyar
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA, Keshava Munegowda
Hi Anand,
On Thu, Aug 18, 2011 at 04:14:31PM +0530, Anand Gadiyar wrote:
> This code section seems to have been accidentally copy pasted.
> It causes incorrect bits to be set up in the TLL_CHANNEL_CONF
> register and prevents the TLL mode from working correctly.
Patch applied, with Felipe's ACK and stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc'ed.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-08-22 14:45 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-18 10:44 [PATCH] mfd: omap-usb-host: Make TLL mode work again Anand Gadiyar
2011-08-18 10:44 ` Anand Gadiyar
2011-08-18 11:22 ` Munegowda, Keshava
2011-08-18 11:24 ` Felipe Balbi
2011-08-18 11:44 ` Gadiyar, Anand
2011-08-18 18:26 ` Greg KH
2011-08-19 5:12 ` Gadiyar, Anand
2011-08-22 14:45 ` Samuel Ortiz
2011-08-22 14:45 ` Samuel Ortiz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.