From: "A.s. Dong" <aisheng.dong@nxp.com> To: Jassi Brar <jassisinghbrar@gmail.com>, Oleksij Rempel <o.rempel@pengutronix.de> Cc: Mark Rutland <mark.rutland@arm.com>, Devicetree List <devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, ", linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, srv_heupstream" <linux-arm-kernel@lists.infradead.org>, ", Sascha Hauer" <kernel@pengutronix.de>, Fabio Estevam <fabio.estevam@nxp.com>, Shawn Guo <shawnguo@kernel.org>, Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>, dl-linux-imx <linux-imx@nxp.com> Subject: RE: [PATCH v8 4/4] mailbox: Add support for i.MX7D messaging unit Date: Wed, 1 Aug 2018 07:44:43 +0000 [thread overview] Message-ID: <AM0PR04MB42118C26A7C5F80FD46FBB9B802D0@AM0PR04MB4211.eurprd04.prod.outlook.com> (raw) In-Reply-To: <CABb+yY2PN=LN3bgTTzL9SpA43atughAbS1OjNsg0XZg42JxD3w@mail.gmail.com> > -----Original Message----- > From: Jassi Brar [mailto:jassisinghbrar@gmail.com] [...] > > + > > +static void imx_mu_txdb_work(struct work_struct *work) { > > + struct imx_mu_con_priv *cp = > > + container_of(work, struct imx_mu_con_priv, work); > > + mbox_chan_txdone(cp->chan, 0); } > > > The api assumes a controller have same type of channels. So we are having > to do this here. > I am not sure, but would declaring two mailbox controllers (one with > doorbells and the other data channels) work? > If not, at least we could use a tasklet instead of a work queue? > I'm also a bit curious what the meaning of calling mbox_chan_txdone for a doorbell mailbox? Is there any recommended way to use it? Regards Dong Aisheng
WARNING: multiple messages have this Message-ID (diff)
From: aisheng.dong@nxp.com (A.s. Dong) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v8 4/4] mailbox: Add support for i.MX7D messaging unit Date: Wed, 1 Aug 2018 07:44:43 +0000 [thread overview] Message-ID: <AM0PR04MB42118C26A7C5F80FD46FBB9B802D0@AM0PR04MB4211.eurprd04.prod.outlook.com> (raw) In-Reply-To: <CABb+yY2PN=LN3bgTTzL9SpA43atughAbS1OjNsg0XZg42JxD3w@mail.gmail.com> > -----Original Message----- > From: Jassi Brar [mailto:jassisinghbrar at gmail.com] [...] > > + > > +static void imx_mu_txdb_work(struct work_struct *work) { > > + struct imx_mu_con_priv *cp = > > + container_of(work, struct imx_mu_con_priv, work); > > + mbox_chan_txdone(cp->chan, 0); } > > > The api assumes a controller have same type of channels. So we are having > to do this here. > I am not sure, but would declaring two mailbox controllers (one with > doorbells and the other data channels) work? > If not, at least we could use a tasklet instead of a work queue? > I'm also a bit curious what the meaning of calling mbox_chan_txdone for a doorbell mailbox? Is there any recommended way to use it? Regards Dong Aisheng
next prev parent reply other threads:[~2018-08-01 7:44 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-31 14:11 [PATCH v8 0/4] add mailbox support for i.MX7D Oleksij Rempel 2018-07-31 14:11 ` Oleksij Rempel 2018-07-31 14:11 ` [PATCH v8 1/4] dt-bindings: arm: fsl: add mu binding doc Oleksij Rempel 2018-07-31 14:11 ` Oleksij Rempel 2018-07-31 14:11 ` [PATCH v8 2/4] dt-bindings: mailbox: imx-mu: add generic MU channel support Oleksij Rempel 2018-07-31 14:11 ` Oleksij Rempel 2018-07-31 15:58 ` Jassi Brar 2018-07-31 15:58 ` Jassi Brar 2018-08-01 5:05 ` Oleksij Rempel 2018-08-01 5:05 ` Oleksij Rempel 2018-08-02 10:07 ` A.s. Dong 2018-08-02 10:07 ` A.s. Dong 2018-08-02 14:09 ` Rob Herring 2018-08-02 14:09 ` Rob Herring 2018-08-01 8:58 ` A.s. Dong 2018-08-01 8:58 ` A.s. Dong 2018-08-01 9:58 ` Jassi Brar 2018-08-01 9:58 ` Jassi Brar 2018-08-02 3:37 ` A.s. Dong 2018-08-02 3:37 ` A.s. Dong 2018-07-31 19:09 ` Rob Herring 2018-07-31 19:09 ` Rob Herring 2018-07-31 14:11 ` [PATCH v8 3/4] ARM: dts: imx7s: add i.MX7 messaging unit support Oleksij Rempel 2018-07-31 14:11 ` Oleksij Rempel 2018-07-31 14:11 ` [PATCH v8 4/4] mailbox: Add support for i.MX7D messaging unit Oleksij Rempel 2018-07-31 14:11 ` Oleksij Rempel 2018-07-31 16:21 ` Jassi Brar 2018-07-31 16:21 ` Jassi Brar 2018-08-01 5:31 ` Oleksij Rempel 2018-08-01 5:31 ` Oleksij Rempel 2018-08-01 7:02 ` Jassi Brar 2018-08-01 7:02 ` Jassi Brar 2018-08-01 7:44 ` A.s. Dong [this message] 2018-08-01 7:44 ` A.s. Dong 2018-08-01 9:45 ` Jassi Brar 2018-08-01 9:45 ` Jassi Brar 2018-08-02 3:03 ` A.s. Dong 2018-08-02 3:03 ` A.s. Dong 2018-08-01 7:52 ` A.s. Dong 2018-08-01 7:52 ` A.s. Dong 2018-08-01 8:00 ` Oleksij Rempel 2018-08-01 8:00 ` Oleksij Rempel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AM0PR04MB42118C26A7C5F80FD46FBB9B802D0@AM0PR04MB4211.eurprd04.prod.outlook.com \ --to=aisheng.dong@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=fabio.estevam@nxp.com \ --cc=jassisinghbrar@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=mark.rutland@arm.com \ --cc=o.rempel@pengutronix.de \ --cc=robh+dt@kernel.org \ --cc=shawnguo@kernel.org \ --cc=vladimir_zapolskiy@mentor.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.